* [PATCH] MdeModulePkg/FrameBufferBltLib: Correctly consider SourceX @ 2019-09-24 12:46 Marvin Häuser 2019-09-24 13:01 ` Wu, Hao A 0 siblings, 1 reply; 4+ messages in thread From: Marvin Häuser @ 2019-09-24 12:46 UTC (permalink / raw) To: devel@edk2.groups.io; +Cc: Jian J Wang, Hao A Wu From: Marvin Haeuser <mhaeuser@outlook.de> Currently, SourceX is not considered in the BufferToVideo operation when the 8-bit pixel format is used. Correctly add the resulting offset to prevent image corruption. Cc: Jian J Wang <jian.j.wang@intel.com> Cc: Hao A Wu <hao.a.wu@intel.com> Signed-off-by: Marvin Haeuser <mhaeuser@outlook.de> --- MdeModulePkg/Library/FrameBufferBltLib/FrameBufferBltLib.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MdeModulePkg/Library/FrameBufferBltLib/FrameBufferBltLib.c b/MdeModulePkg/Library/FrameBufferBltLib/FrameBufferBltLib.c index 47c5326e9958..a084cc81d32e 100644 --- a/MdeModulePkg/Library/FrameBufferBltLib/FrameBufferBltLib.c +++ b/MdeModulePkg/Library/FrameBufferBltLib/FrameBufferBltLib.c @@ -504,7 +504,7 @@ FrameBufferBltLibBufferToVideo ( Destination = Configure->FrameBuffer + Offset; if (Configure->PixelFormat == PixelBlueGreenRedReserved8BitPerColor) { - Source = (UINT8 *) BltBuffer + (SrcY * Delta); + Source = (UINT8 *) BltBuffer + (SrcY * Delta) + (SourceX * sizeof (EFI_GRAPHICS_OUTPUT_BLT_PIXEL)); } else { for (IndexX = 0; IndexX < Width; IndexX++) { Blt = -- 2.23.0.windows.1 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] MdeModulePkg/FrameBufferBltLib: Correctly consider SourceX 2019-09-24 12:46 [PATCH] MdeModulePkg/FrameBufferBltLib: Correctly consider SourceX Marvin Häuser @ 2019-09-24 13:01 ` Wu, Hao A 2019-09-24 13:14 ` Gao, Zhichao 0 siblings, 1 reply; 4+ messages in thread From: Wu, Hao A @ 2019-09-24 13:01 UTC (permalink / raw) To: Marvin Häuser, devel@edk2.groups.io, Gao, Zhichao, Ni, Ray Cc: Wang, Jian J > -----Original Message----- > From: Marvin Häuser [mailto:Marvin.Haeuser@outlook.com] > Sent: Tuesday, September 24, 2019 8:46 PM > To: devel@edk2.groups.io > Cc: Wang, Jian J; Wu, Hao A > Subject: [PATCH] MdeModulePkg/FrameBufferBltLib: Correctly consider > SourceX > > From: Marvin Haeuser <mhaeuser@outlook.de> > > Currently, SourceX is not considered in the BufferToVideo operation > when the 8-bit pixel format is used. Correctly add the resulting > offset to prevent image corruption. > > Cc: Jian J Wang <jian.j.wang@intel.com> > Cc: Hao A Wu <hao.a.wu@intel.com> Hello Marvin, In the future, could you help to run the below script: BaseTools/Scripts/GetMaintainer.py to get the reviewers for the proposed patch? Thanks in advance. Hello Zhichao and Ray, Could you help to take a look at this patch? Thanks. Best Regards, Hao Wu > Signed-off-by: Marvin Haeuser <mhaeuser@outlook.de> > --- > MdeModulePkg/Library/FrameBufferBltLib/FrameBufferBltLib.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/MdeModulePkg/Library/FrameBufferBltLib/FrameBufferBltLib.c > b/MdeModulePkg/Library/FrameBufferBltLib/FrameBufferBltLib.c > index 47c5326e9958..a084cc81d32e 100644 > --- a/MdeModulePkg/Library/FrameBufferBltLib/FrameBufferBltLib.c > +++ b/MdeModulePkg/Library/FrameBufferBltLib/FrameBufferBltLib.c > @@ -504,7 +504,7 @@ FrameBufferBltLibBufferToVideo ( > Destination = Configure->FrameBuffer + Offset; > > > > if (Configure->PixelFormat == PixelBlueGreenRedReserved8BitPerColor) { > > - Source = (UINT8 *) BltBuffer + (SrcY * Delta); > > + Source = (UINT8 *) BltBuffer + (SrcY * Delta) + (SourceX * sizeof > (EFI_GRAPHICS_OUTPUT_BLT_PIXEL)); > > } else { > > for (IndexX = 0; IndexX < Width; IndexX++) { > > Blt = > > -- > 2.23.0.windows.1 ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] MdeModulePkg/FrameBufferBltLib: Correctly consider SourceX 2019-09-24 13:01 ` Wu, Hao A @ 2019-09-24 13:14 ` Gao, Zhichao 2019-09-24 13:20 ` Wu, Hao A 0 siblings, 1 reply; 4+ messages in thread From: Gao, Zhichao @ 2019-09-24 13:14 UTC (permalink / raw) To: Wu, Hao A, Marvin Häuser, devel@edk2.groups.io, Ni, Ray; +Cc: Wang, Jian J I have just viewed a same patch of this issue. See https://edk2.groups.io/g/devel/topic/34168097#47297. The two patches are doing the same thing. Thanks, Zhichao > -----Original Message----- > From: Wu, Hao A > Sent: Tuesday, September 24, 2019 9:02 PM > To: Marvin Häuser <Marvin.Haeuser@outlook.com>; devel@edk2.groups.io; > Gao, Zhichao <zhichao.gao@intel.com>; Ni, Ray <ray.ni@intel.com> > Cc: Wang, Jian J <jian.j.wang@intel.com> > Subject: RE: [PATCH] MdeModulePkg/FrameBufferBltLib: Correctly consider > SourceX > > > -----Original Message----- > > From: Marvin Häuser [mailto:Marvin.Haeuser@outlook.com] > > Sent: Tuesday, September 24, 2019 8:46 PM > > To: devel@edk2.groups.io > > Cc: Wang, Jian J; Wu, Hao A > > Subject: [PATCH] MdeModulePkg/FrameBufferBltLib: Correctly consider > > SourceX > > > > From: Marvin Haeuser <mhaeuser@outlook.de> > > > > Currently, SourceX is not considered in the BufferToVideo operation > > when the 8-bit pixel format is used. Correctly add the resulting > > offset to prevent image corruption. > > > > Cc: Jian J Wang <jian.j.wang@intel.com> > > Cc: Hao A Wu <hao.a.wu@intel.com> > > > Hello Marvin, > > In the future, could you help to run the below script: > BaseTools/Scripts/GetMaintainer.py > to get the reviewers for the proposed patch? Thanks in advance. > > Hello Zhichao and Ray, > > Could you help to take a look at this patch? Thanks. > > Best Regards, > Hao Wu > > > > Signed-off-by: Marvin Haeuser <mhaeuser@outlook.de> > > --- > > MdeModulePkg/Library/FrameBufferBltLib/FrameBufferBltLib.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git > > a/MdeModulePkg/Library/FrameBufferBltLib/FrameBufferBltLib.c > > b/MdeModulePkg/Library/FrameBufferBltLib/FrameBufferBltLib.c > > index 47c5326e9958..a084cc81d32e 100644 > > --- a/MdeModulePkg/Library/FrameBufferBltLib/FrameBufferBltLib.c > > +++ b/MdeModulePkg/Library/FrameBufferBltLib/FrameBufferBltLib.c > > @@ -504,7 +504,7 @@ FrameBufferBltLibBufferToVideo ( > > Destination = Configure->FrameBuffer + Offset; > > > > > > > > if (Configure->PixelFormat == > > PixelBlueGreenRedReserved8BitPerColor) { > > > > - Source = (UINT8 *) BltBuffer + (SrcY * Delta); > > > > + Source = (UINT8 *) BltBuffer + (SrcY * Delta) + (SourceX * > > + sizeof > > (EFI_GRAPHICS_OUTPUT_BLT_PIXEL)); > > > > } else { > > > > for (IndexX = 0; IndexX < Width; IndexX++) { > > > > Blt = > > > > -- > > 2.23.0.windows.1 ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] MdeModulePkg/FrameBufferBltLib: Correctly consider SourceX 2019-09-24 13:14 ` Gao, Zhichao @ 2019-09-24 13:20 ` Wu, Hao A 0 siblings, 0 replies; 4+ messages in thread From: Wu, Hao A @ 2019-09-24 13:20 UTC (permalink / raw) To: Gao, Zhichao, Marvin Häuser, devel@edk2.groups.io, Ni, Ray Cc: Wang, Jian J > -----Original Message----- > From: Gao, Zhichao > Sent: Tuesday, September 24, 2019 9:15 PM > To: Wu, Hao A; Marvin Häuser; devel@edk2.groups.io; Ni, Ray > Cc: Wang, Jian J > Subject: RE: [PATCH] MdeModulePkg/FrameBufferBltLib: Correctly consider > SourceX > > I have just viewed a same patch of this issue. See > https://edk2.groups.io/g/devel/topic/34168097#47297. > The two patches are doing the same thing. Yes. The 2 patches look the same to me. Since the above patch has been reviewed and tested, I will push the above one later if there is no other comments. Best Regards, Hao Wu > > Thanks, > Zhichao > > > -----Original Message----- > > From: Wu, Hao A > > Sent: Tuesday, September 24, 2019 9:02 PM > > To: Marvin Häuser <Marvin.Haeuser@outlook.com>; > devel@edk2.groups.io; > > Gao, Zhichao <zhichao.gao@intel.com>; Ni, Ray <ray.ni@intel.com> > > Cc: Wang, Jian J <jian.j.wang@intel.com> > > Subject: RE: [PATCH] MdeModulePkg/FrameBufferBltLib: Correctly > consider > > SourceX > > > > > -----Original Message----- > > > From: Marvin Häuser [mailto:Marvin.Haeuser@outlook.com] > > > Sent: Tuesday, September 24, 2019 8:46 PM > > > To: devel@edk2.groups.io > > > Cc: Wang, Jian J; Wu, Hao A > > > Subject: [PATCH] MdeModulePkg/FrameBufferBltLib: Correctly consider > > > SourceX > > > > > > From: Marvin Haeuser <mhaeuser@outlook.de> > > > > > > Currently, SourceX is not considered in the BufferToVideo operation > > > when the 8-bit pixel format is used. Correctly add the resulting > > > offset to prevent image corruption. > > > > > > Cc: Jian J Wang <jian.j.wang@intel.com> > > > Cc: Hao A Wu <hao.a.wu@intel.com> > > > > > > Hello Marvin, > > > > In the future, could you help to run the below script: > > BaseTools/Scripts/GetMaintainer.py > > to get the reviewers for the proposed patch? Thanks in advance. > > > > Hello Zhichao and Ray, > > > > Could you help to take a look at this patch? Thanks. > > > > Best Regards, > > Hao Wu > > > > > > > Signed-off-by: Marvin Haeuser <mhaeuser@outlook.de> > > > --- > > > MdeModulePkg/Library/FrameBufferBltLib/FrameBufferBltLib.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git > > > a/MdeModulePkg/Library/FrameBufferBltLib/FrameBufferBltLib.c > > > b/MdeModulePkg/Library/FrameBufferBltLib/FrameBufferBltLib.c > > > index 47c5326e9958..a084cc81d32e 100644 > > > --- a/MdeModulePkg/Library/FrameBufferBltLib/FrameBufferBltLib.c > > > +++ b/MdeModulePkg/Library/FrameBufferBltLib/FrameBufferBltLib.c > > > @@ -504,7 +504,7 @@ FrameBufferBltLibBufferToVideo ( > > > Destination = Configure->FrameBuffer + Offset; > > > > > > > > > > > > if (Configure->PixelFormat == > > > PixelBlueGreenRedReserved8BitPerColor) { > > > > > > - Source = (UINT8 *) BltBuffer + (SrcY * Delta); > > > > > > + Source = (UINT8 *) BltBuffer + (SrcY * Delta) + (SourceX * > > > + sizeof > > > (EFI_GRAPHICS_OUTPUT_BLT_PIXEL)); > > > > > > } else { > > > > > > for (IndexX = 0; IndexX < Width; IndexX++) { > > > > > > Blt = > > > > > > -- > > > 2.23.0.windows.1 ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-09-24 13:20 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2019-09-24 12:46 [PATCH] MdeModulePkg/FrameBufferBltLib: Correctly consider SourceX Marvin Häuser 2019-09-24 13:01 ` Wu, Hao A 2019-09-24 13:14 ` Gao, Zhichao 2019-09-24 13:20 ` Wu, Hao A
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox