From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.115, mailfrom: hao.a.wu@intel.com) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by groups.io with SMTP; Tue, 24 Sep 2019 06:20:54 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Sep 2019 06:20:53 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,544,1559545200"; d="scan'208";a="363992641" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga005.jf.intel.com with ESMTP; 24 Sep 2019 06:20:54 -0700 Received: from fmsmsx161.amr.corp.intel.com (10.18.125.9) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 24 Sep 2019 06:20:52 -0700 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by FMSMSX161.amr.corp.intel.com (10.18.125.9) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 24 Sep 2019 06:20:52 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.32]) by shsmsx102.ccr.corp.intel.com ([169.254.2.113]) with mapi id 14.03.0439.000; Tue, 24 Sep 2019 21:20:50 +0800 From: "Wu, Hao A" To: "Gao, Zhichao" , =?iso-8859-1?Q?Marvin_H=E4user?= , "devel@edk2.groups.io" , "Ni, Ray" CC: "Wang, Jian J" Subject: Re: [PATCH] MdeModulePkg/FrameBufferBltLib: Correctly consider SourceX Thread-Topic: [PATCH] MdeModulePkg/FrameBufferBltLib: Correctly consider SourceX Thread-Index: AQHVctYMgCwkp9D70UqlPjNJoZy/TKc6ykZQgAADfiCAAAHHgA== Date: Tue, 24 Sep 2019 13:20:50 +0000 Message-ID: References: <3CE959C139B4C44DBEA1810E3AA6F9000B83D732@SHSMSX101.ccr.corp.intel.com> In-Reply-To: <3CE959C139B4C44DBEA1810E3AA6F9000B83D732@SHSMSX101.ccr.corp.intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: hao.a.wu@intel.com Content-Language: en-US Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: Gao, Zhichao > Sent: Tuesday, September 24, 2019 9:15 PM > To: Wu, Hao A; Marvin H=E4user; devel@edk2.groups.io; Ni, Ray > Cc: Wang, Jian J > Subject: RE: [PATCH] MdeModulePkg/FrameBufferBltLib: Correctly consider > SourceX >=20 > I have just viewed a same patch of this issue. See > https://edk2.groups.io/g/devel/topic/34168097#47297. > The two patches are doing the same thing. Yes. The 2 patches look the same to me. Since the above patch has been reviewed and tested, I will push the above o= ne later if there is no other comments. Best Regards, Hao Wu >=20 > Thanks, > Zhichao >=20 > > -----Original Message----- > > From: Wu, Hao A > > Sent: Tuesday, September 24, 2019 9:02 PM > > To: Marvin H=E4user ; > devel@edk2.groups.io; > > Gao, Zhichao ; Ni, Ray > > Cc: Wang, Jian J > > Subject: RE: [PATCH] MdeModulePkg/FrameBufferBltLib: Correctly > consider > > SourceX > > > > > -----Original Message----- > > > From: Marvin H=E4user [mailto:Marvin.Haeuser@outlook.com] > > > Sent: Tuesday, September 24, 2019 8:46 PM > > > To: devel@edk2.groups.io > > > Cc: Wang, Jian J; Wu, Hao A > > > Subject: [PATCH] MdeModulePkg/FrameBufferBltLib: Correctly consider > > > SourceX > > > > > > From: Marvin Haeuser > > > > > > Currently, SourceX is not considered in the BufferToVideo operation > > > when the 8-bit pixel format is used. Correctly add the resulting > > > offset to prevent image corruption. > > > > > > Cc: Jian J Wang > > > Cc: Hao A Wu > > > > > > Hello Marvin, > > > > In the future, could you help to run the below script: > > BaseTools/Scripts/GetMaintainer.py > > to get the reviewers for the proposed patch? Thanks in advance. > > > > Hello Zhichao and Ray, > > > > Could you help to take a look at this patch? Thanks. > > > > Best Regards, > > Hao Wu > > > > > > > Signed-off-by: Marvin Haeuser > > > --- > > > MdeModulePkg/Library/FrameBufferBltLib/FrameBufferBltLib.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git > > > a/MdeModulePkg/Library/FrameBufferBltLib/FrameBufferBltLib.c > > > b/MdeModulePkg/Library/FrameBufferBltLib/FrameBufferBltLib.c > > > index 47c5326e9958..a084cc81d32e 100644 > > > --- a/MdeModulePkg/Library/FrameBufferBltLib/FrameBufferBltLib.c > > > +++ b/MdeModulePkg/Library/FrameBufferBltLib/FrameBufferBltLib.c > > > @@ -504,7 +504,7 @@ FrameBufferBltLibBufferToVideo ( > > > Destination =3D Configure->FrameBuffer + Offset; > > > > > > > > > > > > if (Configure->PixelFormat =3D=3D > > > PixelBlueGreenRedReserved8BitPerColor) { > > > > > > - Source =3D (UINT8 *) BltBuffer + (SrcY * Delta); > > > > > > + Source =3D (UINT8 *) BltBuffer + (SrcY * Delta) + (SourceX * > > > + sizeof > > > (EFI_GRAPHICS_OUTPUT_BLT_PIXEL)); > > > > > > } else { > > > > > > for (IndexX =3D 0; IndexX < Width; IndexX++) { > > > > > > Blt =3D > > > > > > -- > > > 2.23.0.windows.1