Re: [Patch 5/6] MdeModulePkg: Remove PCD gEfiMdeModulePkgTokenSpaceGuid.PcdTftpBlockSize

["Wu, Hao A" <hao.a.wu@intel.com>]

> -----Original Message-----
> From: Gao, Liming
> Sent: Tuesday, September 17, 2019 10:59 AM
> To: devel@edk2.groups.io
> Cc: Wang, Jian J; Wu, Hao A
> Subject: [Patch 5/6] MdeModulePkg: Remove PCD
> gEfiMdeModulePkgTokenSpaceGuid.PcdTftpBlockSize
> 
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2195
> This PCD has been moved to NetworkPkg.dec file.
> 
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Hao A Wu <hao.a.wu@intel.com>
> Signed-off-by: Liming Gao <liming.gao@intel.com>
> ---
>  MdeModulePkg/MdeModulePkg.dec | 6 ------
>  MdeModulePkg/MdeModulePkg.uni | 6 ------
>  2 files changed, 12 deletions(-)
> 
> diff --git a/MdeModulePkg/MdeModulePkg.dec
> b/MdeModulePkg/MdeModulePkg.dec
> index a680641fe7..856b4b7080 100644
> --- a/MdeModulePkg/MdeModulePkg.dec
> +++ b/MdeModulePkg/MdeModulePkg.dec
> @@ -1177,12 +1177,6 @@
>    # @Expression 0x80000002 |
> (gEfiMdeModulePkgTokenSpaceGuid.PcdSerialFifoControl & 0xD8) == 0
> 
> gEfiMdeModulePkgTokenSpaceGuid.PcdSerialFifoControl|0x07|UINT8|0x00
> 020005
> 
> -  ## This setting can override the default TFTP block size. A value of 0
> computes
> -  # the default from MTU information. A non-zero value will be used as block
> size
> -  # in bytes.
> -  # @Prompt TFTP block size.
> -
> gEfiMdeModulePkgTokenSpaceGuid.PcdTftpBlockSize|0x0|UINT64|0x30001
> 026
> -
>    ## Maximum address that the DXE Core will allocate the
> EFI_SYSTEM_TABLE_POINTER
>    #  structure. The default value for this PCD is 0, which means that the DXE
> Core
>    #  will allocate the buffer from the EFI_SYSTEM_TABLE_POINTER structure
> on a 4MB
> diff --git a/MdeModulePkg/MdeModulePkg.uni
> b/MdeModulePkg/MdeModulePkg.uni
> index b4e8142199..a2c7a7ded3 100644
> --- a/MdeModulePkg/MdeModulePkg.uni
> +++ b/MdeModulePkg/MdeModulePkg.uni
> @@ -204,12 +204,6 @@
>                                                                                        "BIT7..BIT6 - Reserved.  Must be
> 0.<BR>\n"
>                                                                                        "Default is to enable and clear all
> FIFOs.<BR>"
> 
> -#string
> STR_gEfiMdeModulePkgTokenSpaceGuid_PcdTftpBlockSize_PROMPT
> #language en-US "TFTP block size"
> -
> -#string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdTftpBlockSize_HELP
> #language en-US "This setting can override the default TFTP block size. A
> value of 0 computes "
> -                                                                                  "the default from MTU information.
> A non-zero value will be used as block size "
> -                                                                                  "in bytes."
> -


Reviewed-by: Hao A Wu <hao.a.wu@intel.com>

Best Regards,
Hao Wu


>  #string
> STR_gEfiMdeModulePkgTokenSpaceGuid_PcdMaxEfiSystemTablePointerAd
> dress_PROMPT  #language en-US "Maximum Efi System Table Pointer
> address"
> 
>  #string
> STR_gEfiMdeModulePkgTokenSpaceGuid_PcdMaxEfiSystemTablePointerAd
> dress_HELP  #language en-US "Maximum address that the DXE Core will
> allocate the EFI_SYSTEM_TABLE_POINTER structure. The default value for
> this PCD is 0, which means that the DXE Core will allocate the buffer from the
> EFI_SYSTEM_TABLE_POINTER structure on a 4MB boundary as close to the
> top of memory as feasible.  If this PCD is set to a value other than 0, then the
> DXE Core will first attempt to allocate the EFI_SYSTEM_TABLE_POINTER
> structure on a 4MB boundary below the address specified by this PCD, and if
> that allocation fails, retry the allocation on a 4MB boundary as close to the
> top of memory as feasible."
> --
> 2.13.0.windows.1