From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.31, mailfrom: hao.a.wu@intel.com) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by groups.io with SMTP; Thu, 26 Sep 2019 17:35:35 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Sep 2019 17:35:34 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,553,1559545200"; d="scan'208";a="194312471" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga006.jf.intel.com with ESMTP; 26 Sep 2019 17:35:33 -0700 Received: from fmsmsx153.amr.corp.intel.com (10.18.125.6) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 26 Sep 2019 17:35:33 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by FMSMSX153.amr.corp.intel.com (10.18.125.6) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 26 Sep 2019 17:35:33 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.32]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.92]) with mapi id 14.03.0439.000; Fri, 27 Sep 2019 08:35:31 +0800 From: "Wu, Hao A" To: "Gao, Liming" , "devel@edk2.groups.io" CC: "Wang, Jian J" Subject: Re: [Patch 5/6] MdeModulePkg: Remove PCD gEfiMdeModulePkgTokenSpaceGuid.PcdTftpBlockSize Thread-Topic: [Patch 5/6] MdeModulePkg: Remove PCD gEfiMdeModulePkgTokenSpaceGuid.PcdTftpBlockSize Thread-Index: AQHVbQP2UlfLEdjmq0u19k1DRPhehKc+vL7w Date: Fri, 27 Sep 2019 00:35:30 +0000 Message-ID: References: <1568689139-10548-1-git-send-email-liming.gao@intel.com> <1568689139-10548-6-git-send-email-liming.gao@intel.com> In-Reply-To: <1568689139-10548-6-git-send-email-liming.gao@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: hao.a.wu@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: Gao, Liming > Sent: Tuesday, September 17, 2019 10:59 AM > To: devel@edk2.groups.io > Cc: Wang, Jian J; Wu, Hao A > Subject: [Patch 5/6] MdeModulePkg: Remove PCD > gEfiMdeModulePkgTokenSpaceGuid.PcdTftpBlockSize >=20 > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2195 > This PCD has been moved to NetworkPkg.dec file. >=20 > Cc: Jian J Wang > Cc: Hao A Wu > Signed-off-by: Liming Gao > --- > MdeModulePkg/MdeModulePkg.dec | 6 ------ > MdeModulePkg/MdeModulePkg.uni | 6 ------ > 2 files changed, 12 deletions(-) >=20 > diff --git a/MdeModulePkg/MdeModulePkg.dec > b/MdeModulePkg/MdeModulePkg.dec > index a680641fe7..856b4b7080 100644 > --- a/MdeModulePkg/MdeModulePkg.dec > +++ b/MdeModulePkg/MdeModulePkg.dec > @@ -1177,12 +1177,6 @@ > # @Expression 0x80000002 | > (gEfiMdeModulePkgTokenSpaceGuid.PcdSerialFifoControl & 0xD8) =3D=3D 0 >=20 > gEfiMdeModulePkgTokenSpaceGuid.PcdSerialFifoControl|0x07|UINT8|0x00 > 020005 >=20 > - ## This setting can override the default TFTP block size. A value of 0 > computes > - # the default from MTU information. A non-zero value will be used as b= lock > size > - # in bytes. > - # @Prompt TFTP block size. > - > gEfiMdeModulePkgTokenSpaceGuid.PcdTftpBlockSize|0x0|UINT64|0x30001 > 026 > - > ## Maximum address that the DXE Core will allocate the > EFI_SYSTEM_TABLE_POINTER > # structure. The default value for this PCD is 0, which means that th= e DXE > Core > # will allocate the buffer from the EFI_SYSTEM_TABLE_POINTER structur= e > on a 4MB > diff --git a/MdeModulePkg/MdeModulePkg.uni > b/MdeModulePkg/MdeModulePkg.uni > index b4e8142199..a2c7a7ded3 100644 > --- a/MdeModulePkg/MdeModulePkg.uni > +++ b/MdeModulePkg/MdeModulePkg.uni > @@ -204,12 +204,6 @@ > = "BIT7..BIT6 - Reserved. Must be > 0.
\n" > = "Default is to enable and clear all > FIFOs.
" >=20 > -#string > STR_gEfiMdeModulePkgTokenSpaceGuid_PcdTftpBlockSize_PROMPT > #language en-US "TFTP block size" > - > -#string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdTftpBlockSize_HELP > #language en-US "This setting can override the default TFTP block size. A > value of 0 computes " > - = "the default from MTU information. > A non-zero value will be used as block size " > - = "in bytes." > - Reviewed-by: Hao A Wu Best Regards, Hao Wu > #string > STR_gEfiMdeModulePkgTokenSpaceGuid_PcdMaxEfiSystemTablePointerAd > dress_PROMPT #language en-US "Maximum Efi System Table Pointer > address" >=20 > #string > STR_gEfiMdeModulePkgTokenSpaceGuid_PcdMaxEfiSystemTablePointerAd > dress_HELP #language en-US "Maximum address that the DXE Core will > allocate the EFI_SYSTEM_TABLE_POINTER structure. The default value for > this PCD is 0, which means that the DXE Core will allocate the buffer fro= m the > EFI_SYSTEM_TABLE_POINTER structure on a 4MB boundary as close to the > top of memory as feasible. If this PCD is set to a value other than 0, t= hen the > DXE Core will first attempt to allocate the EFI_SYSTEM_TABLE_POINTER > structure on a 4MB boundary below the address specified by this PCD, and = if > that allocation fails, retry the allocation on a 4MB boundary as close to= the > top of memory as feasible." > -- > 2.13.0.windows.1