From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.24, mailfrom: hao.a.wu@intel.com) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by groups.io with SMTP; Sun, 29 Sep 2019 01:46:51 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Sep 2019 01:46:50 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,562,1559545200"; d="scan'208";a="391702680" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga006.fm.intel.com with ESMTP; 29 Sep 2019 01:46:50 -0700 Received: from fmsmsx111.amr.corp.intel.com (10.18.116.5) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 29 Sep 2019 01:46:49 -0700 Received: from shsmsx105.ccr.corp.intel.com (10.239.4.158) by fmsmsx111.amr.corp.intel.com (10.18.116.5) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 29 Sep 2019 01:46:49 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.166]) by SHSMSX105.ccr.corp.intel.com ([169.254.11.96]) with mapi id 14.03.0439.000; Sun, 29 Sep 2019 16:46:47 +0800 From: "Wu, Hao A" To: "Gao, Liming" , "devel@edk2.groups.io" , "Zurcher, Christopher J" CC: "Kinney, Michael D" , "Yao, Jiewen" , "Wang, Jian J" Subject: Re: [edk2-devel] [PATCH v8 0/4] Add SCSI Support for Storage Security Command Protocol Thread-Topic: [edk2-devel] [PATCH v8 0/4] Add SCSI Support for Storage Security Command Protocol Thread-Index: AQHVdNoVRtWJm1wiEU69/BzTbi/jHqc/DLiwgAK3RgCAAJcDEA== Date: Sun, 29 Sep 2019 08:46:46 +0000 Message-ID: References: <20190927022000.36920-1-christopher.j.zurcher@intel.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E50E0BA@SHSMSX104.ccr.corp.intel.com> In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14E50E0BA@SHSMSX104.ccr.corp.intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: hao.a.wu@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: Gao, Liming > Sent: Sunday, September 29, 2019 3:46 PM > To: Wu, Hao A; devel@edk2.groups.io; Zurcher, Christopher J > Cc: Kinney, Michael D; Yao, Jiewen; Wang, Jian J > Subject: RE: [edk2-devel] [PATCH v8 0/4] Add SCSI Support for Storage > Security Command Protocol >=20 > I have no other comments. Reviewed-by: Liming Gao Thanks Liming, The series has been pushed via commits 1f5e4d9128..ac81789c3b. Best Regards, Hao Wu >=20 > >-----Original Message----- > >From: Wu, Hao A > >Sent: Sunday, September 29, 2019 3:31 PM > >To: devel@edk2.groups.io; Zurcher, Christopher J > >; Gao, Liming > >Cc: Kinney, Michael D ; Yao, Jiewen > >; Wang, Jian J > >Subject: RE: [edk2-devel] [PATCH v8 0/4] Add SCSI Support for Storage > >Security Command Protocol > > > >> -----Original Message----- > >> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > >> Zurcher, Christopher J > >> Sent: Friday, September 27, 2019 10:20 AM > >> To: devel@edk2.groups.io > >> Cc: Kinney, Michael D; Yao, Jiewen; Wang, Jian J; Gao, Liming; Wu, Ha= o A > >> Subject: [edk2-devel] [PATCH v8 0/4] Add SCSI Support for Storage > Security > >> Command Protocol > >> > >> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1546 > >> > >> V8 changes: > >> Align Inc512 definition in UefiScsiLib.h with that in UefiScsiLib.c. > >> > >> V7 changes: > >> Changed Inc512 behavior to always take DataLength as bytes, and divid= e > >> by 512 only in the CDB. > >> > >> V6 changes: > >> Restore EFI_SCSI_TYPE defines for ASC IT8 devices. Revert > >EFI_SCSI_IO_TYPE > >> changes in Protocol\ScsiIo.h. Add INC_512 parameter for SecurityProto= col > >> In/Out commands in UefiScsiLib. Change UINT32 args to UINTN to match > the > >> definitions for Storage Security Command Protocol. > >> > >> V5 changes: > >> Split MdeModulePkg changes into separate patches. Add > ReinstallProtocol > >> calls for StorageSecurityCommand Protocol. Restore original > MediaPresent > >> and ReadCapacity behavior, with new implementation for WLUN type > media. > >> Clear temporary aligned buffers before freeing them. > >> > >> V4 changes: > >> Add SSC Protocol in addition to BlockIo instead of in place of BlockI= o. > >> Add error handling for (BlockSize =3D=3D 0) in Read and WriteBlocks > commands > >> to handle partitions that do not support ReadCapacity(). > >> > >> V3 changes: > >> Initialize AlignedBuffer variable in ScsiDiskReceiveData and > >> ScsiDiskSendData functions. Remove redundant input validation and > debug > >> message in ScsiDiskSendData. > >> > >> V2 changes: > >> Split the patch into separate commits for separate packages. > >> > >> To support RPMB access on UFS devices, support must be added to > >> the ScsiDiskDxe driver for the Storage Security Command Protocol. > >> > >> Cc: Michael D Kinney > >> Cc: Jiewen Yao > >> Cc: Jian J Wang > >> Cc: Liming Gao > >> Cc: Hao A Wu > >> > >> Christopher J Zurcher (4): > >> MdePkg: Implement SCSI commands for Security Protocol In/Out > > > > > >For patch 1, > >Reviewed-by: Hao A Wu > > > >Hello Liming, > >Do you have additional comment on the patch? > > > > > >> MdeModulePkg/UfsPassThruDxe: Check for RPMB W-LUN (SecurityLun) > >> MdeModulePkg/ScsiBusDxe: Clean up Peripheral Type check > >> MdeModulePkg/ScsiDiskDxe: Support Storage Security Command > Protocol > > > > > >Since the MdeModulePkg part is the same with V6 series, thus: > >Reviewed-by: Hao A Wu > > > >Best Regards, > >Hao Wu > > > > > >> > >> MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDiskDxe.inf | 3 +- > >> MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.h | 171 +++++- > >> MdePkg/Include/IndustryStandard/Scsi.h | 48 +- > >> MdePkg/Include/Library/UefiScsiLib.h | 130 ++++- > >> MdeModulePkg/Bus/Scsi/ScsiBusDxe/ScsiBus.c | 5 +- > >> MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.c | 616 > >> +++++++++++++++++++- > >> MdeModulePkg/Bus/Ufs/UfsPassThruDxe/UfsPassThru.c | 17 +- > >> MdePkg/Library/UefiScsiLib/UefiScsiLib.c | 229 +++++++- > >> 8 files changed, 1181 insertions(+), 38 deletions(-) > >> > >> -- > >> 2.16.2.windows.1 > >> > >> > >>=20