From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: hao.a.wu@intel.com) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by groups.io with SMTP; Thu, 03 Oct 2019 01:04:20 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Oct 2019 01:04:19 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.67,251,1566889200"; d="scan'208";a="366971194" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga005.jf.intel.com with ESMTP; 03 Oct 2019 01:04:19 -0700 Received: from fmsmsx114.amr.corp.intel.com (10.18.116.8) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 3 Oct 2019 01:04:18 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by FMSMSX114.amr.corp.intel.com (10.18.116.8) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 3 Oct 2019 01:04:17 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.166]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.96]) with mapi id 14.03.0439.000; Thu, 3 Oct 2019 16:04:15 +0800 From: "Wu, Hao A" To: "Kubacki, Michael A" , "devel@edk2.groups.io" CC: "Bi, Dandan" , Ard Biesheuvel , "Dong, Eric" , Laszlo Ersek , "Gao, Liming" , "Kinney, Michael D" , "Ni, Ray" , "Wang, Jian J" , "Yao, Jiewen" Subject: Re: [PATCH V2 5/9] MdeModulePkg/Variable: Add a file for NV variable functions Thread-Topic: [PATCH V2 5/9] MdeModulePkg/Variable: Add a file for NV variable functions Thread-Index: AQHVdZ63uOPHhfGQlU+EzIXsAAqI2KdCPn9A Date: Thu, 3 Oct 2019 08:04:15 +0000 Message-ID: References: <20190928014717.31372-1-michael.a.kubacki@intel.com> <20190928014717.31372-6-michael.a.kubacki@intel.com> In-Reply-To: <20190928014717.31372-6-michael.a.kubacki@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: hao.a.wu@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: Kubacki, Michael A > Sent: Saturday, September 28, 2019 9:47 AM > To: devel@edk2.groups.io > Cc: Bi, Dandan; Ard Biesheuvel; Dong, Eric; Laszlo Ersek; Gao, Liming; Ki= nney, > Michael D; Ni, Ray; Wang, Jian J; Wu, Hao A; Yao, Jiewen > Subject: [PATCH V2 5/9] MdeModulePkg/Variable: Add a file for NV variable > functions >=20 > This change adds a dedicated file for variable operations specific > to non-volatile variables. This decreases the overall length of the > relatively large Variable.c file. It is not clear to me what are the criteria for moving functions into the separate new file. I guess the new file is for functions related with NV variables, but I saw there are functions like: InitRealNonVolatileVariableStore InitEmuNonVolatileVariableStore InitNonVolatileVariableStore Not sure if they can be put into the new file as well. Best Regards, Hao Wu >=20 > Cc: Dandan Bi > Cc: Ard Biesheuvel > Cc: Eric Dong > Cc: Laszlo Ersek > Cc: Liming Gao > Cc: Michael D Kinney > Cc: Ray Ni > Cc: Jian J Wang > Cc: Hao A Wu > Cc: Jiewen Yao > Signed-off-by: Michael Kubacki > --- > MdeModulePkg/Universal/Variable/RuntimeDxe/VariableRuntimeDxe.inf > | 2 ++ > MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmm.inf | 2 > ++ >=20 > MdeModulePkg/Universal/Variable/RuntimeDxe/VariableStandaloneMm.inf > | 2 ++ > MdeModulePkg/Universal/Variable/RuntimeDxe/VariableNonVolatile.h | > 25 +++++++++++++++++ > MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c | 20= +---- > --------- > MdeModulePkg/Universal/Variable/RuntimeDxe/VariableNonVolatile.c | > 28 ++++++++++++++++++++ > 6 files changed, 60 insertions(+), 19 deletions(-) >=20 > diff --git > a/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableRuntimeDxe.inf > b/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableRuntimeDxe.inf > index c35e5fe787..08a5490787 100644 > --- > a/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableRuntimeDxe.inf > +++ > b/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableRuntimeDxe.inf > @@ -36,6 +36,8 @@ > Variable.c > VariableDxe.c > Variable.h > + VariableNonVolatile.c > + VariableNonVolatile.h > VariableParsing.c > VariableParsing.h > PrivilegePolymorphic.h > diff --git > a/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmm.inf > b/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmm.inf > index 626738b9c7..6dc2721b81 100644 > --- a/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmm.inf > +++ b/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmm.inf > @@ -45,6 +45,8 @@ > Variable.c > VariableTraditionalMm.c > VariableSmm.c > + VariableNonVolatile.c > + VariableNonVolatile.h > VariableParsing.c > VariableParsing.h > VarCheck.c > diff --git > a/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableStandaloneMm.i > nf > b/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableStandaloneMm. > inf > index 1ba8f9ebfb..ca9d23ce9f 100644 > --- > a/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableStandaloneMm.i > nf > +++ > b/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableStandaloneMm. > inf > @@ -45,6 +45,8 @@ > Variable.c > VariableSmm.c > VariableStandaloneMm.c > + VariableNonVolatile.c > + VariableNonVolatile.h > VariableParsing.c > VariableParsing.h > VarCheck.c > diff --git > a/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableNonVolatile.h > b/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableNonVolatile.h > new file mode 100644 > index 0000000000..82572262ef > --- /dev/null > +++ > b/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableNonVolatile.h > @@ -0,0 +1,25 @@ > +/** @file > + Common variable non-volatile store routines. > + > +Copyright (c) 2019, Intel Corporation. All rights reserved.
> +SPDX-License-Identifier: BSD-2-Clause-Patent > + > +**/ > + > +#ifndef _VARIABLE_NON_VOLATILE_H_ > +#define _VARIABLE_NON_VOLATILE_H_ > + > +#include "Variable.h" > + > +/** > + Get non-volatile maximum variable size. > + > + @return Non-volatile maximum variable size. > + > +**/ > +UINTN > +GetNonVolatileMaxVariableSize ( > + VOID > + ); > + > +#endif > diff --git a/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c > b/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c > index 53d797152c..5da2354aa5 100644 > --- a/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c > +++ b/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c > @@ -23,6 +23,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent > **/ >=20 > #include "Variable.h" > +#include "VariableNonVolatile.h" > #include "VariableParsing.h" >=20 > VARIABLE_MODULE_GLOBAL *mVariableModuleGlobal; > @@ -3006,25 +3007,6 @@ ReclaimForOS( > } > } >=20 > -/** > - Get non-volatile maximum variable size. > - > - @return Non-volatile maximum variable size. > - > -**/ > -UINTN > -GetNonVolatileMaxVariableSize ( > - VOID > - ) > -{ > - if (PcdGet32 (PcdHwErrStorageSize) !=3D 0) { > - return MAX (MAX (PcdGet32 (PcdMaxVariableSize), PcdGet32 > (PcdMaxAuthVariableSize)), > - PcdGet32 (PcdMaxHardwareErrorVariableSize)); > - } else { > - return MAX (PcdGet32 (PcdMaxVariableSize), PcdGet32 > (PcdMaxAuthVariableSize)); > - } > -} > - > /** > Get maximum variable size, covering both non-volatile and volatile var= iables. >=20 > diff --git > a/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableNonVolatile.c > b/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableNonVolatile.c > new file mode 100644 > index 0000000000..b1b6d8282f > --- /dev/null > +++ > b/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableNonVolatile.c > @@ -0,0 +1,28 @@ > +/** @file > + Common variable non-volatile store routines. > + > +Copyright (c) 2019, Intel Corporation. All rights reserved.
> +SPDX-License-Identifier: BSD-2-Clause-Patent > + > +**/ > + > +#include "VariableNonVolatile.h" > + > +/** > + Get non-volatile maximum variable size. > + > + @return Non-volatile maximum variable size. > + > +**/ > +UINTN > +GetNonVolatileMaxVariableSize ( > + VOID > + ) > +{ > + if (PcdGet32 (PcdHwErrStorageSize) !=3D 0) { > + return MAX (MAX (PcdGet32 (PcdMaxVariableSize), PcdGet32 > (PcdMaxAuthVariableSize)), > + PcdGet32 (PcdMaxHardwareErrorVariableSize)); > + } else { > + return MAX (PcdGet32 (PcdMaxVariableSize), PcdGet32 > (PcdMaxAuthVariableSize)); > + } > +} > -- > 2.16.2.windows.1