From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mga18.intel.com (mga18.intel.com [134.134.136.126])
 by mx.groups.io with SMTP id smtpd.web12.1093.1571191866502430905
 for <devel@edk2.groups.io>;
 Tue, 15 Oct 2019 19:11:06 -0700
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.126, mailfrom: hao.a.wu@intel.com)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from orsmga008.jf.intel.com ([10.7.209.65])
  by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Oct 2019 19:11:06 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.67,302,1566889200"; 
   d="scan'208";a="189539450"
Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201])
  by orsmga008.jf.intel.com with ESMTP; 15 Oct 2019 19:11:05 -0700
Received: from fmsmsx158.amr.corp.intel.com (10.18.116.75) by
 FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS)
 id 14.3.439.0; Tue, 15 Oct 2019 19:11:05 -0700
Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by
 fmsmsx158.amr.corp.intel.com (10.18.116.75) with Microsoft SMTP Server (TLS)
 id 14.3.439.0; Tue, 15 Oct 2019 19:11:05 -0700
Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.166]) by
 shsmsx102.ccr.corp.intel.com ([169.254.2.176]) with mapi id 14.03.0439.000;
 Wed, 16 Oct 2019 10:11:03 +0800
From: "Wu, Hao A" <hao.a.wu@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>, "ashishsingha@nvidia.com"
	<ashishsingha@nvidia.com>, "Ni, Ray" <ray.ni@intel.com>, "jbrasen@nvidia.com"
	<jbrasen@nvidia.com>
Subject: Re: [edk2-devel] [PATCH v4 1/2] MdeModulePkg/XhciDxe: Fix Aligned Page Allocation
Thread-Topic: [edk2-devel] [PATCH v4 1/2] MdeModulePkg/XhciDxe: Fix Aligned
 Page Allocation
Thread-Index: AQHVg3zoV+AWUi8n0kGxEAx8nLDA9Kdchtzg
Date: Wed, 16 Oct 2019 02:11:03 +0000
Message-ID: <B80AF82E9BFB8E4FBD8C89DA810C6A093C947D6C@SHSMSX104.ccr.corp.intel.com>
References: <cover.1571159369.git.ashishsingha@nvidia.com>
 <bd4353a24d6d073b02834284365e384da1a7a3ff.1571159369.git.ashishsingha@nvidia.com>
In-Reply-To: <bd4353a24d6d073b02834284365e384da1a7a3ff.1571159369.git.ashishsingha@nvidia.com>
Accept-Language: zh-CN, en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.239.127.40]
MIME-Version: 1.0
Return-Path: hao.a.wu@intel.com
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Ashish Singhal
> Sent: Wednesday, October 16, 2019 1:21 AM
> To: devel@edk2.groups.io; Wu, Hao A; Ni, Ray; jbrasen@nvidia.com
> Cc: Ashish Singhal
> Subject: [edk2-devel] [PATCH v4 1/2] MdeModulePkg/XhciDxe: Fix Aligned
> Page Allocation
>=20
> While allocating pages aligned at an alignment higher than
> 4K, allocate memory taking into consideration the padding
> required for that alignment. The calls to free pages takes
> care of this already.
>=20
> Signed-off-by: Ashish Singhal <ashishsingha@nvidia.com>
> ---
>  MdeModulePkg/Bus/Pci/XhciDxe/UsbHcMem.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/MdeModulePkg/Bus/Pci/XhciDxe/UsbHcMem.c
> b/MdeModulePkg/Bus/Pci/XhciDxe/UsbHcMem.c
> index fd79988..aa69c47 100644
> --- a/MdeModulePkg/Bus/Pci/XhciDxe/UsbHcMem.c
> +++ b/MdeModulePkg/Bus/Pci/XhciDxe/UsbHcMem.c
> @@ -656,7 +656,7 @@ UsbHcAllocateAlignedPages (
>                        PciIo,
>                        AllocateAnyPages,
>                        EfiBootServicesData,
> -                      Pages,
> +                      RealPages,
>                        &Memory,
>                        0
>                        );


Reviewed-by: Hao A Wu <hao.a.wu@intel.com>

Best Regards,
Hao Wu


> --
> 2.7.4
>=20
>=20
>=20