From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mx.groups.io with SMTP id smtpd.web09.1014.1572417966900932011 for ; Tue, 29 Oct 2019 23:46:06 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: hao.a.wu@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Oct 2019 23:46:06 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,246,1569308400"; d="scan'208";a="203795168" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga006.jf.intel.com with ESMTP; 29 Oct 2019 23:46:06 -0700 Received: from shsmsx153.ccr.corp.intel.com (10.239.6.53) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 29 Oct 2019 23:46:05 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.127]) by SHSMSX153.ccr.corp.intel.com ([169.254.12.215]) with mapi id 14.03.0439.000; Wed, 30 Oct 2019 14:46:00 +0800 From: "Wu, Hao A" To: "Zhang, Shenglei" , "devel@edk2.groups.io" CC: "Ni, Ray" Subject: Re: [PATCH 1/3] MdeModulePkg/EhciPei: Initialize the variable Map Thread-Topic: [PATCH 1/3] MdeModulePkg/EhciPei: Initialize the variable Map Thread-Index: AQHVg8OZLN+xO9u/nkeslgcfu5R4lady0f/g Date: Wed, 30 Oct 2019 06:46:00 +0000 Message-ID: References: <20191016014648.4952-1-shenglei.zhang@intel.com> <20191016014648.4952-2-shenglei.zhang@intel.com> In-Reply-To: <20191016014648.4952-2-shenglei.zhang@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: hao.a.wu@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: Zhang, Shenglei > Sent: Wednesday, October 16, 2019 9:47 AM > To: devel@edk2.groups.io > Cc: Wu, Hao A; Ni, Ray > Subject: [PATCH 1/3] MdeModulePkg/EhciPei: Initialize the variable Map >=20 > Map is used but not Initialized. >=20 > Cc: Hao A Wu > Cc: Ray Ni > Signed-off-by: Shenglei Zhang > --- > MdeModulePkg/Bus/Pci/EhciPei/EhciUrb.c | 2 ++ > 1 file changed, 2 insertions(+) >=20 > diff --git a/MdeModulePkg/Bus/Pci/EhciPei/EhciUrb.c > b/MdeModulePkg/Bus/Pci/EhciPei/EhciUrb.c > index 7c6a6a5f9716..995ccd2463d2 100644 > --- a/MdeModulePkg/Bus/Pci/EhciPei/EhciUrb.c > +++ b/MdeModulePkg/Bus/Pci/EhciPei/EhciUrb.c > @@ -534,6 +534,8 @@ EhcCreateUrb ( > PEI_URB *Urb; > VOID *Map; >=20 > + Map =3D NULL; > + Hello, Is this a real issue or just a false positive report by some compiler or st= atic analyzer? If is a real issue, could you help to describe the issue in more detail? If= it is a false positive report, could you help to add some comments together wi= th the change? Thanks in advance. Best Regards, Hao Wu > Urb =3D Ehc->Urb; > Urb->Signature =3D EHC_URB_SIG; > InitializeListHead (&Urb->UrbList); > -- > 2.18.0.windows.1