From: "Wu, Hao A" <hao.a.wu@intel.com>
To: "Zhang, Shenglei" <shenglei.zhang@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Ni, Ray" <ray.ni@intel.com>
Subject: Re: [PATCH 2/3] MdeModulePkg/UhciPei: Initialize the variable RequestMap
Date: Wed, 30 Oct 2019 06:46:01 +0000 [thread overview]
Message-ID: <B80AF82E9BFB8E4FBD8C89DA810C6A093C9556DA@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <20191016014648.4952-3-shenglei.zhang@intel.com>
> -----Original Message-----
> From: Zhang, Shenglei
> Sent: Wednesday, October 16, 2019 9:47 AM
> To: devel@edk2.groups.io
> Cc: Wu, Hao A; Ni, Ray
> Subject: [PATCH 2/3] MdeModulePkg/UhciPei: Initialize the variable
> RequestMap
>
> RequestMap is used but not Initialized.
>
> Cc: Hao A Wu <hao.a.wu@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> ---
> MdeModulePkg/Bus/Pci/UhciPei/UhcPeim.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/MdeModulePkg/Bus/Pci/UhciPei/UhcPeim.c
> b/MdeModulePkg/Bus/Pci/UhciPei/UhcPeim.c
> index b897c3f82ce6..a05834da3c4a 100644
> --- a/MdeModulePkg/Bus/Pci/UhciPei/UhcPeim.c
> +++ b/MdeModulePkg/Bus/Pci/UhciPei/UhcPeim.c
> @@ -274,6 +274,8 @@ UhcControlTransfer (
>
> PktID = INPUT_PACKET_ID;
>
> + RequestMap = NULL;
Hello,
Is this a real issue or just a false positive report by some compiler or static
analyzer?
If is a real issue, could you help to describe the issue in more detail? If it
is a false positive report, could you help to add some comments together with
the change? Thanks in advance.
Best Regards,
Hao Wu
> +
> if (Request == NULL || TransferResult == NULL) {
> return EFI_INVALID_PARAMETER;
> }
> --
> 2.18.0.windows.1
next prev parent reply other threads:[~2019-10-30 6:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-16 1:46 [PATCH 0/3] MdeModulePkg: Initialize variables Zhang, Shenglei
2019-10-16 1:46 ` [PATCH 1/3] MdeModulePkg/EhciPei: Initialize the variable Map Zhang, Shenglei
2019-10-30 6:46 ` Wu, Hao A
2019-10-16 1:46 ` [PATCH 2/3] MdeModulePkg/UhciPei: Initialize the variable RequestMap Zhang, Shenglei
2019-10-30 6:46 ` Wu, Hao A [this message]
2019-10-16 1:46 ` [PATCH 3/3] MdeModulePkg/Mem: Initialize the variable MapMemory Zhang, Shenglei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B80AF82E9BFB8E4FBD8C89DA810C6A093C9556DA@SHSMSX104.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox