From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mx.groups.io with SMTP id smtpd.web10.1001.1572417964862487793 for ; Tue, 29 Oct 2019 23:46:04 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: hao.a.wu@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Oct 2019 23:46:04 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,246,1569308400"; d="scan'208";a="212004568" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga002.jf.intel.com with ESMTP; 29 Oct 2019 23:46:04 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 29 Oct 2019 23:46:03 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.127]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.149]) with mapi id 14.03.0439.000; Wed, 30 Oct 2019 14:46:01 +0800 From: "Wu, Hao A" To: "Zhang, Shenglei" , "devel@edk2.groups.io" CC: "Ni, Ray" Subject: Re: [PATCH 2/3] MdeModulePkg/UhciPei: Initialize the variable RequestMap Thread-Topic: [PATCH 2/3] MdeModulePkg/UhciPei: Initialize the variable RequestMap Thread-Index: AQHVg8OaxXB9axn9fEOri+J/hsooaady08jw Date: Wed, 30 Oct 2019 06:46:01 +0000 Message-ID: References: <20191016014648.4952-1-shenglei.zhang@intel.com> <20191016014648.4952-3-shenglei.zhang@intel.com> In-Reply-To: <20191016014648.4952-3-shenglei.zhang@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: hao.a.wu@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: Zhang, Shenglei > Sent: Wednesday, October 16, 2019 9:47 AM > To: devel@edk2.groups.io > Cc: Wu, Hao A; Ni, Ray > Subject: [PATCH 2/3] MdeModulePkg/UhciPei: Initialize the variable > RequestMap >=20 > RequestMap is used but not Initialized. >=20 > Cc: Hao A Wu > Cc: Ray Ni > Signed-off-by: Shenglei Zhang > --- > MdeModulePkg/Bus/Pci/UhciPei/UhcPeim.c | 2 ++ > 1 file changed, 2 insertions(+) >=20 > diff --git a/MdeModulePkg/Bus/Pci/UhciPei/UhcPeim.c > b/MdeModulePkg/Bus/Pci/UhciPei/UhcPeim.c > index b897c3f82ce6..a05834da3c4a 100644 > --- a/MdeModulePkg/Bus/Pci/UhciPei/UhcPeim.c > +++ b/MdeModulePkg/Bus/Pci/UhciPei/UhcPeim.c > @@ -274,6 +274,8 @@ UhcControlTransfer ( >=20 > PktID =3D INPUT_PACKET_ID; >=20 > + RequestMap =3D NULL; Hello, Is this a real issue or just a false positive report by some compiler or st= atic analyzer? If is a real issue, could you help to describe the issue in more detail? If= it is a false positive report, could you help to add some comments together wi= th the change? Thanks in advance. Best Regards, Hao Wu > + > if (Request =3D=3D NULL || TransferResult =3D=3D NULL) { > return EFI_INVALID_PARAMETER; > } > -- > 2.18.0.windows.1