Re: [PATCH 3/4] MdeModulePkg/EsrtDxe: Add check for EsrtRepository

["Wu, Hao A" <hao.a.wu@intel.com>]

> -----Original Message-----
> From: Zhang, Shenglei
> Sent: Thursday, October 17, 2019 11:31 AM
> To: devel@edk2.groups.io
> Cc: Wu, Hao A; Gao, Liming
> Subject: [PATCH 3/4] MdeModulePkg/EsrtDxe: Add check for EsrtRepository
> 
> EsrtRepository might be NULL. So return EFI_OUT_OF_RESOURCES
> when it is NULL.
> 
> Cc: Hao A Wu <hao.a.wu@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> ---
>  MdeModulePkg/Universal/EsrtDxe/EsrtImpl.c | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/MdeModulePkg/Universal/EsrtDxe/EsrtImpl.c
> b/MdeModulePkg/Universal/EsrtDxe/EsrtImpl.c
> index f48125382dbc..fff17b98fa3d 100644
> --- a/MdeModulePkg/Universal/EsrtDxe/EsrtImpl.c
> +++ b/MdeModulePkg/Universal/EsrtDxe/EsrtImpl.c
> @@ -239,6 +239,11 @@ DeleteEsrtEntry(
>      goto EXIT;
>    }
> 
> +  if (EsrtRepository == NULL) {
> +    Status = EFI_OUT_OF_RESOURCES;
> +    goto EXIT;
> +  }
> +
>    if ((RepositorySize % sizeof(EFI_SYSTEM_RESOURCE_ENTRY)) != 0) {
>      DEBUG((EFI_D_ERROR, "Repository Corrupt. Need to rebuild Repository.\n"));
>      //
> @@ -332,6 +337,11 @@ UpdateEsrtEntry(
>               &RepositorySize
>               );
> 
> +  if (EsrtRepository == NULL) {
> +    Status = EFI_OUT_OF_RESOURCES;
> +    goto EXIT;
> +  }
> +


Reviewed-by: Hao A Wu <hao.a.wu@intel.com>

Best Regards,
Hao Wu


>    if (!EFI_ERROR(Status)) {
>      //
>      // if exist, update Esrt cache repository
> --
> 2.18.0.windows.1