From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mx.groups.io with SMTP id smtpd.web10.2565.1573095808879292209 for ; Wed, 06 Nov 2019 19:03:29 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.20, mailfrom: hao.a.wu@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Nov 2019 19:03:28 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,276,1569308400"; d="scan'208";a="403951852" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga006.fm.intel.com with ESMTP; 06 Nov 2019 19:03:27 -0800 Received: from fmsmsx120.amr.corp.intel.com (10.18.124.208) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 6 Nov 2019 19:03:27 -0800 Received: from shsmsx105.ccr.corp.intel.com (10.239.4.158) by fmsmsx120.amr.corp.intel.com (10.18.124.208) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 6 Nov 2019 19:03:27 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.127]) by SHSMSX105.ccr.corp.intel.com ([169.254.11.225]) with mapi id 14.03.0439.000; Thu, 7 Nov 2019 11:03:25 +0800 From: "Wu, Hao A" To: "Kinney, Michael D" , "devel@edk2.groups.io" CC: "Wang, Jian J" Subject: Re: [Patch v4 11/22] MdeModulePkg: Add YAML file for CI builds Thread-Topic: [Patch v4 11/22] MdeModulePkg: Add YAML file for CI builds Thread-Index: AQHVlQijHzK2AQtdTUC2gvIKeCdFV6d/BNFw Date: Thu, 7 Nov 2019 03:03:24 +0000 Message-ID: References: <20191107011349.16524-1-michael.d.kinney@intel.com> <20191107011349.16524-12-michael.d.kinney@intel.com> In-Reply-To: <20191107011349.16524-12-michael.d.kinney@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: hao.a.wu@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: Kinney, Michael D > Sent: Thursday, November 07, 2019 9:14 AM > To: devel@edk2.groups.io > Cc: Wang, Jian J; Wu, Hao A > Subject: [Patch v4 11/22] MdeModulePkg: Add YAML file for CI builds >=20 > Add YAML file to the package directory with the > configuration of the checks to perform during a > CI build. >=20 > Cc: Jian J Wang > Cc: Hao A Wu > Signed-off-by: Michael D Kinney > --- > MdeModulePkg/MdeModulePkg.ci.yaml | 81 > +++++++++++++++++++++++++++++++ > 1 file changed, 81 insertions(+) > create mode 100644 MdeModulePkg/MdeModulePkg.ci.yaml >=20 > diff --git a/MdeModulePkg/MdeModulePkg.ci.yaml > b/MdeModulePkg/MdeModulePkg.ci.yaml > new file mode 100644 > index 0000000000..6ae58d5379 > --- /dev/null > +++ b/MdeModulePkg/MdeModulePkg.ci.yaml > @@ -0,0 +1,81 @@ > +## > +# CI configuration for MdeModulePkg > +# > +# Copyright (c) Microsoft Corporation > +# SPDX-License-Identifier: BSD-2-Clause-Patent > +## > +{ > + ## options defined ci/Plugin/CompilerPlugin > + "CompilerPlugin": { > + "DscPath": "MdeModulePkg.dsc" > + }, > + > + ## options defined ci/Plugin/CharEncodingCheck > + "CharEncodingCheck": { > + "IgnoreFiles": [] > + }, > + > + ## options defined ci/Plugin/DependencyCheck > + "DependencyCheck": { > + "AcceptableDependencies": [ > + "MdePkg/MdePkg.dec", > + "MdeModulePkg/MdeModulePkg.dec", > + "StandaloneMmPkg/StandaloneMmPkg.dec", > + "ArmPkg/ArmPkg.dec" # this should be fixed by promoting an > abstraction > + ], > + # For host based unit tests > + "AcceptableDependencies-HOST_APPLICATION":[], > + # For UEFI shell based apps > + "AcceptableDependencies-UEFI_APPLICATION":[], > + "IgnoreInf": [] > + }, > + > + ## options defined ci/Plugin/DscCompleteCheck > + "DscCompleteCheck": { > + "IgnoreInf": [], > + "DscPath": "MdeModulePkg.dsc" > + }, > + > + ## options defined ci/Plugin/GuidCheck > + "GuidCheck": { > + "IgnoreGuidName": [], > + "IgnoreGuidValue": ["00000000-0000-0000-0000-000000000000"], > + "IgnoreFoldersAndFiles": [], > + "IgnoreDuplicates": [ > + > "gEdkiiFormBrowserExProtocolGuid=3DgEfiFormBrowserExProtocolGuid", > + "gEfiPeiMmAccessPpiGuid=3DgPeiSmmAccessPpiGuid", > + "gPeiSmmControlPpiGuid=3DgEfiPeiMmControlPpiGuid", > + "gEdkiiSerialPortLibVendorGuid=3DSerialDxe" # Is this a bug= ???? Hello Mike, I think the above GUID duplication (serial-related) has already been addres= sed via commits: SHA-1: 0d85e67714e31e0dbe4241ab2ebb7c423aba174d * MdeModulePkg/SerialDxe: Update the file Guid in SerialDxe.inf SHA-1: 9790f62be1aa5ee9460d4c4ec8c720919523bb62 * MdeModulePkg SerialDxe.inf: Fix wrong FILE_GUID format Could you help to confirm whether the item can be removed? With it handled, Reviewed-by: Hao A Wu Best Regards, Hao Wu > + ] > + }, > + > + ## options defined ci/Plugin/LibraryClassCheck > + "LibraryClassCheck": { > + "IgnoreHeaderFile": [] > + }, > + > + ## options defined ci/Plugin/SpellCheck > + "SpellCheck": { > + "AuditOnly": True, # Fails test but run in AuditOnly m= ode to collect > log > + "IgnoreStandardPaths": [ # Standard Plugin defined paths tha= t should > be ignore > + "*.c", "*.asm", "*.h", "*.nasm", "*.s", "*.asl", "*.inf" > + ], > + "IgnoreFiles": [ # use gitignore syntax to ignore er= rors in matching > files > + "Library/LzmaCustomDecompressLib/Sdk/DOC/*" > + ], > + "ExtendWords": [ # words to extend to the dictionary f= or this > package > + "LIGHTGRAY", > + "DARKGRAY", > + "LIGHTBLUE", > + "LIGHTGREEN", > + "LIGHTCYAN", > + "LIGHTRED", > + "LIGHTMAGENTA", > + "FVMAIN", > + "VARCHECKPCD", > + "Getxx", > + "lzturbo" > + ], > + "AdditionalIncludePaths": [] # Additional paths to spell check r= elative to > package root (wildcards supported) > + } > +} > -- > 2.21.0.windows.1