From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mx.groups.io with SMTP id smtpd.web10.901.1577155963406581634 for ; Mon, 23 Dec 2019 18:52:43 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: hao.a.wu@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Dec 2019 18:52:42 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,350,1571727600"; d="scan'208";a="229512808" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga002.jf.intel.com with ESMTP; 23 Dec 2019 18:52:41 -0800 Received: from FMSMSX110.amr.corp.intel.com (10.18.116.10) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 23 Dec 2019 18:51:54 -0800 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx110.amr.corp.intel.com (10.18.116.10) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 23 Dec 2019 18:51:53 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.90]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.222]) with mapi id 14.03.0439.000; Tue, 24 Dec 2019 10:51:51 +0800 From: "Wu, Hao A" To: "Albecki, Mateusz" , "devel@edk2.groups.io" CC: Marcin Wojtas , "Gao, Zhichao" , "Gao, Liming" , Ard Biesheuvel Subject: Re: [PATCH 0/2] MdeModulePkg/SdMmcPciHcDxe: Send the EdkiiSdMmcSwitchClockFreq notification before sending CMD13 Thread-Topic: [PATCH 0/2] MdeModulePkg/SdMmcPciHcDxe: Send the EdkiiSdMmcSwitchClockFreq notification before sending CMD13 Thread-Index: AQHVt1jSFQaLG6sTP0y0t4sSQqhwzqfIkjHA Date: Tue, 24 Dec 2019 02:51:51 +0000 Message-ID: References: <20191220171312.3120-1-mateusz.albecki@intel.com> In-Reply-To: <20191220171312.3120-1-mateusz.albecki@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: hao.a.wu@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: Albecki, Mateusz > Sent: Saturday, December 21, 2019 1:13 AM > To: devel@edk2.groups.io > Cc: Albecki, Mateusz; Wu, Hao A; Marcin Wojtas; Gao, Zhichao; Gao, Liming > Subject: [PATCH 0/2] MdeModulePkg/SdMmcPciHcDxe: Send the > EdkiiSdMmcSwitchClockFreq notification before sending CMD13 >=20 > The first patch refactors the SdMmcClockSupply function with a goal > of sending the EdkiiSdMmcSwitchClockFreq notification before we send the > CMD13 to check the switch status in eMMC init flow. This is required to > avoid sending the CMD13 on link that still has not been fixed by platform= . >=20 > To avoid changing the driver behavior we avoid sending notifications > when the clock is setup for the first time or when we setup the clock > after the voltage switch procedure(adressed in second patch). >=20 > The second patch in the series optimizes the SD card detection routine > to stop it from going through the process of internal clock setup > after switching the voltage. According to SD HC specification there > is no need to setup internal clock all over again. >=20 > Tests performed: > - Booted eMMC in HS400 mode on platform which required post clock freq > fixes >=20 > I wasn't able to test SD card yet due to the lack of setup with working S= D. I performed a quick verification on the eMMC device and SD card on my side. They work properly after the series. So for the series, Tested-by: Hao A Wu >=20 > The patch series is available on github here: > https://github.com/malbecki/edk2/tree/sdmmc_post_freq_notify Add Ard to the loop to see if there is additional comment. Best Regards, Hao Wu >=20 > Cc: Hao A Wu > Cc: Marcin Wojtas > Cc: Zhichao Gao > Cc: Liming Gao >=20 > Mateusz Albecki (2): > SdMmcPciHcDxe: Send EdkiiSdMmcSwitchClockFreq after SD clock start > MdeModulePkg/SdMmcPciHcDxe: Add function to start SD clock >=20 > MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/EmmcDevice.c | 20 +-- > MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdDevice.c | 25 +--- > MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.h | 24 ++++ > MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c | 136 > +++++++++++---------- > MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.h | 45 ++----- > 5 files changed, 112 insertions(+), 138 deletions(-) >=20 > -- > 2.14.1.windows.1