From: "Wu, Hao A" <hao.a.wu@intel.com>
To: "Ni, Ray" <ray.ni@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Dong, Eric" <eric.dong@intel.com>,
Laszlo Ersek <lersek@redhat.com>,
"Zeng, Star" <star.zeng@intel.com>,
"Fu, Siyuan" <siyuan.fu@intel.com>,
"Kinney, Michael D" <michael.d.kinney@intel.com>
Subject: Re: [PATCH v1 3/4] UefiCpuPkg: Add definitions for EDKII microcode patch HOB
Date: Tue, 24 Dec 2019 05:48:47 +0000 [thread overview]
Message-ID: <B80AF82E9BFB8E4FBD8C89DA810C6A093C974CC6@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <734D49CCEBEEF84792F5B80ED585239D5C3A9E97@SHSMSX104.ccr.corp.intel.com>
Agree with both 1 & 2. Will update patch to address them.
Best Regards,
Hao Wu
> -----Original Message-----
> From: Ni, Ray
> Sent: Tuesday, December 24, 2019 11:48 AM
> To: Wu, Hao A; devel@edk2.groups.io
> Cc: Dong, Eric; Laszlo Ersek; Zeng, Star; Fu, Siyuan; Kinney, Michael D
> Subject: RE: [PATCH v1 3/4] UefiCpuPkg: Add definitions for EDKII microcode
> patch HOB
>
> > + //
> > + // The number of processors within the system.
> > + //
> > + UINT32 ProcessorNumber;
> 1. Number is a bit confusing here. I also provided comments to other patches.
> We could "ProcessorCount" here.
> Number can be either count of items, or an index to a specific item.
>
>
> > + //
> > + // An array with 'ProcessorNumber' elements that stores the offset (with
> > + // regard to 'MicrocodePatchAddress') of the applied microcode patch for
> > each
> > + // processor.
> > + // If no microcode patch is applied for certain processor, the relating
> > + // element will be set to MAX_UINT64.
> > + //
> > + UINT64 DetectedPatchOffset[0];
>
> 2. "ProcessorSpecificPatchOffset"?
next prev parent reply other threads:[~2019-12-24 5:48 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-24 1:36 [PATCH v1 0/4] Microcode related optimizations Wu, Hao A
2019-12-24 1:36 ` [PATCH v1 1/4] UefiCpuPkg/MpInitLib: Collect processors' CPUID & Platform ID info Wu, Hao A
2019-12-24 2:51 ` Ni, Ray
2019-12-24 1:36 ` [PATCH v1 2/4] UefiCpuPkg/MpInitLib: Reduce the size when loading microcode patches Wu, Hao A
2019-12-24 3:32 ` Ni, Ray
2019-12-24 5:48 ` Wu, Hao A
2019-12-24 1:36 ` [PATCH v1 3/4] UefiCpuPkg: Add definitions for EDKII microcode patch HOB Wu, Hao A
2019-12-24 3:48 ` Ni, Ray
2019-12-24 5:48 ` Wu, Hao A [this message]
2019-12-24 8:15 ` Ni, Ray
2019-12-25 5:42 ` Wu, Hao A
2019-12-24 1:36 ` [PATCH v1 4/4] UefiCpuPkg/MpInitLib: Produce " Wu, Hao A
2019-12-24 3:54 ` Ni, Ray
2019-12-25 5:42 ` Wu, Hao A
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B80AF82E9BFB8E4FBD8C89DA810C6A093C974CC6@SHSMSX104.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox