From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mga02.intel.com (mga02.intel.com [])
 by mx.groups.io with SMTP id smtpd.web10.104.1577166528940084526
 for <devel@edk2.groups.io>;
 Mon, 23 Dec 2019 21:48:50 -0800
Authentication-Results: mx.groups.io;
 dkim=missing; spf=fail (domain: intel.com, ip: <nil>, mailfrom: hao.a.wu@intel.com)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga002.fm.intel.com ([10.253.24.26])
  by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Dec 2019 21:48:50 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.69,350,1571727600"; 
   d="scan'208";a="249717996"
Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202])
  by fmsmga002.fm.intel.com with ESMTP; 23 Dec 2019 21:48:50 -0800
Received: from fmsmsx124.amr.corp.intel.com (10.18.125.39) by
 fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS)
 id 14.3.439.0; Mon, 23 Dec 2019 21:48:50 -0800
Received: from shsmsx107.ccr.corp.intel.com (10.239.4.96) by
 fmsmsx124.amr.corp.intel.com (10.18.125.39) with Microsoft SMTP Server (TLS)
 id 14.3.439.0; Mon, 23 Dec 2019 21:48:50 -0800
Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.90]) by
 SHSMSX107.ccr.corp.intel.com ([169.254.9.164]) with mapi id 14.03.0439.000;
 Tue, 24 Dec 2019 13:48:48 +0800
From: "Wu, Hao A" <hao.a.wu@intel.com>
To: "Ni, Ray" <ray.ni@intel.com>, "devel@edk2.groups.io"
	<devel@edk2.groups.io>
CC: "Dong, Eric" <eric.dong@intel.com>, Laszlo Ersek <lersek@redhat.com>,
	"Zeng, Star" <star.zeng@intel.com>, "Fu, Siyuan" <siyuan.fu@intel.com>,
	"Kinney, Michael D" <michael.d.kinney@intel.com>
Subject: Re: [PATCH v1 3/4] UefiCpuPkg: Add definitions for EDKII microcode patch HOB
Thread-Topic: [PATCH v1 3/4] UefiCpuPkg: Add definitions for EDKII microcode
 patch HOB
Thread-Index: AQHVufqnSYtLiUzUBEOBQyf63eNbx6fIH+oAgACnl4A=
Date: Tue, 24 Dec 2019 05:48:47 +0000
Message-ID: <B80AF82E9BFB8E4FBD8C89DA810C6A093C974CC6@SHSMSX104.ccr.corp.intel.com>
References: <20191224013656.13404-1-hao.a.wu@intel.com>
 <20191224013656.13404-4-hao.a.wu@intel.com>
 <734D49CCEBEEF84792F5B80ED585239D5C3A9E97@SHSMSX104.ccr.corp.intel.com>
In-Reply-To: <734D49CCEBEEF84792F5B80ED585239D5C3A9E97@SHSMSX104.ccr.corp.intel.com>
Accept-Language: zh-CN, en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.239.127.40]
MIME-Version: 1.0
Return-Path: hao.a.wu@intel.com
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

Agree with both 1 & 2. Will update patch to address them.

Best Regards,
Hao Wu


> -----Original Message-----
> From: Ni, Ray
> Sent: Tuesday, December 24, 2019 11:48 AM
> To: Wu, Hao A; devel@edk2.groups.io
> Cc: Dong, Eric; Laszlo Ersek; Zeng, Star; Fu, Siyuan; Kinney, Michael D
> Subject: RE: [PATCH v1 3/4] UefiCpuPkg: Add definitions for EDKII microco=
de
> patch HOB
>=20
> > +  //
> > +  // The number of processors within the system.
> > +  //
> > +  UINT32    ProcessorNumber;
> 1. Number is a bit confusing here. I also provided comments to other patc=
hes.
> We could "ProcessorCount" here.
> Number can be either count of items, or an index to a specific item.
>=20
>=20
> > +  //
> > +  // An array with 'ProcessorNumber' elements that stores the offset (=
with
> > +  // regard to 'MicrocodePatchAddress') of the applied microcode patch=
 for
> > each
> > +  // processor.
> > +  // If no microcode patch is applied for certain processor, the relat=
ing
> > +  // element will be set to MAX_UINT64.
> > +  //
> > +  UINT64    DetectedPatchOffset[0];
>=20
> 2. "ProcessorSpecificPatchOffset"?