From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mx.groups.io with SMTP id smtpd.web11.7507.1577934744666069168 for ; Wed, 01 Jan 2020 19:12:24 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: hao.a.wu@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Jan 2020 19:12:22 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,385,1571727600"; d="scan'208";a="221262411" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga006.jf.intel.com with ESMTP; 01 Jan 2020 19:12:22 -0800 Received: from fmsmsx154.amr.corp.intel.com (10.18.116.70) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 1 Jan 2020 19:12:21 -0800 Received: from shsmsx105.ccr.corp.intel.com (10.239.4.158) by FMSMSX154.amr.corp.intel.com (10.18.116.70) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 1 Jan 2020 19:12:21 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.197]) by SHSMSX105.ccr.corp.intel.com ([169.254.11.28]) with mapi id 14.03.0439.000; Thu, 2 Jan 2020 11:12:20 +0800 From: "Wu, Hao A" To: "Ni, Ray" , "Dong, Eric" , "Laszlo Ersek" , "devel@edk2.groups.io" CC: "Zeng, Star" , "Fu, Siyuan" , "Kinney, Michael D" Subject: Re: [edk2-devel] [PATCH v5 0/6] Microcode related optimizations Thread-Topic: [edk2-devel] [PATCH v5 0/6] Microcode related optimizations Thread-Index: AQHVv3QkzXmh1JjSQ0mnLUNNOCJZyKfWJrwAgACK95A= Date: Thu, 2 Jan 2020 03:12:19 +0000 Message-ID: References: <20191231004914.8520-1-hao.a.wu@intel.com> <734D49CCEBEEF84792F5B80ED585239D5C3D0651@SHSMSX104.ccr.corp.intel.com> In-Reply-To: <734D49CCEBEEF84792F5B80ED585239D5C3D0651@SHSMSX104.ccr.corp.intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: hao.a.wu@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Ray and Eric, thanks a lot for the review. Hello Laszlo, It seems that you are out of office, I plan to push the series without you= r comments first. If you have feedbacks/comments with regard to the series, = I will follow up for the potential refine/revert of the series. Best Regards, Hao Wu > -----Original Message----- > From: Ni, Ray > Sent: Thursday, January 02, 2020 10:40 AM > To: devel@edk2.groups.io; Wu, Hao A > Cc: Dong, Eric; Laszlo Ersek; Zeng, Star; Fu, Siyuan; Kinney, Michael D > Subject: RE: [edk2-devel] [PATCH v5 0/6] Microcode related optimizations >=20 > Reviewed-by: Ray Ni >=20 > > -----Original Message----- > > From: devel@edk2.groups.io On Behalf Of Wu, > Hao > > A > > Sent: Tuesday, December 31, 2019 8:49 AM > > To: devel@edk2.groups.io > > Cc: Wu, Hao A ; Dong, Eric ; > Ni, > > Ray ; Laszlo Ersek ; Zeng, Star > > ; Fu, Siyuan ; Kinney, > Michael > > D > > Subject: [edk2-devel] [PATCH v5 0/6] Microcode related optimizations > > > > Series is also available at: > > https://github.com/hwu25/edk2/tree/mpinitlib_opt_v5 > > > > V5 changes: > > A. For patch 2, address a typo to resolve enlarging the microcode patc= h > > information buffer too early when it is not full; > > B. For patch 4, relocate the logic of storing detected microcode patch > > before the application of microcode patch. > > > > V4 history: > > A. For patch 2, keep the calling sequence of functions: > > MicrocodeDetect() and MtrrGetAllMtrrs() unchanged for BSP. > > B. For patch 2, in function LoadMicrocodePatch(), add the missing logi= c > > that handles the Extended Signature Table of a microcode patch. > > > > > > V3 history: > > For patch 3, correct license information for newly added header file. > > > > V2 history: > > A. For patch 2, rename function parameters and variables to better ref= lect > > their usage; > > B. For patch 2, remove unneeded check in LoadMicrocodePatchWorker(); > > C. For patch 3, rename a couple of fields in the HOB structure; > > D. For patch 3, update the 'ProcessorSpecificPatchOffset' field to poi= nt > > to the microcode patch header instead of microcode patch data; > > E. Add a new patch 5 to address an issue that certain fields in the > > CPU_MP_DATA structure cannot be passed from PEI phase to DXE phase; > > F. Add a new patch 6 to remove the redundant microcode related fields = in > > the CPU_MP_DATA structure. > > > > V1 history: > > This series will introduce a couple of optimizations to the MpInitLib = with > > regard to microcode: > > > > A. Reduce the copy size when loading the microcode patches data from > flash > > into memory; > > B. Produce a HOB to contain microcode patches information for > subsequent > > consumers of the microcode patches during the boot flow. > > > > Uni-test done for the series: > > A. System boot to OS/Shell successfully on a real platform; > > B. Add debug message to verify the same microcode patch is applied to > each > > processor before and after the series. > > > > > > Cc: Eric Dong > > Cc: Ray Ni > > Cc: Laszlo Ersek > > Cc: Star Zeng > > Cc: Siyuan Fu > > Cc: Michael D Kinney > > > > Hao A Wu (6): > > UefiCpuPkg/MpInitLib: Collect processors' CPUID & Platform ID info > > UefiCpuPkg/MpInitLib: Reduce the size when loading microcode patches > > UefiCpuPkg: Add definitions for EDKII microcode patch HOB > > UefiCpuPkg/MpInitLib: Produce EDKII microcode patch HOB > > UefiCpuPkg/MpInitLib: Relocate microcode patch fields in CPU_MP_DATA > > UefiCpuPkg/MpInitLib: Remove redundant microcode fields in > > CPU_MP_DATA > > > > UefiCpuPkg/UefiCpuPkg.dec | 3 + > > UefiCpuPkg/Library/MpInitLib/PeiMpInitLib.inf | 1 + > > UefiCpuPkg/Include/Guid/MicrocodePatchHob.h | 44 +++ > > UefiCpuPkg/Library/MpInitLib/MpLib.h | 59 +++- > > UefiCpuPkg/Library/MpInitLib/Microcode.c | 351 > ++++++++++++++++++- > > - > > UefiCpuPkg/Library/MpInitLib/MpLib.c | 110 +++--- > > UefiCpuPkg/Library/MpInitLib/PeiMpLib.c | 55 +++ > > 7 files changed, 513 insertions(+), 110 deletions(-) > > create mode 100644 UefiCpuPkg/Include/Guid/MicrocodePatchHob.h > > > > -- > > 2.12.0.windows.1 > > > > > >=20