Re: [edk2-devel] [PATCH v3 2/3] MdeModulePkg/Usb/UsbMouse: Fix endpoint selection

["Wu, Hao A" <hao.a.wu@intel.com>]

> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> MrChromebox
> Sent: Monday, January 06, 2020 12:12 PM
> To: devel@edk2.groups.io
> Cc: Matt DeVillier
> Subject: [edk2-devel] [PATCH v3 2/3] MdeModulePkg/Usb/UsbMouse: Fix
> endpoint selection
> 
> The endpoint selected by the driver needs to not
> only be an interrupt type, but have direction IN
> as required to set up an asynchronous interrupt transfer.
> 
> Currently, the driver assumes that the first INT endpoint
> will be of type IN, but that is not true of all devices,
> and will silently fail on devices which have the OUT endpoint
> before the IN. Adjust the endpoint selection loop to explictly
> check for direction IN.
> 
> Signed-off-by: Matt DeVillier <matt.devillier@gmail.com>
> ---
>  MdeModulePkg/Bus/Usb/UsbMouseDxe/UsbMouse.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/MdeModulePkg/Bus/Usb/UsbMouseDxe/UsbMouse.c
> b/MdeModulePkg/Bus/Usb/UsbMouseDxe/UsbMouse.c
> index 677815a8ad..143ff15eb0 100644
> --- a/MdeModulePkg/Bus/Usb/UsbMouseDxe/UsbMouse.c
> +++ b/MdeModulePkg/Bus/Usb/UsbMouseDxe/UsbMouse.c
> @@ -203,7 +203,7 @@ USBMouseDriverBindingStart (
>    EndpointNumber = UsbMouseDevice->InterfaceDescriptor.NumEndpoints;
> 
>    //
> -  // Traverse endpoints to find interrupt endpoint
> +  // Traverse endpoints to find interrupt endpoint IN
>    //
>    Found = FALSE;
>    for (Index = 0; Index < EndpointNumber; Index++) {
> @@ -213,7 +213,8 @@ USBMouseDriverBindingStart (
>               &EndpointDescriptor
>               );
> 
> -    if ((EndpointDescriptor.Attributes & (BIT0 | BIT1)) ==
> USB_ENDPOINT_INTERRUPT) {
> +    if (((EndpointDescriptor.Attributes & (BIT0 | BIT1)) ==
> USB_ENDPOINT_INTERRUPT) &&
> +        ((EndpointDescriptor.EndpointAddress & USB_ENDPOINT_DIR_IN) != 0))
> {


Reviewed-by: Hao A Wu <hao.a.wu@intel.com>

Since there is only coding style change compared with V1 series, I will keep
the R-b tag by GuoMinJ <newexplorerj@gmail.com> as well.

Best Regards,
Hao Wu


>        //
>        // We only care interrupt endpoint here
>        //
> --
> 2.20.1
> 
> 
>