From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mx.groups.io with SMTP id smtpd.web10.5060.1578469102270098130 for ; Tue, 07 Jan 2020 23:38:22 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.126, mailfrom: hao.a.wu@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Jan 2020 23:38:21 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,409,1571727600"; d="scan'208";a="217999333" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga008.fm.intel.com with ESMTP; 07 Jan 2020 23:38:20 -0800 Received: from fmsmsx125.amr.corp.intel.com (10.18.125.40) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 7 Jan 2020 23:38:13 -0800 Received: from shsmsx108.ccr.corp.intel.com (10.239.4.97) by FMSMSX125.amr.corp.intel.com (10.18.125.40) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 7 Jan 2020 23:38:13 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.197]) by SHSMSX108.ccr.corp.intel.com ([169.254.8.39]) with mapi id 14.03.0439.000; Wed, 8 Jan 2020 15:38:10 +0800 From: "Wu, Hao A" To: "Albecki, Mateusz" , "devel@edk2.groups.io" CC: Marcin Wojtas , "Gao, Zhichao" , "Gao, Liming" Subject: Re: [PATCH 0/3] MdeModulePkg/SdMmcPciHcDxe: Retry the commands that failed due to CRC error Thread-Topic: [PATCH 0/3] MdeModulePkg/SdMmcPciHcDxe: Retry the commands that failed due to CRC error Thread-Index: AQHVxUqN0iBDMV5HfUS8ekmCGy4bUqfgYhtA Date: Wed, 8 Jan 2020 07:38:10 +0000 Message-ID: References: <20200107110621.232-1-mateusz.albecki@intel.com> In-Reply-To: <20200107110621.232-1-mateusz.albecki@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: hao.a.wu@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: Albecki, Mateusz > Sent: Tuesday, January 07, 2020 7:06 PM > To: devel@edk2.groups.io > Cc: Albecki, Mateusz; Wu, Hao A; Marcin Wojtas; Gao, Zhichao; Gao, Liming > Subject: [PATCH 0/3] MdeModulePkg/SdMmcPciHcDxe: Retry the > commands that failed due to CRC error >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1140 >=20 > Some of the boards report that just after we change the clock frequency t= o > 200MHz link is > unable to stabilize fast enough and when driver sends the CMD13 it will o= ften > fail > randomly with CRC error. To protect against this kind of random failures = this > patch > series will make the driver retry the commands that failed due to random > CRC errors. >=20 > Since async code has not yet been tested it has been put into separate pa= tch. > That patch > is not needed to solve most pressing CMD13 issues. >=20 > Tets performed: > -Boot eMMC in HS400 > -Boot eMMC in HS400 with simulated CRC error on every first CMD13 Hello Mateusz, Thanks for the contribution. Please grant me some time to review and validate the series. I will try to give my feedbacks no later than early next week. Best Regards, Hao Wu >=20 > Cc: Hao A Wu > Cc: Marcin Wojtas > Cc: Zhichao Gao > Cc: Liming Gao >=20 > Signed-off-by: Mateusz Albecki >=20 > Mateusz Albecki (3): > MdeModulePkg/SdMmcPciHcDxe: Refactor command error detection > MdeModulePkg/SdMmcPciHcDxe: Add retries for sync commands > MdeModulePkg/SdMmcPciHcDxe: Add retries for async commands >=20 > MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.c | 89 +++++--- > MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.h | 5 +- > MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c | 235 > ++++++++++++++------- > 3 files changed, 221 insertions(+), 108 deletions(-) >=20 > -- > 2.14.1.windows.1