public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Wu, Hao A" <hao.a.wu@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	"Wu, Hao A" <hao.a.wu@intel.com>,
	"Albecki, Mateusz" <mateusz.albecki@intel.com>
Subject: Re: [edk2-devel] [PATCH 1/1] MdeModulePkg/SdMmcPciHcDxe: Fix unknown doxygen tag error
Date: Mon, 13 Jan 2020 01:26:07 +0000	[thread overview]
Message-ID: <B80AF82E9BFB8E4FBD8C89DA810C6A093C9929BC@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <B80AF82E9BFB8E4FBD8C89DA810C6A093C992977@SHSMSX104.ccr.corp.intel.com>

> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Wu, Hao A
> Sent: Monday, January 13, 2020 9:09 AM
> To: Albecki, Mateusz; devel@edk2.groups.io
> Subject: Re: [edk2-devel] [PATCH 1/1] MdeModulePkg/SdMmcPciHcDxe: Fix
> unknown doxygen tag error
> 
> > -----Original Message-----
> > From: Albecki, Mateusz
> > Sent: Friday, January 10, 2020 6:26 PM
> > To: devel@edk2.groups.io
> > Cc: Albecki, Mateusz; Wu, Hao A
> > Subject: [PATCH 1/1] MdeModulePkg/SdMmcPciHcDxe: Fix unknown
> > doxygen tag error
> >
> > Changed @rtval to @retval in SdMmcHcStartSdClock
> > function description.
> >
> > Cc: Hao A Wu <hao.a.wu@intel.com>
> >
> > Signed-off-by: Mateusz Albecki <mateusz.albecki@intel.com>
> > ---
> >  MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c | 2 +-
> >  MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.h | 2 +-
> >  2 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c
> > b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c
> > index e7f2fac69b..d1e60938f9 100644
> > --- a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c
> > +++ b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c
> > @@ -765,7 +765,7 @@ SdMmcHcStopClock (
> >    @param[in] Slot   The slot number.
> >
> >    @retval EFI_SUCCESS  Succeeded to start the SD clock.
> > -  @rtval  Others       Failed to start the SD clock.
> > +  @retval Others       Failed to start the SD clock.
> >  **/
> >  EFI_STATUS
> >  SdMmcHcStartSdClock (
> > diff --git a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.h
> > b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.h
> > index 4753bb6864..16229a846c 100644
> > --- a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.h
> > +++ b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.h
> > @@ -485,7 +485,7 @@ SdMmcHcStopClock (
> >    @param[in] Slot   The slot number.
> >
> >    @retval EFI_SUCCESS  Succeeded to start the SD clock.
> > -  @rtval  Others       Failed to start the SD clock.
> > +  @retval Others       Failed to start the SD clock.
> >  **/
> 
> 
> Reviewed-by: Hao A Wu <hao.a.wu@intel.com>


Pushed via commit 27f44ea1fb.

Best Regards,
Hao Wu


> 
> Best Regards,
> Hao Wu
> 
> 
> >  EFI_STATUS
> >  SdMmcHcStartSdClock (
> > --
> > 2.14.1.windows.1
> 
> 
> 


      reply	other threads:[~2020-01-13  1:26 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-10 10:26 [PATCH 1/1] MdeModulePkg/SdMmcPciHcDxe: Fix unknown doxygen tag error Albecki, Mateusz
2020-01-13  1:09 ` Wu, Hao A
2020-01-13  1:26   ` Wu, Hao A [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=B80AF82E9BFB8E4FBD8C89DA810C6A093C9929BC@SHSMSX104.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox