From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mx.groups.io with SMTP id smtpd.web09.1088.1579052988478429784 for ; Tue, 14 Jan 2020 17:49:48 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: hao.a.wu@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Jan 2020 17:49:47 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,320,1574150400"; d="scan'208";a="213540033" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga007.jf.intel.com with ESMTP; 14 Jan 2020 17:49:47 -0800 Received: from fmsmsx114.amr.corp.intel.com (10.18.116.8) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 14 Jan 2020 17:49:47 -0800 Received: from shsmsx105.ccr.corp.intel.com (10.239.4.158) by FMSMSX114.amr.corp.intel.com (10.18.116.8) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 14 Jan 2020 17:49:47 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.197]) by SHSMSX105.ccr.corp.intel.com ([169.254.11.28]) with mapi id 14.03.0439.000; Wed, 15 Jan 2020 09:49:44 +0800 From: "Wu, Hao A" To: "devel@edk2.groups.io" , "Albecki, Mateusz" CC: Marcin Wojtas , "Gao, Zhichao" , "Gao, Liming" Subject: Re: [edk2-devel] [PATCHv2 0/4] MdeModulePkg/SdMmcPciHcDxe: Retry the commands that failed due to CRC error Thread-Topic: [edk2-devel] [PATCHv2 0/4] MdeModulePkg/SdMmcPciHcDxe: Retry the commands that failed due to CRC error Thread-Index: AQHVytL9+S+jaCKLNEag+Zc7zxq1J6fq9etA Date: Wed, 15 Jan 2020 01:49:43 +0000 Message-ID: References: <20200114120530.1660-1-mateusz.albecki@intel.com> In-Reply-To: <20200114120530.1660-1-mateusz.albecki@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: hao.a.wu@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Albecki, Mateusz > Sent: Tuesday, January 14, 2020 8:05 PM > To: devel@edk2.groups.io > Cc: Albecki, Mateusz; Wu, Hao A; Marcin Wojtas; Gao, Zhichao; Gao, Limin= g > Subject: [edk2-devel] [PATCHv2 0/4] MdeModulePkg/SdMmcPciHcDxe: > Retry the commands that failed due to CRC error >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1140 >=20 > Some of the boards report that just after we change the clock frequency = to > 200MHz link is unable to stabilize fast enough and when driver sends the > CMD13 it will often fail randomly with CRC error. To protect against thi= s kind > of random failures this patch series will make the driver retry the comm= ands > that failed due to random CRC errors. >=20 > Since async code has not yet been tested it has been put into separate p= atch. > That patch is not needed to solve most pressing CMD13 issues. >=20 > changes in v2: > -Split first patch into bugfix and refactor > -Normal interrupt status register will now only be read once during > SdMmcCheckTrbResult > -We will no longer clear the data transfer timeout error in > SdMmcCheckAndRecoverErrors. Instead we will immedieatly return for such > case and register reset will be done in next SdMmcExecTrb >=20 > Tets performed: > -Boot eMMC in HS400 > -Boot eMMC in HS400 with simulated CRC error on every first CMD13 For the series, Reviewed-by: Hao A Wu I will wait a couple of days to see if there are comments from other revie= wers before pushing the series. Best Regards, Hao Wu >=20 > Cc: Hao A Wu > Cc: Marcin Wojtas > Cc: Zhichao Gao > Cc: Liming Gao >=20 > Signed-off-by: Mateusz Albecki >=20 >=20 > Mateusz Albecki (4): > MdeModulePkg/SdMmcPciHcDxe: Fix DAT lane SW reset > MdeModulePkg/SdMmcPciHcDxe: Refactor command error detection > MdeModulePkg/SdMmcPciHcDxe: Add retries for sync commands > MdeModulePkg/SdMmcPciHcDxe: Add retries for async commands >=20 > MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.c | 89 ++++++-- > - > MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.h | 5 +- > MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c | 218 > ++++++++++++++------- > 3 files changed, 204 insertions(+), 108 deletions(-) >=20 > -- > 2.14.1.windows.1 >=20 > -------------------------------------------------------------------- >=20 > Intel Technology Poland sp. z o.o. > ul. Slowackiego 173 | 80-298 Gdansk | Sad Rejonowy Gdansk Polnoc | VII > Wydzial Gospodarczy Krajowego Rejestru Sadowego - KRS 101882 | NIP 957- > 07-52-316 | Kapital zakladowy 200.000 PLN. >=20 > Ta wiadomosc wraz z zalacznikami jest przeznaczona dla okreslonego > adresata i moze zawierac informacje poufne. W razie przypadkowego > otrzymania tej wiadomosci, prosimy o powiadomienie nadawcy oraz trwale > jej usuniecie; jakiekolwiek > przegladanie lub rozpowszechnianie jest zabronione. > This e-mail and any attachments may contain confidential material for th= e > sole use of the intended recipient(s). If you are not the intended recip= ient, > please contact the sender and delete all copies; any review or distribut= ion by > others is strictly prohibited. >=20 >=20 >=20