From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mx.groups.io with SMTP id smtpd.web09.457.1579399489675196374 for ; Sat, 18 Jan 2020 18:04:49 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.120, mailfrom: hao.a.wu@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Jan 2020 18:04:49 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,336,1574150400"; d="scan'208";a="258298728" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga002.fm.intel.com with ESMTP; 18 Jan 2020 18:04:49 -0800 Received: from FMSMSX110.amr.corp.intel.com (10.18.116.10) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sat, 18 Jan 2020 18:04:36 -0800 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx110.amr.corp.intel.com (10.18.116.10) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sat, 18 Jan 2020 18:04:35 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.197]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.203]) with mapi id 14.03.0439.000; Sun, 19 Jan 2020 10:04:33 +0800 From: "Wu, Hao A" To: "devel@edk2.groups.io" , "Wu, Hao A" , "Albecki, Mateusz" CC: Marcin Wojtas , "Gao, Zhichao" , "Gao, Liming" Subject: Re: [edk2-devel] [PATCHv2 0/4] MdeModulePkg/SdMmcPciHcDxe: Retry the commands that failed due to CRC error Thread-Topic: [edk2-devel] [PATCHv2 0/4] MdeModulePkg/SdMmcPciHcDxe: Retry the commands that failed due to CRC error Thread-Index: AQHVytL9+S+jaCKLNEag+Zc7zxq1J6fq9etAgAZNz2A= Date: Sun, 19 Jan 2020 02:04:33 +0000 Message-ID: References: <20200114120530.1660-1-mateusz.albecki@intel.com> In-Reply-To: Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: hao.a.wu@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Wu, Hao A > Sent: Wednesday, January 15, 2020 9:50 AM > To: devel@edk2.groups.io; Albecki, Mateusz > Cc: Marcin Wojtas; Gao, Zhichao; Gao, Liming > Subject: Re: [edk2-devel] [PATCHv2 0/4] MdeModulePkg/SdMmcPciHcDxe: > Retry the commands that failed due to CRC error >=20 > > -----Original Message----- > > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > > Albecki, Mateusz > > Sent: Tuesday, January 14, 2020 8:05 PM > > To: devel@edk2.groups.io > > Cc: Albecki, Mateusz; Wu, Hao A; Marcin Wojtas; Gao, Zhichao; Gao, Lim= ing > > Subject: [edk2-devel] [PATCHv2 0/4] MdeModulePkg/SdMmcPciHcDxe: > > Retry the commands that failed due to CRC error > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1140 > > > > Some of the boards report that just after we change the clock frequenc= y to > > 200MHz link is unable to stabilize fast enough and when driver sends t= he > > CMD13 it will often fail randomly with CRC error. To protect against t= his kind > > of random failures this patch series will make the driver retry the > commands > > that failed due to random CRC errors. > > > > Since async code has not yet been tested it has been put into separate > patch. > > That patch is not needed to solve most pressing CMD13 issues. > > > > changes in v2: > > -Split first patch into bugfix and refactor > > -Normal interrupt status register will now only be read once during > > SdMmcCheckTrbResult > > -We will no longer clear the data transfer timeout error in > > SdMmcCheckAndRecoverErrors. Instead we will immedieatly return for > such > > case and register reset will be done in next SdMmcExecTrb > > > > Tets performed: > > -Boot eMMC in HS400 > > -Boot eMMC in HS400 with simulated CRC error on every first CMD13 >=20 >=20 > For the series, > Reviewed-by: Hao A Wu >=20 > I will wait a couple of days to see if there are comments from other > reviewers > before pushing the series. Series pushed via commits c40c6351fa..430743a1e8. Best Regards, Hao Wu >=20 > Best Regards, > Hao Wu >=20 >=20 > > > > Cc: Hao A Wu > > Cc: Marcin Wojtas > > Cc: Zhichao Gao > > Cc: Liming Gao > > > > Signed-off-by: Mateusz Albecki > > > > > > Mateusz Albecki (4): > > MdeModulePkg/SdMmcPciHcDxe: Fix DAT lane SW reset > > MdeModulePkg/SdMmcPciHcDxe: Refactor command error detection > > MdeModulePkg/SdMmcPciHcDxe: Add retries for sync commands > > MdeModulePkg/SdMmcPciHcDxe: Add retries for async commands > > > > MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.c | 89 > ++++++-- > > - > > MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.h | 5 +- > > MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c | 218 > > ++++++++++++++------- > > 3 files changed, 204 insertions(+), 108 deletions(-) > > > > -- > > 2.14.1.windows.1 > > > > -------------------------------------------------------------------- > > > > Intel Technology Poland sp. z o.o. > > ul. Slowackiego 173 | 80-298 Gdansk | Sad Rejonowy Gdansk Polnoc | VII > > Wydzial Gospodarczy Krajowego Rejestru Sadowego - KRS 101882 | NIP > 957- > > 07-52-316 | Kapital zakladowy 200.000 PLN. > > > > Ta wiadomosc wraz z zalacznikami jest przeznaczona dla okreslonego > > adresata i moze zawierac informacje poufne. W razie przypadkowego > > otrzymania tej wiadomosci, prosimy o powiadomienie nadawcy oraz trwale > > jej usuniecie; jakiekolwiek > > przegladanie lub rozpowszechnianie jest zabronione. > > This e-mail and any attachments may contain confidential material for = the > > sole use of the intended recipient(s). If you are not the intended rec= ipient, > > please contact the sender and delete all copies; any review or distrib= ution > by > > others is strictly prohibited. > > > > > > >=20 >=20 >=20