Re: [PATCH 0/4] MdeModulePkg/SdMmcPciHcDxe: Refactor command processing

["Wu, Hao A" <hao.a.wu@intel.com>]

> -----Original Message-----
> From: Albecki, Mateusz
> Sent: Monday, February 03, 2020 10:19 PM
> To: devel@edk2.groups.io
> Cc: Albecki, Mateusz; Wu, Hao A; Marcin Wojtas; Gao, Zhichao; Gao, Liming
> Subject: [PATCH 0/4] MdeModulePkg/SdMmcPciHcDxe: Refactor command
> processing


Hello Mateusz,

Please grant me some time for this series.
I do not have access to hardware in order to test this series at this moment,
will try to provide feedbacks early next week.

Best Regards,
Hao Wu


> 
> This patch series aims to refactor command processing to achieve following
> 
> 1. Trace the failing TRB packets to see what commands are failing and for
> what reasons
> 2. Get the response data even if data transfer timed out to allow easier
> debugging
> 3. Fix the PIO mode which is currently completely broken.
> 
> Tests performed:
> 1. Each patch in the series has passed boot from eMMC with ADMAv3 data
> transfer mode
> 2. SDMA based boot has been tested with the full patch series
> 3. PIO based boot has been tested with the full patch series
> 4. PIO based data transfer has been additionally tested by creating and
> modyfing a file in EFI shell
> 
> All tests were performed with eMMC in HS400 @200MHz clock frequency.
> 
> For easier review & integration patch has been pushed here:
> Whole series:
> https://github.com/malbecki/edk2/tree/emmc_transfer_refactor
> Whole series + SDMA force code(test 3):
> https://github.com/malbecki/edk2/tree/emmc_transfer_refactor_force_sd
> ma
> Whole series + PIO force code(test 4):
> https://github.com/malbecki/edk2/tree/emmc_transfer_refactor_force_pio
> 
> Cc: Hao A Wu <hao.a.wu@intel.com>
> Cc: Marcin Wojtas <mw@semihalf.com>
> Cc: Zhichao Gao <zhichao.gao@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> 
> 
> Mateusz Albecki (4):
>   MdeModulePkg/SdMmcPciHcDxe: Enhance driver traces
>   MdeModulePkg/SdMmcPciHcDxe: Read response on command completion
>   MdeModulePkg/SdMmcPciHcDxe: Refactor data transfer completion
>   MdeModulePkg/SdMmcPciHcDxe: Fix PIO transfer mode
> 
>  MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.h |   4 +
>  MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c   | 502
> ++++++++++++++++-----
>  2 files changed, 398 insertions(+), 108 deletions(-)
> 
> --
> 2.14.1.windows.1