From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mx.groups.io with SMTP id smtpd.web10.3311.1580803129196690129 for ; Mon, 03 Feb 2020 23:58:49 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.20, mailfrom: hao.a.wu@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Feb 2020 23:58:48 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,398,1574150400"; d="scan'208";a="263748684" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga002.fm.intel.com with ESMTP; 03 Feb 2020 23:58:48 -0800 Received: from fmsmsx115.amr.corp.intel.com (10.18.116.19) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 3 Feb 2020 23:58:48 -0800 Received: from shsmsx154.ccr.corp.intel.com (10.239.6.54) by fmsmsx115.amr.corp.intel.com (10.18.116.19) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 3 Feb 2020 23:58:47 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.5]) by SHSMSX154.ccr.corp.intel.com ([169.254.7.141]) with mapi id 14.03.0439.000; Tue, 4 Feb 2020 15:58:45 +0800 From: "Wu, Hao A" To: "Albecki, Mateusz" , "devel@edk2.groups.io" CC: Marcin Wojtas , "Gao, Zhichao" , "Gao, Liming" Subject: Re: [PATCH 0/4] MdeModulePkg/SdMmcPciHcDxe: Refactor command processing Thread-Topic: [PATCH 0/4] MdeModulePkg/SdMmcPciHcDxe: Refactor command processing Thread-Index: AQHV2pzrFuDmEFIQckuhYNs9lbAod6gKq9Nw Date: Tue, 4 Feb 2020 07:58:44 +0000 Message-ID: References: <20200203141858.3236-1-mateusz.albecki@intel.com> In-Reply-To: <20200203141858.3236-1-mateusz.albecki@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: hao.a.wu@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: Albecki, Mateusz > Sent: Monday, February 03, 2020 10:19 PM > To: devel@edk2.groups.io > Cc: Albecki, Mateusz; Wu, Hao A; Marcin Wojtas; Gao, Zhichao; Gao, Liming > Subject: [PATCH 0/4] MdeModulePkg/SdMmcPciHcDxe: Refactor command > processing Hello Mateusz, Please grant me some time for this series. I do not have access to hardware in order to test this series at this momen= t, will try to provide feedbacks early next week. Best Regards, Hao Wu >=20 > This patch series aims to refactor command processing to achieve followin= g >=20 > 1. Trace the failing TRB packets to see what commands are failing and for > what reasons > 2. Get the response data even if data transfer timed out to allow easier > debugging > 3. Fix the PIO mode which is currently completely broken. >=20 > Tests performed: > 1. Each patch in the series has passed boot from eMMC with ADMAv3 data > transfer mode > 2. SDMA based boot has been tested with the full patch series > 3. PIO based boot has been tested with the full patch series > 4. PIO based data transfer has been additionally tested by creating and > modyfing a file in EFI shell >=20 > All tests were performed with eMMC in HS400 @200MHz clock frequency. >=20 > For easier review & integration patch has been pushed here: > Whole series: > https://github.com/malbecki/edk2/tree/emmc_transfer_refactor > Whole series + SDMA force code(test 3): > https://github.com/malbecki/edk2/tree/emmc_transfer_refactor_force_sd > ma > Whole series + PIO force code(test 4): > https://github.com/malbecki/edk2/tree/emmc_transfer_refactor_force_pio >=20 > Cc: Hao A Wu > Cc: Marcin Wojtas > Cc: Zhichao Gao > Cc: Liming Gao >=20 >=20 > Mateusz Albecki (4): > MdeModulePkg/SdMmcPciHcDxe: Enhance driver traces > MdeModulePkg/SdMmcPciHcDxe: Read response on command completion > MdeModulePkg/SdMmcPciHcDxe: Refactor data transfer completion > MdeModulePkg/SdMmcPciHcDxe: Fix PIO transfer mode >=20 > MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.h | 4 + > MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c | 502 > ++++++++++++++++----- > 2 files changed, 398 insertions(+), 108 deletions(-) >=20 > -- > 2.14.1.windows.1