Re: [edk2-devel] [PATCH 2/4] MdeModulePkg/SdMmcPciHcDxe: Read response on command completion

["Wu, Hao A" <hao.a.wu@intel.com>]

One question below:


> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Albecki, Mateusz
> Sent: Monday, February 03, 2020 10:19 PM
> To: devel@edk2.groups.io
> Cc: Albecki, Mateusz; Wu, Hao A; Marcin Wojtas; Gao, Zhichao; Gao, Liming
> Subject: [edk2-devel] [PATCH 2/4] MdeModulePkg/SdMmcPciHcDxe: Read
> response on command completion
> 
> SdMmcPciHcDxe driver used to read response only after
> command and data transfer completed. According to SDHCI
> specification response data is ready after the command
> complete status is set by the host controller. Getting
> the response data early will help debugging the cases
> when command completed but data transfer timed out.
> 
> Cc: Hao A Wu <hao.a.wu@intel.com>
> Cc: Marcin Wojtas <mw@semihalf.com>
> Cc: Zhichao Gao <zhichao.gao@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> 
> Signed-off-by: Mateusz Albecki <mateusz.albecki@intel.com>
> ---
>  MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.h |   1 +
>  MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c   | 201
> +++++++++++++++------
>  2 files changed, 144 insertions(+), 58 deletions(-)
> 
> diff --git a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.h
> b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.h
> index 5bc3577ba2..15b7d12596 100644
> --- a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.h
> +++ b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.h
> @@ -153,6 +153,7 @@ typedef struct {
> 
>    EFI_EVENT                           Event;
>    BOOLEAN                             Started;
> +  BOOLEAN                             CommandComplete;
>    UINT64                              Timeout;
>    UINT32                              Retries;
> 
> diff --git a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c
> b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c
> index 959645bf26..3dfaae8542 100644
> --- a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c
> +++ b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c
> @@ -1708,6 +1708,7 @@ SdMmcPrintTrb (
>    DEBUG ((DebugLevel, "AdmaLengthMode: %d\n", Trb->AdmaLengthMode));
>    DEBUG ((DebugLevel, "Event: %d\n", Trb->Event));
>    DEBUG ((DebugLevel, "Started: %d\n", Trb->Started));
> +  DEBUG ((DebugLevel, "CommandComplete: %d\n", Trb-
> >CommandComplete));
>    DEBUG ((DebugLevel, "Timeout: %d\n", Trb->Timeout));
>    DEBUG ((DebugLevel, "Retries: %d\n", Trb->Retries));
>    DEBUG ((DebugLevel, "Adma32Desc: %X\n", Trb->Adma32Desc));
> @@ -1758,6 +1759,7 @@ SdMmcCreateTrb (
>    Trb->Packet    = Packet;
>    Trb->Event     = Event;
>    Trb->Started   = FALSE;
> +  Trb->CommandComplete = FALSE;
>    Trb->Timeout   = Packet->Timeout;
>    Trb->Retries   = SD_MMC_TRB_RETRIES;
>    Trb->Private   = Private;
> @@ -2352,6 +2354,99 @@ SdMmcCheckAndRecoverErrors (
>    return ErrorStatus;
>  }
> 
> +/**
> +  Reads the response data into the TRB buffer.
> +  This function assumes that caller made sure that
> +  command has completed.
> +
> +  @param[in] Private  A pointer to the SD_MMC_HC_PRIVATE_DATA
> instance.
> +  @param[in] Trb      The pointer to the SD_MMC_HC_TRB instance.
> +
> +  @retval EFI_SUCCESS  Response read successfully.
> +  @retval Others       Failed to get response.
> +**/
> +EFI_STATUS
> +SdMmcGetResponse (
> +  IN SD_MMC_HC_PRIVATE_DATA  *Private,
> +  IN SD_MMC_HC_TRB           *Trb
> +  )
> +{
> +  EFI_SD_MMC_PASS_THRU_COMMAND_PACKET  *Packet;
> +  UINT8                                Index;
> +  UINT32                               Response[4];
> +  EFI_STATUS                           Status;
> +
> +  Packet = Trb->Packet;
> +
> +  if (Packet->SdMmcCmdBlk->CommandType == SdMmcCommandTypeBc) {
> +    return EFI_SUCCESS;
> +  }
> +
> +  for (Index = 0; Index < 4; Index++) {
> +    Status = SdMmcHcRwMmio (
> +               Private->PciIo,
> +               Trb->Slot,
> +               SD_MMC_HC_RESPONSE + Index * 4,
> +               TRUE,
> +               sizeof (UINT32),
> +               &Response[Index]
> +               );
> +      if (EFI_ERROR (Status)) {
> +        return Status;
> +      }
> +    }
> +  CopyMem (Packet->SdMmcStatusBlk, Response, sizeof (Response));
> +
> +  return EFI_SUCCESS;
> +}
> +
> +/**
> +  Checks if the command completed. If the command
> +  completed it gets the response and records the
> +  command completion in the TRB.
> +
> +  @param[in] Private    A pointer to the SD_MMC_HC_PRIVATE_DATA
> instance.
> +  @param[in] Trb        The pointer to the SD_MMC_HC_TRB instance.
> +  @param[in] IntStatus  Snapshot of the normal interrupt status register.
> +
> +  @retval EFI_SUCCESS   Command completed successfully.
> +  @retval EFI_NOT_READY Command completion still pending.
> +  @retval Others        Command failed to complete.
> +**/
> +EFI_STATUS
> +SdMmcCheckCommandComplete (
> +  IN SD_MMC_HC_PRIVATE_DATA  *Private,
> +  IN SD_MMC_HC_TRB           *Trb,
> +  IN UINT16                  IntStatus
> +  )
> +{
> +  UINT16      Data16;
> +  EFI_STATUS  Status;
> +
> +  if ((IntStatus & BIT0) != 0) {
> +    Data16 = BIT0;
> +    Status = SdMmcHcRwMmio (
> +               Private->PciIo,
> +               Trb->Slot,
> +               SD_MMC_HC_NOR_INT_STS,
> +               FALSE,
> +               sizeof (Data16),
> +               &Data16
> +               );


Previously, the driver cleans the Command Complete (BIT0) at the beginning of
the execution of the next TRB in function SdMmcExecTrb(). Now, the patch will
clean this bit just after checking it.

So the behavior in the patch is more aligned with the SD Host Controller Spec,
right?

Best Regards,
Hao Wu


> +    if (EFI_ERROR (Status)) {
> +      return Status;
> +    }
> +    Status = SdMmcGetResponse (Private, Trb);
> +    if (EFI_ERROR (Status)) {
> +      return Status;
> +    }
> +    Trb->CommandComplete = TRUE;
> +    return EFI_SUCCESS;
> +  }
> +
> +  return EFI_NOT_READY;
> +}
> +
>  /**
>    Check the TRB execution result.
> 
> @@ -2372,9 +2467,7 @@ SdMmcCheckTrbResult (
>    EFI_STATUS                          Status;
>    EFI_SD_MMC_PASS_THRU_COMMAND_PACKET *Packet;
>    UINT16                              IntStatus;
> -  UINT32                              Response[4];
>    UINT64                              SdmaAddr;
> -  UINT8                               Index;
>    UINT32                              PioLength;
> 
>    Packet  = Trb->Packet;
> @@ -2402,6 +2495,54 @@ SdMmcCheckTrbResult (
>      goto Done;
>    }
> 
> +  //
> +  // Tuning commands are the only ones that do not generate command
> +  // complete interrupt. Process them here before entering the code
> +  // that waits for command completion.
> +  //
> +  if (((Private->Slot[Trb->Slot].CardType == EmmcCardType) &&
> +       (Packet->SdMmcCmdBlk->CommandIndex ==
> EMMC_SEND_TUNING_BLOCK)) ||
> +      ((Private->Slot[Trb->Slot].CardType == SdCardType) &&
> +       (Packet->SdMmcCmdBlk->CommandIndex ==
> SD_SEND_TUNING_BLOCK))) {
> +    //
> +    // When performing tuning procedure (Execute Tuning is set to 1) through
> PIO mode,
> +    // wait Buffer Read Ready bit of Normal Interrupt Status Register to be 1.
> +    // Refer to SD Host Controller Simplified Specification 3.0 figure 2-29 for
> details.
> +    //
> +    if ((IntStatus & BIT5) == BIT5) {
> +      //
> +      // Clear Buffer Read Ready interrupt at first.
> +      //
> +      IntStatus = BIT5;
> +      SdMmcHcRwMmio (Private->PciIo, Trb->Slot,
> SD_MMC_HC_NOR_INT_STS, FALSE, sizeof (IntStatus), &IntStatus);
> +      //
> +      // Read data out from Buffer Port register
> +      //
> +      for (PioLength = 0; PioLength < Trb->DataLen; PioLength += 4) {
> +        SdMmcHcRwMmio (Private->PciIo, Trb->Slot,
> SD_MMC_HC_BUF_DAT_PORT, TRUE, 4, (UINT8*)Trb->Data + PioLength);
> +      }
> +      Status = EFI_SUCCESS;
> +      goto Done;
> +    }
> +  }
> +
> +  if (!Trb->CommandComplete) {
> +    Status = SdMmcCheckCommandComplete (Private, Trb, IntStatus);
> +    if (EFI_ERROR (Status)) {
> +      goto Done;
> +    } else {
> +      //
> +      // If the command doesn't require data transfer skip the transfer
> +      // complete checking.
> +      //
> +      if ((Packet->SdMmcCmdBlk->CommandType !=
> SdMmcCommandTypeAdtc) &&
> +          (Packet->SdMmcCmdBlk->ResponseType != SdMmcResponseTypeR1b)
> &&
> +          (Packet->SdMmcCmdBlk->ResponseType != SdMmcResponseTypeR5b))
> {
> +        goto Done;
> +      }
> +    }
> +  }
> +
>    //
>    // Check Transfer Complete bit is set or not.
>    //
> @@ -2459,65 +2600,9 @@ SdMmcCheckTrbResult (
>      Trb->DataPhy = (UINT64)(UINTN)SdmaAddr;
>    }
> 
> -  if ((Packet->SdMmcCmdBlk->CommandType != SdMmcCommandTypeAdtc)
> &&
> -      (Packet->SdMmcCmdBlk->ResponseType != SdMmcResponseTypeR1b)
> &&
> -      (Packet->SdMmcCmdBlk->ResponseType != SdMmcResponseTypeR5b)) {
> -    if ((IntStatus & BIT0) == BIT0) {
> -      Status = EFI_SUCCESS;
> -      goto Done;
> -    }
> -  }
> -
> -  if (((Private->Slot[Trb->Slot].CardType == EmmcCardType) &&
> -       (Packet->SdMmcCmdBlk->CommandIndex ==
> EMMC_SEND_TUNING_BLOCK)) ||
> -      ((Private->Slot[Trb->Slot].CardType == SdCardType) &&
> -       (Packet->SdMmcCmdBlk->CommandIndex ==
> SD_SEND_TUNING_BLOCK))) {
> -    //
> -    // When performing tuning procedure (Execute Tuning is set to 1) through
> PIO mode,
> -    // wait Buffer Read Ready bit of Normal Interrupt Status Register to be 1.
> -    // Refer to SD Host Controller Simplified Specification 3.0 figure 2-29 for
> details.
> -    //
> -    if ((IntStatus & BIT5) == BIT5) {
> -      //
> -      // Clear Buffer Read Ready interrupt at first.
> -      //
> -      IntStatus = BIT5;
> -      SdMmcHcRwMmio (Private->PciIo, Trb->Slot,
> SD_MMC_HC_NOR_INT_STS, FALSE, sizeof (IntStatus), &IntStatus);
> -      //
> -      // Read data out from Buffer Port register
> -      //
> -      for (PioLength = 0; PioLength < Trb->DataLen; PioLength += 4) {
> -        SdMmcHcRwMmio (Private->PciIo, Trb->Slot,
> SD_MMC_HC_BUF_DAT_PORT, TRUE, 4, (UINT8*)Trb->Data + PioLength);
> -      }
> -      Status = EFI_SUCCESS;
> -      goto Done;
> -    }
> -  }
> 
>    Status = EFI_NOT_READY;
>  Done:
> -  //
> -  // Get response data when the cmd is executed successfully.
> -  //
> -  if (!EFI_ERROR (Status)) {
> -    if (Packet->SdMmcCmdBlk->CommandType != SdMmcCommandTypeBc) {
> -      for (Index = 0; Index < 4; Index++) {
> -        Status = SdMmcHcRwMmio (
> -                   Private->PciIo,
> -                   Trb->Slot,
> -                   SD_MMC_HC_RESPONSE + Index * 4,
> -                   TRUE,
> -                   sizeof (UINT32),
> -                   &Response[Index]
> -                   );
> -        if (EFI_ERROR (Status)) {
> -          SdMmcHcLedOnOff (Private->PciIo, Trb->Slot, FALSE);
> -          return Status;
> -        }
> -      }
> -      CopyMem (Packet->SdMmcStatusBlk, Response, sizeof (Response));
> -    }
> -  }
> 
>    if (Status != EFI_NOT_READY) {
>      SdMmcHcLedOnOff (Private->PciIo, Trb->Slot, FALSE);
> --
> 2.14.1.windows.1
> 
> --------------------------------------------------------------------
> 
> Intel Technology Poland sp. z o.o.
> ul. Slowackiego 173 | 80-298 Gdansk | Sad Rejonowy Gdansk Polnoc | VII
> Wydzial Gospodarczy Krajowego Rejestru Sadowego - KRS 101882 | NIP 957-
> 07-52-316 | Kapital zakladowy 200.000 PLN.
> 
> Ta wiadomosc wraz z zalacznikami jest przeznaczona dla okreslonego
> adresata i moze zawierac informacje poufne. W razie przypadkowego
> otrzymania tej wiadomosci, prosimy o powiadomienie nadawcy oraz trwale
> jej usuniecie; jakiekolwiek
> przegladanie lub rozpowszechnianie jest zabronione.
> This e-mail and any attachments may contain confidential material for the
> sole use of the intended recipient(s). If you are not the intended recipient,
> please contact the sender and delete all copies; any review or distribution by
> others is strictly prohibited.
> 
> 
>