public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Wu, Hao A" <hao.a.wu@intel.com>
To: Philippe Mathieu-Daude <philmd@redhat.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: Antoine Coeur <coeur@gmx.fr>, "Wang, Jian J" <jian.j.wang@intel.com>
Subject: Re: [PATCH v2 17/78] MdeModulePkg/Core/PiSmmCore: Fix various typos
Date: Fri, 7 Feb 2020 00:26:38 +0000	[thread overview]
Message-ID: <B80AF82E9BFB8E4FBD8C89DA810C6A093C9A4C72@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <20200103090812.10592-18-philmd@redhat.com>

> -----Original Message-----
> From: Philippe Mathieu-Daude [mailto:philmd@redhat.com]
> Sent: Friday, January 03, 2020 5:07 PM
> To: devel@edk2.groups.io
> Cc: Antoine Coeur; Wang, Jian J; Wu, Hao A; Philippe Mathieu-Daude
> Subject: [PATCH v2 17/78] MdeModulePkg/Core/PiSmmCore: Fix various
> typos
> 
> From: Antoine Coeur <coeur@gmx.fr>
> 
> Fix various typos in comments and documentation.

Reviewed-by: Hao A Wu <hao.a.wu@intel.com>

Best Regards,
Hao Wu


> 
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Hao A Wu <hao.a.wu@intel.com>
> Signed-off-by: Antoine Coeur <coeur@gmx.fr>
> Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
> Signed-off-by: Philippe Mathieu-Daude <philmd@redhat.com>
> ---
>  MdeModulePkg/Core/PiSmmCore/PiSmmIpl.inf      | 10 ++++----
>  MdeModulePkg/Core/PiSmmCore/HeapGuard.h       |  2 +-
>  MdeModulePkg/Core/PiSmmCore/PiSmmCore.h       | 12 +++++-----
>  .../Core/PiSmmCore/PiSmmCorePrivateData.h     |  6 ++---
>  MdeModulePkg/Core/PiSmmCore/Dependency.c      |  4 ++--
>  MdeModulePkg/Core/PiSmmCore/Dispatcher.c      | 24 +++++++++----------
>  MdeModulePkg/Core/PiSmmCore/HeapGuard.c       |  4 ++--
>  MdeModulePkg/Core/PiSmmCore/Locate.c          |  8 +++----
>  .../Core/PiSmmCore/MemoryAttributesTable.c    |  8 +++----
>  MdeModulePkg/Core/PiSmmCore/Page.c            |  4 ++--
>  MdeModulePkg/Core/PiSmmCore/PiSmmCore.c       | 10 ++++----
>  MdeModulePkg/Core/PiSmmCore/PiSmmIpl.c        |  8 +++----
>  MdeModulePkg/Core/PiSmmCore/Smi.c             |  2 +-
>  .../Core/PiSmmCore/SmramProfileRecord.c       |  4 ++--
>  14 files changed, 53 insertions(+), 53 deletions(-)
> 
> diff --git a/MdeModulePkg/Core/PiSmmCore/PiSmmIpl.inf
> b/MdeModulePkg/Core/PiSmmCore/PiSmmIpl.inf
> index b6b1bbcdac51..619603d6c2a0 100644
> --- a/MdeModulePkg/Core/PiSmmCore/PiSmmIpl.inf
> +++ b/MdeModulePkg/Core/PiSmmCore/PiSmmIpl.inf
> @@ -57,23 +57,23 @@ [Protocols]
>    gEfiSmmControl2ProtocolGuid                   ## CONSUMES
>    ## NOTIFY
>    ## SOMETIMES_CONSUMES
> -  ## UNDEFINED # Used to do smm communcation
> +  ## UNDEFINED # Used to do smm communication
>    gEfiDxeSmmReadyToLockProtocolGuid
>    gEfiCpuArchProtocolGuid                       ## SOMETIMES_CONSUMES
> 
>  [Guids]
>    ## CONSUMES           ## Event
> -  ## PRODUCES           ## UNDEFINED # Used to do smm communcation
> +  ## PRODUCES           ## UNDEFINED # Used to do smm communication
>    gEfiEventDxeDispatchGuid
>    gEfiEventReadyToBootGuid                      ## CONSUMES             ## Event
>    ## SOMETIMES_CONSUMES ## Event
> -  ## SOMETIMES_PRODUCES ## UNDEFINED # Used to do smm
> communcation
> +  ## SOMETIMES_PRODUCES ## UNDEFINED # Used to do smm
> communication
>    gEfiEventLegacyBootGuid
>    ## SOMETIMES_CONSUMES ## Event
> -  ## SOMETIMES_PRODUCES ## UNDEFINED # Used to do smm
> communcation
> +  ## SOMETIMES_PRODUCES ## UNDEFINED # Used to do smm
> communication
>    gEfiEventExitBootServicesGuid
>    ## SOMETIMES_CONSUMES ## Event
> -  ## SOMETIMES_PRODUCES ## UNDEFINED # Used to do smm
> communcation
> +  ## SOMETIMES_PRODUCES ## UNDEFINED # Used to do smm
> communication
>    gEfiEventReadyToBootGuid
>    gEfiEventVirtualAddressChangeGuid             ## CONSUMES             ## Event
>    gEfiEndOfDxeEventGroupGuid                    ## CONSUMES             ## Event
> diff --git a/MdeModulePkg/Core/PiSmmCore/HeapGuard.h
> b/MdeModulePkg/Core/PiSmmCore/HeapGuard.h
> index 9077db1a8496..1b5c0f2a4f57 100644
> --- a/MdeModulePkg/Core/PiSmmCore/HeapGuard.h
> +++ b/MdeModulePkg/Core/PiSmmCore/HeapGuard.h
> @@ -39,7 +39,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
>  //
>  // For a normal configuration of system with 4G memory, two levels of
> tables
>  // can track the whole memory, because two levels (L3+L4) of map tables
> have
> -// already coverred 37-bit of memory address. And for a normal UEFI BIOS,
> +// already covered 37-bit of memory address. And for a normal UEFI BIOS,
>  // less than 128M memory would be consumed during boot. That means we
> just
>  // need
>  //
> diff --git a/MdeModulePkg/Core/PiSmmCore/PiSmmCore.h
> b/MdeModulePkg/Core/PiSmmCore/PiSmmCore.h
> index 0908e7f4e9e7..50a7fc0000cb 100644
> --- a/MdeModulePkg/Core/PiSmmCore/PiSmmCore.h
> +++ b/MdeModulePkg/Core/PiSmmCore/PiSmmCore.h
> @@ -171,7 +171,7 @@ typedef struct {
>    EFI_GUID            ProtocolID;
>    /// All protocol interfaces
>    LIST_ENTRY          Protocols;
> -  /// Registerd notification handlers
> +  /// Registered notification handlers
>    LIST_ENTRY          Notify;
>  } PROTOCOL_ENTRY;
> 
> @@ -562,7 +562,7 @@ SmmLocateHandle (
>  /**
>    Return the first Protocol Interface that matches the Protocol GUID. If
>    Registration is pasased in return a Protocol Instance that was just add
> -  to the system. If Retistration is NULL return the first Protocol Interface
> +  to the system. If Registration is NULL return the first Protocol Interface
>    you find.
> 
>    @param  Protocol               The protocol to search for
> @@ -602,7 +602,7 @@ SmmLocateProtocol (
>    @retval EFI_NOT_FOUND          No handles match the search.
>    @retval EFI_OUT_OF_RESOURCES   There is not enough pool memory to
> store the
>                                   matching results.
> -  @retval EFI_INVALID_PARAMETER  One or more paramters are not valid.
> +  @retval EFI_INVALID_PARAMETER  One or more parameters are not valid.
> 
>  **/
>  EFI_STATUS
> @@ -641,7 +641,7 @@ SmiManage (
>  /**
>    Registers a handler to execute within SMM.
> 
> -  @param  Handler        Handler service funtion pointer.
> +  @param  Handler        Handler service function pointer.
>    @param  HandlerType    Points to the handler type or NULL for root SMI
> handlers.
>    @param  DispatchHandle On return, contains a unique handle which can be
> used to later unregister the handler function.
> 
> @@ -873,12 +873,12 @@ SmmEfiNotAvailableYetArg5 (
>    );
> 
>  //
> -//Functions used during debug buils
> +//Functions used during debug builds
>  //
> 
>  /**
>    Traverse the discovered list for any drivers that were discovered but not
> loaded
> -  because the dependency experessions evaluated to false.
> +  because the dependency expressions evaluated to false.
> 
>  **/
>  VOID
> diff --git a/MdeModulePkg/Core/PiSmmCore/PiSmmCorePrivateData.h
> b/MdeModulePkg/Core/PiSmmCore/PiSmmCorePrivateData.h
> index 1d8af6f12767..28f95d9b024b 100644
> --- a/MdeModulePkg/Core/PiSmmCore/PiSmmCorePrivateData.h
> +++ b/MdeModulePkg/Core/PiSmmCore/PiSmmCorePrivateData.h
> @@ -65,7 +65,7 @@ typedef struct {
> 
>    ///
>    /// The SMM Foundation Entry Point.  The SMM Core fills in this field when
> the
> -  /// SMM Core is initialized.  The SMM IPL is responsbile for registering this
> entry
> +  /// SMM Core is initialized.  The SMM IPL is responsible for registering this
> entry
>    /// point with the SMM Configuration Protocol.  The SMM Configuration
> Protocol may
>    /// not be available at the time the SMM IPL and SMM Core are started, so
> the SMM IPL
>    /// sets up a protocol notification on the SMM Configuration Protocol and
> registers
> @@ -92,14 +92,14 @@ typedef struct {
>    EFI_SMM_SYSTEM_TABLE2           *Smst;
> 
>    ///
> -  /// This field is used by the SMM Communicatioon Protocol to pass a buffer
> into
> +  /// This field is used by the SMM Communication Protocol to pass a buffer
> into
>    /// a software SMI handler and for the software SMI handler to pass a
> buffer back to
>    /// the caller of the SMM Communication Protocol.
>    ///
>    VOID                            *CommunicationBuffer;
> 
>    ///
> -  /// This field is used by the SMM Communicatioon Protocol to pass the size
> of a buffer,
> +  /// This field is used by the SMM Communication Protocol to pass the size
> of a buffer,
>    /// in bytes, into a software SMI handler and for the software SMI handler
> to pass the
>    /// size, in bytes, of a buffer back to the caller of the SMM Communication
> Protocol.
>    ///
> diff --git a/MdeModulePkg/Core/PiSmmCore/Dependency.c
> b/MdeModulePkg/Core/PiSmmCore/Dependency.c
> index dfd4537f846a..1167807b151b 100644
> --- a/MdeModulePkg/Core/PiSmmCore/Dependency.c
> +++ b/MdeModulePkg/Core/PiSmmCore/Dependency.c
> @@ -192,7 +192,7 @@ SmmIsSchedulable (
>    if (DriverEntry->Depex == NULL) {
>      //
>      // A NULL Depex means that the SMM driver is not built correctly.
> -    // All SMM drivers must have a valid depex expressiion.
> +    // All SMM drivers must have a valid depex expression.
>      //
>      DEBUG ((DEBUG_DISPATCH, "  RESULT = FALSE (Depex is empty)\n"));
>      ASSERT (FALSE);
> @@ -371,7 +371,7 @@ SmmIsSchedulable (
>      // The math is done out of order, but it should not matter. That is
>      // we may add in the sizeof (EFI_GUID) before we account for the OP
> Code.
>      // This is not an issue, since we just need the correct end result. You
> -    // need to be careful using Iterator in the loop as it's intermediate value
> +    // need to be careful using Iterator in the loop as its intermediate value
>      // may be strange.
>      //
>      Iterator++;
> diff --git a/MdeModulePkg/Core/PiSmmCore/Dispatcher.c
> b/MdeModulePkg/Core/PiSmmCore/Dispatcher.c
> index e5a160ed0b92..9bec731e5312 100644
> --- a/MdeModulePkg/Core/PiSmmCore/Dispatcher.c
> +++ b/MdeModulePkg/Core/PiSmmCore/Dispatcher.c
> @@ -17,7 +17,7 @@
>              and After dependencies. This is done recursively as the call to add
>              to the mScheduledQueue checks for Before and recursively adds
>              all Befores. It then addes the item that was passed in and then
> -            processess the After dependecies by recursively calling the routine.
> +            processes the After dependencies by recursively calling the routine.
> 
>    Dispatcher Rules:
>    The rules for the dispatcher are similar to the DXE dispatcher.
> @@ -25,7 +25,7 @@
>    The rules for DXE dispatcher are in chapter 10 of the DXE CIS. Figure 10-3
>    is the state diagram for the DXE dispatcher
> 
> -  Depex - Dependency Expresion.
> +  Depex - Dependency Expression.
> 
>    Copyright (c) 2014, Hewlett-Packard Development Company, L.P.
>    Copyright (c) 2009 - 2018, Intel Corporation. All rights reserved.<BR>
> @@ -83,12 +83,12 @@ LIST_ENTRY  mScheduledQueue =
> INITIALIZE_LIST_HEAD_VARIABLE (mScheduledQueue);
>  LIST_ENTRY  mFvHandleList = INITIALIZE_LIST_HEAD_VARIABLE
> (mFvHandleList);
> 
>  //
> -// Flag for the SMM Dispacher.  TRUE if dispatcher is execuing.
> +// Flag for the SMM Dispatcher.  TRUE if dispatcher is executing.
>  //
>  BOOLEAN  gDispatcherRunning = FALSE;
> 
>  //
> -// Flag for the SMM Dispacher.  TRUE if there is one or more SMM drivers
> ready to be dispatched
> +// Flag for the SMM Dispatcher.  TRUE if there is one or more SMM drivers
> ready to be dispatched
>  //
>  BOOLEAN  gRequestDispatch = FALSE;
> 
> @@ -175,7 +175,7 @@ CheckAndMarkFixLoadingMemoryUsageBitMap (
>       return EFI_NOT_FOUND;
>     }
>     //
> -   // Test if the memory is avalaible or not.
> +   // Test if the memory is available or not.
>     //
>     BaseOffsetPageNumber = EFI_SIZE_TO_PAGES((UINT32)(ImageBase -
> SmmCodeBase));
>     TopOffsetPageNumber  = EFI_SIZE_TO_PAGES((UINT32)(ImageBase +
> ImageSize - SmmCodeBase));
> @@ -458,7 +458,7 @@ SmmLoadImage (
>      Status = GetPeCoffImageFixLoadingAssignedAddress (&ImageContext);
>      if (!EFI_ERROR (Status)) {
>        //
> -      // Since the memory range to load Smm core alreay been cut out, so no
> need to allocate and free this range
> +      // Since the memory range to load Smm core already been cut out, so
> no need to allocate and free this range
>        // following statements is to bypass SmmFreePages
>        //
>        PageCount = 0;
> @@ -664,7 +664,7 @@ SmmLoadImage (
>        //
>        // Copy the PDB file name to our temporary string, and replace .pdb
> with .efi
>        // The PDB file name is limited in the range of 0~255.
> -      // If the length is bigger than 255, trim the redudant characters to avoid
> overflow in array boundary.
> +      // If the length is bigger than 255, trim the redundant characters to
> avoid overflow in array boundary.
>        //
>        for (Index = 0; Index < sizeof (EfiFileName) - 4; Index++) {
>          EfiFileName[Index] = ImageContext.PdbPointer[Index + StartIndex];
> @@ -741,7 +741,7 @@ SmmPreProcessDepex (
> 
>    @param  DriverEntry           Driver to work on.
> 
> -  @retval EFI_SUCCESS           Depex read and preprossesed
> +  @retval EFI_SUCCESS           Depex read and preprocessed
>    @retval EFI_PROTOCOL_ERROR    The section extraction protocol returned
> an error
>                                  and  Depex reading needs to be retried.
>    @retval Error                 DEPEX not found.
> @@ -1093,8 +1093,8 @@ FvHasBeenProcessed (
>  }
> 
>  /**
> -  Remember that Fv protocol on FvHandle has had it's drivers placed on the
> -  mDiscoveredList. This fucntion adds entries on the mFvHandleList. Items
> are
> +  Remember that Fv protocol on FvHandle has had its drivers placed on the
> +  mDiscoveredList. This function adds entries on the mFvHandleList. Items
> are
>    never removed/freed from the mFvHandleList.
> 
>    @param  FvHandle              The handle of a FV that has been processed
> @@ -1165,7 +1165,7 @@ SmmFvToDevicePath (
> 
>  /**
>    Add an entry to the mDiscoveredList. Allocate memory to store the
> DriverEntry,
> -  and initilize any state variables. Read the Depex from the FV and store it
> +  and initialize any state variables. Read the Depex from the FV and store it
>    in DriverEntry. Pre-process the Depex to set the Before and After state.
>    The Discovered list is never free'ed and contains booleans that represent
> the
>    other possible SMM driver states.
> @@ -1473,7 +1473,7 @@ SmmDriverDispatchHandler (
> 
>  /**
>    Traverse the discovered list for any drivers that were discovered but not
> loaded
> -  because the dependency experessions evaluated to false.
> +  because the dependency expressions evaluated to false.
> 
>  **/
>  VOID
> diff --git a/MdeModulePkg/Core/PiSmmCore/HeapGuard.c
> b/MdeModulePkg/Core/PiSmmCore/HeapGuard.c
> index 29cd00f3897d..b0d0f72044a3 100644
> --- a/MdeModulePkg/Core/PiSmmCore/HeapGuard.c
> +++ b/MdeModulePkg/Core/PiSmmCore/HeapGuard.c
> @@ -497,7 +497,7 @@ IsMemoryGuarded (
>  /**
>    Set the page at the given address to be a Guard page.
> 
> -  This is done by changing the page table attribute to be NOT PRSENT.
> +  This is done by changing the page table attribute to be NOT PRESENT.
> 
>    @param[in]  BaseAddress     Page address to Guard at.
> 
> @@ -527,7 +527,7 @@ SetGuardPage (
>  /**
>    Unset the Guard page at the given address to the normal memory.
> 
> -  This is done by changing the page table attribute to be PRSENT.
> +  This is done by changing the page table attribute to be PRESENT.
> 
>    @param[in]  BaseAddress     Page address to Guard at.
> 
> diff --git a/MdeModulePkg/Core/PiSmmCore/Locate.c
> b/MdeModulePkg/Core/PiSmmCore/Locate.c
> index 85c6873fafe2..8458199ec86c 100644
> --- a/MdeModulePkg/Core/PiSmmCore/Locate.c
> +++ b/MdeModulePkg/Core/PiSmmCore/Locate.c
> @@ -34,7 +34,7 @@ IHANDLE *
>  /**
>    Routine to get the next Handle, when you are searching for all handles.
> 
> -  @param  Position               Information about which Handle to seach for.
> +  @param  Position               Information about which Handle to search for.
>    @param  Interface              Return the interface structure for the matching
>                                   protocol.
> 
> @@ -70,7 +70,7 @@ SmmGetNextLocateAllHandles (
>    Routine to get the next Handle, when you are searching for register
> protocol
>    notifies.
> 
> -  @param  Position               Information about which Handle to seach for.
> +  @param  Position               Information about which Handle to search for.
>    @param  Interface              Return the interface structure for the matching
>                                   protocol.
> 
> @@ -116,7 +116,7 @@ SmmGetNextLocateByRegisterNotify (
>  /**
>    Routine to get the next Handle, when you are searching for a given
> protocol.
> 
> -  @param  Position               Information about which Handle to seach for.
> +  @param  Position               Information about which Handle to search for.
>    @param  Interface              Return the interface structure for the matching
>                                   protocol.
> 
> @@ -173,7 +173,7 @@ SmmGetNextLocateByProtocol (
>  /**
>    Return the first Protocol Interface that matches the Protocol GUID. If
>    Registration is pasased in return a Protocol Instance that was just add
> -  to the system. If Retistration is NULL return the first Protocol Interface
> +  to the system. If Registration is NULL return the first Protocol Interface
>    you find.
> 
>    @param  Protocol               The protocol to search for
> diff --git a/MdeModulePkg/Core/PiSmmCore/MemoryAttributesTable.c
> b/MdeModulePkg/Core/PiSmmCore/MemoryAttributesTable.c
> index d6123da3ad1a..de8262ecb9f9 100644
> --- a/MdeModulePkg/Core/PiSmmCore/MemoryAttributesTable.c
> +++ b/MdeModulePkg/Core/PiSmmCore/MemoryAttributesTable.c
> @@ -152,7 +152,7 @@ SortMemoryMap (
>  }
> 
>  /**
> -  Merge continous memory map entries whose have same attributes.
> +  Merge continuous memory map entries whose have same attributes.
> 
>    @param[in, out]  MemoryMap              A pointer to the buffer in which
> firmware places
>                                            the current memory map.
> @@ -300,7 +300,7 @@ GetImageRecordByAddress (
>    @param[in]       ImageRecord            An image record whose [ImageBase,
> ImageSize] covered
>                                            by old memory map entry.
>    @param[in, out]  NewRecord              A pointer to several new memory map
> entries.
> -                                          The caller gurantee the buffer size be 1 +
> +                                          The caller guarantee the buffer size be 1 +
>                                            (SplitRecordCount * DescriptorSize) calculated
>                                            below.
>    @param[in]       OldRecord              A pointer to one old memory map entry.
> @@ -450,7 +450,7 @@ GetMaxSplitRecordCount (
> 
>    @param[in]       OldRecord              A pointer to one old memory map entry.
>    @param[in, out]  NewRecord              A pointer to several new memory map
> entries.
> -                                          The caller gurantee the buffer size be 1 +
> +                                          The caller guarantee the buffer size be 1 +
>                                            (SplitRecordCount * DescriptorSize) calculated
>                                            below.
>    @param[in]       MaxSplitRecordCount    The max number of splitted entries
> @@ -667,7 +667,7 @@ SplitTable (
>    This function for GetMemoryMap() with memory attributes table.
> 
>    It calls original GetMemoryMap() to get the original memory map
> information. Then
> -  plus the additional memory map entries for PE Code/Data seperation.
> +  plus the additional memory map entries for PE Code/Data separation.
> 
>    @param[in, out]  MemoryMapSize          A pointer to the size, in bytes, of
> the
>                                            MemoryMap buffer. On input, this is the size of
> diff --git a/MdeModulePkg/Core/PiSmmCore/Page.c
> b/MdeModulePkg/Core/PiSmmCore/Page.c
> index 1f05bddcc0b8..d886187d9a4a 100644
> --- a/MdeModulePkg/Core/PiSmmCore/Page.c
> +++ b/MdeModulePkg/Core/PiSmmCore/Page.c
> @@ -83,7 +83,7 @@ SmmInternalAllocatePagesEx (
>    Please Note this algorithm to allocate the memory map descriptor has a
> property
>    that the memory allocated for memory entries always grows, and will
> never really be freed.
> 
> -  @return The Memory map descriptor dequed from the
> mFreeMemoryMapEntryList
> +  @return The Memory map descriptor dequeued from the
> mFreeMemoryMapEntryList
> 
>  **/
>  MEMORY_MAP *
> @@ -117,7 +117,7 @@ AllocateMemoryMapEntry (
>        FreeDescriptorEntries = (MEMORY_MAP *)(UINTN)Mem;
>        //DEBUG((DEBUG_INFO, "New FreeDescriptorEntries - 0x%x\n",
> FreeDescriptorEntries));
>        //
> -      // Enque the free memmory map entries into the list
> +      // Enqueue the free memory map entries into the list
>        //
>        for (Index = 0; Index< RUNTIME_PAGE_ALLOCATION_GRANULARITY /
> sizeof(MEMORY_MAP); Index++) {
>          FreeDescriptorEntries[Index].Signature = MEMORY_MAP_SIGNATURE;
> diff --git a/MdeModulePkg/Core/PiSmmCore/PiSmmCore.c
> b/MdeModulePkg/Core/PiSmmCore/PiSmmCore.c
> index b5676f21bf26..cfa9922cbdb5 100644
> --- a/MdeModulePkg/Core/PiSmmCore/PiSmmCore.c
> +++ b/MdeModulePkg/Core/PiSmmCore/PiSmmCore.c
> @@ -373,7 +373,7 @@ SmmReadyToLockHandler (
>               );
> 
>    //
> -  // Make sure SMM CPU I/O 2 Procol has been installed into the handle
> database
> +  // Make sure SMM CPU I/O 2 Protocol has been installed into the handle
> database
>    //
>    Status = SmmLocateProtocol (&gEfiSmmCpuIo2ProtocolGuid, NULL,
> &Interface);
> 
> @@ -586,7 +586,7 @@ SmmEndOfS3ResumeHandler (
>    ASSERT_EFI_ERROR (Status);
> 
>    //
> -  // Uninstall the protocol here because the comsumer just hook the
> +  // Uninstall the protocol here because the consumer just hook the
>    // installation event.
>    //
>    Status = SmmUninstallProtocolInterface (
> @@ -673,7 +673,7 @@ SmmEntryPoint (
>    SmmEntryPointMemoryManagementHook ();
> 
>    //
> -  // If a legacy boot has occured, then make sure gSmmCorePrivate is not
> accessed
> +  // If a legacy boot has occurred, then make sure gSmmCorePrivate is not
> accessed
>    //
>    InLegacyBoot = mInLegacyBoot;
>    if (!InLegacyBoot) {
> @@ -737,7 +737,7 @@ SmmEntryPoint (
>    PlatformHookAfterSmmDispatch ();
> 
>    //
> -  // If a legacy boot has occured, then make sure gSmmCorePrivate is not
> accessed
> +  // If a legacy boot has occurred, then make sure gSmmCorePrivate is not
> accessed
>    //
>    if (!InLegacyBoot) {
>      //
> @@ -867,7 +867,7 @@ SmmMain (
>    //
>    // No need to initialize memory service.
>    // It is done in constructor of PiSmmCoreMemoryAllocationLib(),
> -  // so that the library linked with PiSmmCore can use AllocatePool() in
> constuctor.
> +  // so that the library linked with PiSmmCore can use AllocatePool() in
> constructor.
>    //
> 
>    SmramProfileInit ();
> diff --git a/MdeModulePkg/Core/PiSmmCore/PiSmmIpl.c
> b/MdeModulePkg/Core/PiSmmCore/PiSmmIpl.c
> index 1cf8c93227a3..20b84eaee277 100644
> --- a/MdeModulePkg/Core/PiSmmCore/PiSmmIpl.c
> +++ b/MdeModulePkg/Core/PiSmmCore/PiSmmIpl.c
> @@ -707,7 +707,7 @@ SmmIplSmmConfigurationEventNotify (
>    }
> 
>    //
> -  // Register the SMM Entry Point provided by the SMM Core with the SMM
> COnfiguration protocol
> +  // Register the SMM Entry Point provided by the SMM Core with the SMM
> Configuration protocol
>    //
>    Status = SmmConfiguration->RegisterSmmEntry (SmmConfiguration,
> gSmmCorePrivate->SmmEntryPoint);
>    ASSERT_EFI_ERROR (Status);
> @@ -964,7 +964,7 @@ ExecuteSmmCoreFromSmram (
>    }
> 
>    //
> -  // Initilize ImageContext
> +  // Initialize ImageContext
>    //
>    ImageContext.Handle    = SourceBuffer;
>    ImageContext.ImageRead = PeCoffLoaderImageReadFromMemory;
> @@ -1082,7 +1082,7 @@ ExecuteSmmCoreFromSmram (
>    }
> 
>    //
> -  // Always free memory allocted by GetFileBufferByFilePath ()
> +  // Always free memory allocated by GetFileBufferByFilePath ()
>    //
>    FreePool (SourceBuffer);
> 
> @@ -1763,7 +1763,7 @@ SmmIplEntry (
>    ASSERT_EFI_ERROR (Status);
> 
>    //
> -  // Create the set of protocol and event notififcations that the SMM IPL
> requires
> +  // Create the set of protocol and event notifications that the SMM IPL
> requires
>    //
>    for (Index = 0; mSmmIplEvents[Index].NotifyFunction != NULL; Index++) {
>      if (mSmmIplEvents[Index].Protocol) {
> diff --git a/MdeModulePkg/Core/PiSmmCore/Smi.c
> b/MdeModulePkg/Core/PiSmmCore/Smi.c
> index 488af6754faf..aeefb392f7af 100644
> --- a/MdeModulePkg/Core/PiSmmCore/Smi.c
> +++ b/MdeModulePkg/Core/PiSmmCore/Smi.c
> @@ -196,7 +196,7 @@ SmiManage (
>  /**
>    Registers a handler to execute within SMM.
> 
> -  @param  Handler        Handler service funtion pointer.
> +  @param  Handler        Handler service function pointer.
>    @param  HandlerType    Points to the handler type or NULL for root SMI
> handlers.
>    @param  DispatchHandle On return, contains a unique handle which can be
> used to later unregister the handler function.
> 
> diff --git a/MdeModulePkg/Core/PiSmmCore/SmramProfileRecord.c
> b/MdeModulePkg/Core/PiSmmCore/SmramProfileRecord.c
> index 49c4a3758fdd..1b302c810cc9 100644
> --- a/MdeModulePkg/Core/PiSmmCore/SmramProfileRecord.c
> +++ b/MdeModulePkg/Core/PiSmmCore/SmramProfileRecord.c
> @@ -78,7 +78,7 @@ GLOBAL_REMOVE_IF_UNREFERENCED
> EFI_DEVICE_PATH_PROTOCOL *mSmramProfileDriverPath;
>  GLOBAL_REMOVE_IF_UNREFERENCED UINTN
> mSmramProfileDriverPathSize;
> 
>  /**
> -  Dump SMRAM infromation.
> +  Dump SMRAM information.
> 
>  **/
>  VOID
> @@ -2797,7 +2797,7 @@ DumpSmramProfile (
>  }
> 
>  /**
> -  Dump SMRAM infromation.
> +  Dump SMRAM information.
> 
>  **/
>  VOID
> --
> 2.21.0


  reply	other threads:[~2020-02-07  0:26 UTC|newest]

Thread overview: 122+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-03  9:06 [PATCH v2 00/78] Fix a bunch of typos (part 1) Philippe Mathieu-Daudé
2020-01-03  9:06 ` [PATCH v2 01/78] CryptoPkg/OpensslLib: Fix few typos Philippe Mathieu-Daudé
2020-01-06  2:39   ` Wang, Jian J
2020-01-03  9:06 ` [PATCH v2 02/78] EmbeddedPkg/VirtualKeyboard: Fix a typo in EFI_INVALID_PARAMETER Philippe Mathieu-Daudé
2020-01-08 12:41   ` Ard Biesheuvel
2020-01-03  9:06 ` [PATCH v2 03/78] EmbeddedPkg/VirtualKeyboard: Fix few typos Philippe Mathieu-Daudé
2020-01-08 12:42   ` Ard Biesheuvel
2020-01-08 14:26     ` Philippe Mathieu-Daudé
2020-01-03  9:06 ` [PATCH v2 04/78] EmulatorPkg/Sec: Fix various typos Philippe Mathieu-Daudé
2020-01-03  9:06 ` [PATCH v2 05/78] EmulatorPkg/Unix: " Philippe Mathieu-Daudé
2020-01-03  9:07 ` [PATCH v2 06/78] EmulatorPkg/Win: " Philippe Mathieu-Daudé
2020-01-03  9:07 ` [PATCH v2 07/78] FatPkg/EnhancedFatDxe: " Philippe Mathieu-Daudé
2020-01-03  9:07 ` [PATCH v2 08/78] FatPkg/FatPei: Fix few typos Philippe Mathieu-Daudé
2020-01-03  9:07 ` [PATCH v2 09/78] MdeModulePkg/Application: Improve French translation Philippe Mathieu-Daudé
2020-02-07  0:49   ` Philippe Mathieu-Daudé
2020-02-07  0:53   ` [edk2-devel] " Wu, Hao A
2020-02-07  0:55     ` Philippe Mathieu-Daudé
2020-01-03  9:07 ` [PATCH v2 10/78] MdeModulePkg/Application: Fix various typos Philippe Mathieu-Daudé
2020-02-07  0:26   ` [edk2-devel] " Wu, Hao A
2020-01-03  9:07 ` [PATCH v2 11/78] MdeModulePkg/Bus/Ata: " Philippe Mathieu-Daudé
2020-01-03  9:07 ` [PATCH v2 12/78] MdeModulePkg/Bus/I2c: Fix few typos Philippe Mathieu-Daudé
2020-01-03  9:07 ` [PATCH v2 13/78] MdeModulePkg/Bus/Isa: Fix various typos Philippe Mathieu-Daudé
2020-01-03  9:07 ` [PATCH v2 14/78] MdeModulePkg/Bus/Scsi: " Philippe Mathieu-Daudé
2020-01-03  9:07 ` [PATCH v2 15/78] MdeModulePkg/Bus/Sd: " Philippe Mathieu-Daudé
2020-01-03  9:07 ` [PATCH v2 16/78] MdeModulePkg/Core/Pei: " Philippe Mathieu-Daudé
2020-02-07  0:26   ` Wu, Hao A
2020-01-03  9:07 ` [PATCH v2 17/78] MdeModulePkg/Core/PiSmmCore: " Philippe Mathieu-Daudé
2020-02-07  0:26   ` Wu, Hao A [this message]
2020-01-03  9:07 ` [PATCH v2 18/78] MdeModulePkg/UsbBusDxe: Fix a typo Philippe Mathieu-Daudé
2020-01-03  9:07 ` [PATCH v2 19/78] MdeModulePkg/UsbMass: Fix various typos Philippe Mathieu-Daudé
2020-01-03  9:07 ` [PATCH v2 20/78] MdeModulePkg/UsbMouse: Fix few typos Philippe Mathieu-Daudé
2020-01-03  9:07 ` [PATCH v2 21/78] MdeModulePkg/UsbBus: Fix various typos Philippe Mathieu-Daudé
2020-01-03  9:07 ` [PATCH v2 22/78] MdeModulePkg/Usb: " Philippe Mathieu-Daudé
2020-01-03  9:07 ` [PATCH v2 23/78] MdePkg/IndustryStandard: " Philippe Mathieu-Daudé
2020-01-06  3:32   ` Liming Gao
2020-01-03  9:07 ` [PATCH v2 24/78] MdePkg/Library/Dxe: " Philippe Mathieu-Daudé
2020-01-06  3:35   ` Liming Gao
2020-01-03  9:07 ` [PATCH v2 25/78] MdePkg/Library/Pci: " Philippe Mathieu-Daudé
2020-01-06  3:35   ` [edk2-devel] " Liming Gao
2020-01-03  9:07 ` [PATCH v2 26/78] MdePkg/Library/Smm: " Philippe Mathieu-Daudé
2020-01-06  3:35   ` Liming Gao
2020-01-03  9:07 ` [PATCH v2 27/78] MdePkg/Ppi: " Philippe Mathieu-Daudé
2020-01-06  3:36   ` [edk2-devel] " Liming Gao
2020-01-03  9:07 ` [PATCH v2 28/78] MdePkg/Register: " Philippe Mathieu-Daudé
2020-01-06  3:38   ` Liming Gao
2020-01-03  9:07 ` [PATCH v2 29/78] NetworkPkg: Fix a typo Philippe Mathieu-Daudé
2020-01-03  9:07 ` [PATCH v2 30/78] NetworkPkg/ArpDxe: Fix various typos Philippe Mathieu-Daudé
2020-01-03  9:07 ` [PATCH v2 31/78] NetworkPkg/Dhcp4Dxe: " Philippe Mathieu-Daudé
2020-01-03  9:07 ` [PATCH v2 32/78] NetworkPkg/Dhcp6Dxe: " Philippe Mathieu-Daudé
2020-01-03  9:07 ` [PATCH v2 33/78] NetworkPkg/DnsDxe: Fix a typo Philippe Mathieu-Daudé
2020-01-03  9:07 ` [PATCH v2 34/78] NetworkPkg/DnsDxe: Fix various typos Philippe Mathieu-Daudé
2020-01-03  9:07 ` [PATCH v2 35/78] NetworkPkg/DpcDxe: Fix few typos Philippe Mathieu-Daudé
2020-01-03  9:07 ` [PATCH v2 36/78] NetworkPkg/HttpBootDxe: Fix a typo in variable name Philippe Mathieu-Daudé
2020-01-03  9:07 ` [PATCH v2 37/78] NetworkPkg/HttpBootDxe: Fix various typos Philippe Mathieu-Daudé
2020-01-03  9:07 ` [PATCH v2 38/78] NetworkPkg/HttpDxe: " Philippe Mathieu-Daudé
2020-01-03  9:07 ` [PATCH v2 39/78] NetworkPkg/Ip4Dxe: " Philippe Mathieu-Daudé
2020-01-03  9:07 ` [PATCH v2 40/78] NetworkPkg/Ip6Dxe: " Philippe Mathieu-Daudé
2020-01-03  9:07 ` [PATCH v2 41/78] NetworkPkg/IScsiDxe: " Philippe Mathieu-Daudé
2020-01-03  9:07 ` [PATCH v2 42/78] NetworkPkg/Library: " Philippe Mathieu-Daudé
2020-01-03  9:07 ` [PATCH v2 43/78] NetworkPkg/MnpDxe: " Philippe Mathieu-Daudé
2020-01-03  9:07 ` [PATCH v2 44/78] NetworkPkg/Mtftp4Dxe: " Philippe Mathieu-Daudé
2020-01-03  9:07 ` [PATCH v2 45/78] NetworkPkg/Mtftp6Dxe: " Philippe Mathieu-Daudé
2020-01-03  9:07 ` [PATCH v2 46/78] NetworkPkg/SnpDxe: Fix few typos Philippe Mathieu-Daudé
2020-01-03  9:07 ` [PATCH v2 47/78] NetworkPkg/TcpDxe/Sock: " Philippe Mathieu-Daudé
2020-01-03  9:07 ` [PATCH v2 48/78] NetworkPkg/TcpDxe/Tcp: Fix various typos Philippe Mathieu-Daudé
2020-01-03  9:07 ` [PATCH v2 49/78] NetworkPkg/Tls: Fix few typos Philippe Mathieu-Daudé
2020-01-03  9:07 ` [PATCH v2 50/78] NetworkPkg/Udp4Dxe: Fix various typos Philippe Mathieu-Daudé
2020-01-03  9:07 ` [PATCH v2 51/78] NetworkPkg/Udp6Dxe: " Philippe Mathieu-Daudé
2020-01-03  9:07 ` [PATCH v2 52/78] NetworkPkg/UefiPxeBcDxe: " Philippe Mathieu-Daudé
2020-01-03  9:07 ` [PATCH v2 53/78] NetworkPkg/VlanConfigDxe: Fix few typos Philippe Mathieu-Daudé
2020-01-03  9:07 ` [PATCH v2 54/78] OvmfPkg/Acpi: " Philippe Mathieu-Daudé
2020-01-03  9:07 ` [PATCH v2 55/78] OvmfPkg/Csm: Fix various typos Philippe Mathieu-Daudé
2020-01-03 13:40   ` [edk2-devel] " Laszlo Ersek
2020-01-03  9:07 ` [PATCH v2 56/78] OvmfPkg/Csm/LegacyBios: Fix a typo Philippe Mathieu-Daudé
2020-01-03 13:40   ` [edk2-devel] " Laszlo Ersek
2020-01-03  9:07 ` [PATCH v2 57/78] OvmfPkg/Qemu: Fix various typos Philippe Mathieu-Daudé
2020-01-03 13:37   ` Laszlo Ersek
2020-01-03  9:07 ` [PATCH v2 58/78] OvmfPkg/Virtio: Fix few typos Philippe Mathieu-Daudé
2020-01-03  9:07 ` [PATCH v2 59/78] OvmfPkg/Xen: Fix a typo Philippe Mathieu-Daudé
2020-01-03  9:07 ` [PATCH v2 60/78] OvmfPkg/Xen: Fix various typos Philippe Mathieu-Daudé
2020-01-03 13:42   ` [edk2-devel] " Laszlo Ersek
2020-01-06 10:36     ` Anthony PERARD
2020-01-06 16:06       ` Laszlo Ersek
2020-01-03  9:07 ` [PATCH v2 61/78] PcAtChipsetPkg: Fix few typos Philippe Mathieu-Daudé
2020-01-03  9:07 ` [PATCH v2 62/78] SecurityPkg: " Philippe Mathieu-Daudé
2020-01-03  9:56   ` [edk2-devel] " Yao, Jiewen
2020-01-03  9:07 ` [PATCH v2 63/78] SecurityPkg/Hash2DxeCrypto: " Philippe Mathieu-Daudé
2020-01-03  9:55   ` [edk2-devel] " Yao, Jiewen
2020-01-03  9:07 ` [PATCH v2 64/78] SecurityPkg/Library/Tpm: Fix various typos Philippe Mathieu-Daudé
2020-01-03  9:54   ` Yao, Jiewen
2020-01-03  9:07 ` [PATCH v2 65/78] SecurityPkg/Tcg: " Philippe Mathieu-Daudé
2020-01-03  9:56   ` [edk2-devel] " Yao, Jiewen
2020-01-03  9:08 ` [PATCH v2 66/78] SecurityPkg/VariableAuthenticated: Fix few typos Philippe Mathieu-Daudé
2020-01-03  9:56   ` Yao, Jiewen
2020-01-03  9:08 ` [PATCH v2 67/78] ShellPkg/Application: Fix various typos Philippe Mathieu-Daudé
2020-01-03  9:08 ` [PATCH v2 68/78] ShellPkg/DynamicCommand: " Philippe Mathieu-Daudé
2020-01-03  9:08 ` [PATCH v2 69/78] SignedCapsulePkg: " Philippe Mathieu-Daudé
2020-01-03  9:56   ` Yao, Jiewen
2020-01-03  9:08 ` [PATCH v2 70/78] SignedCapsulePkg/Universal: " Philippe Mathieu-Daudé
2020-01-03 12:13   ` Yao, Jiewen
2020-01-03  9:08 ` [PATCH v2 71/78] SourceLevelDebugPkg/DebugAgent: " Philippe Mathieu-Daudé
2020-01-03  9:08 ` [PATCH v2 72/78] SourceLevelDebugPkg/DebugCommunicationLib: " Philippe Mathieu-Daudé
2020-01-03  9:08 ` [PATCH v2 73/78] SourceLevelDebugPkg: Fix few typos Philippe Mathieu-Daudé
2020-01-03  9:08 ` [PATCH v2 74/78] StandaloneMmPkg: Fix a typo Philippe Mathieu-Daudé
2020-01-03 12:13   ` [edk2-devel] " Yao, Jiewen
2020-01-03  9:08 ` [PATCH v2 75/78] StandaloneMmPkg: Fix few typos Philippe Mathieu-Daudé
2020-01-03 12:14   ` Yao, Jiewen
2020-01-03  9:08 ` [PATCH v2 76/78] UefiCpuPkg/CpuDxe: " Philippe Mathieu-Daudé
2020-01-07  8:28   ` [edk2-devel] " Dong, Eric
2020-01-03  9:08 ` [PATCH v2 77/78] UefiCpuPkg/PiSmm: Fix various typos Philippe Mathieu-Daudé
2020-01-07  8:27   ` [edk2-devel] " Dong, Eric
2020-01-03  9:08 ` [PATCH v2 78/78] UefiCpuPkg/Smm: " Philippe Mathieu-Daudé
2020-01-07  8:28   ` Dong, Eric
2020-01-03 10:59 ` [PATCH v2 00/78] Fix a bunch of typos (part 1) Cœur
2020-01-07 12:44 ` [edk2-devel] " Maciej Rabeda
2020-01-17 17:13 ` Philippe Mathieu-Daudé
2020-01-19  5:14   ` [edk2-devel] " Liming Gao
2020-01-20  8:35     ` Philippe Mathieu-Daudé
2020-01-17 17:15 ` Philippe Mathieu-Daudé
2020-02-06 23:46   ` Philippe Mathieu-Daudé
2020-02-10 15:22 ` [edk2-devel] " Maciej Rabeda
2020-02-10 23:51   ` 答复: " Yao, Jiewen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=B80AF82E9BFB8E4FBD8C89DA810C6A093C9A4C72@SHSMSX104.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox