From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mx.groups.io with SMTP id smtpd.web09.6005.1581397592339463684 for ; Mon, 10 Feb 2020 21:06:32 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.65, mailfrom: hao.a.wu@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Feb 2020 21:06:31 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,427,1574150400"; d="scan'208";a="405829070" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga005.jf.intel.com with ESMTP; 10 Feb 2020 21:06:31 -0800 Received: from fmsmsx154.amr.corp.intel.com (10.18.116.70) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 10 Feb 2020 21:06:30 -0800 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by FMSMSX154.amr.corp.intel.com (10.18.116.70) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 10 Feb 2020 21:06:30 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.5]) by shsmsx102.ccr.corp.intel.com ([169.254.2.126]) with mapi id 14.03.0439.000; Tue, 11 Feb 2020 13:06:28 +0800 From: "Wu, Hao A" To: "devel@edk2.groups.io" CC: "Kubacki, Michael A" , "Kinney, Michael D" , "Dong, Eric" , "Ni, Ray" , Laszlo Ersek Subject: Re: [edk2-devel] [PATCH v1 0/2] Fix backward incompatible CPU_MP_DATA struct change Thread-Topic: [edk2-devel] [PATCH v1 0/2] Fix backward incompatible CPU_MP_DATA struct change Thread-Index: AQHV3K2kT1aejy6hp0iNsG325jpF96gNor3wgAewWQCAACVJIA== Date: Tue, 11 Feb 2020 05:06:27 +0000 Message-ID: References: <20200206052356.3672-1-hao.a.wu@intel.com> In-Reply-To: Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: hao.a.wu@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: Wu, Hao A > Sent: Tuesday, February 11, 2020 10:55 AM > To: devel@edk2.groups.io; Wu, Hao A > Cc: Kubacki, Michael A; Kinney, Michael D; Dong, Eric; Ni, Ray; Laszlo E= rsek > Subject: RE: [edk2-devel] [PATCH v1 0/2] Fix backward incompatible > CPU_MP_DATA struct change >=20 > > -----Original Message----- > > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > > Wu, Hao A > > Sent: Thursday, February 06, 2020 2:21 PM > > To: devel@edk2.groups.io > > Cc: Kubacki, Michael A; Kinney, Michael D; Dong, Eric; Ni, Ray; Laszlo= Ersek > > Subject: Re: [edk2-devel] [PATCH v1 0/2] Fix backward incompatible > > CPU_MP_DATA struct change > > > > > -----Original Message----- > > > From: Wu, Hao A > > > Sent: Thursday, February 06, 2020 1:24 PM > > > To: devel@edk2.groups.io > > > Cc: Wu, Hao A; Kubacki, Michael A; Kinney, Michael D; Dong, Eric; Ni= , Ray; > > > Laszlo Ersek > > > Subject: [PATCH v1 0/2] Fix backward incompatible CPU_MP_DATA struct > > > change > > > > > > The series will resolve a backward compatibility issue with pre-buil= t > > > binaries (e.g. FSP) introduced by commit 88bd0661661. > > > > > > The relocation of 'MicrocodePatchRegionSize' and > > 'MicrocodePatchAddress' > > > fields in structure CPU_MP_DATA may cause access issue for platforms > > that > > > use pre-built FSP binary, since the offset of these microcode relate= d > > > fields in CPU_MP_DATA can be different between PEI phase (in the pre= - > > built > > > binary) and DXE phase (in current code implementation). > > > > > > The series will use the newly introduced EDKII microcode patch HOB > > instead > > > for the DXE phase to get the information of the loaded (done in PEI = phase) > > > microcode patches data. > > > > > > Sorry, I forgot to mention that > > > > The series is also available at: > > https://github.com/hwu25/edk2/tree/patch_mpinitlib_fsp_v1 > > > > Tests done for the series: > > 1. OS boot successfully on platform (not using FSP binary) when the ED= KII > > microcode patch HOB is produced. Debug messages show that the > > microcode > > detection and application work properly. > > 2. OS boot successfully on platform (not using FSP binary) when the ED= KII > > microcode patch HOB is NOT produced. Debug messages show that the > > microcode > > detection and application work properly. > > > > Note: > > At this moment, I am not able to verify the OS boot on platform that u= ses > > pre-built FSP binary. I am seeking help to verify this case. >=20 >=20 > Additional information: > For the above note, I am able to verify that this series can resolve the= boot > issue on platforms that use pre-built FSP binaries. >=20 > Since the series has already received the R-b tags from > reviewers/maintainers, > I plan to push it soon. Thanks all. The series has been pushed via commits ccb4c38a50..348a34d984. Best Regards, Hao Wu >=20 > Best Regards, > Hao Wu >=20 >=20 > > > > Best Regards, > > Hao Wu > > > > > > > > > > Cc: Michael Kubacki > > > Cc: Michael D Kinney > > > Cc: Eric Dong > > > Cc: Ray Ni > > > Cc: Laszlo Ersek > > > > > > Hao A Wu (2): > > > Revert UefiCpuPkg/MpInitLib: Relocate microcode patch fields in > > > CPU_MP_DATA > > > UefiCpuPkg/MpInitLib: Not pass microcode info between archs in > > > CPU_MP_DATA > > > > > > UefiCpuPkg/Library/MpInitLib/DxeMpInitLib.inf | 3 +- > > > UefiCpuPkg/Library/MpInitLib/MpLib.h | 27 +++++++++++- > > > UefiCpuPkg/Library/MpInitLib/Microcode.c | 43 > > ++++++++++++++++++++ > > > UefiCpuPkg/Library/MpInitLib/MpLib.c | 20 +++++---- > > > UefiCpuPkg/Library/MpInitLib/PeiMpLib.c | 3 +- > > > 5 files changed, 82 insertions(+), 14 deletions(-) > > > > > > -- > > > 2.12.0.windows.1 > > > > > >=20