Re: [edk2-devel] [PATCH 2/3] MdeModulePkg: Issues reported by ECC in EDK2.

["Wu, Hao A" <hao.a.wu@intel.com>]

> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> GuoMinJ
> Sent: Thursday, February 13, 2020 4:34 PM
> To: devel@edk2.groups.io
> Cc: GuoMinJ
> Subject: [edk2-devel] [PATCH 2/3] MdeModulePkg: Issues reported by ECC in
> EDK2.
> 
> https://bugzilla.tianocore.org/show_bug.cgi?id=2515
> 
> Change the MdeModulePkg to match the ECC check rule


Reviewed-by: Hao A Wu <hao.a.wu@intel.com>

Best Regards,
Hao Wu


> 
> Signed-off-by: GuoMinJ <newexplorerj@gmail.com>
> ---
>  MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c | 4 ++--
>  MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c      | 2 +-
>  MdeModulePkg/MdeModulePkg.uni                         | 4 ++++
>  3 files changed, 7 insertions(+), 3 deletions(-)
> 
> diff --git a/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c
> b/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c
> index f8020f4e72..6c68a97d4e 100644
> --- a/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c
> +++ b/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c
> @@ -2071,7 +2071,7 @@ InitializeP2C (
>    PciIo->Pci.Write (PciIo, EfiPciIoWidthUint8, 0x3C, 1, &gAllZero);
>  }
> 
> -/*
> +/**
>    Authenticate the PCI device by using DeviceSecurityProtocol.
> 
>    @param PciIoDevice  PCI device.
> @@ -2079,7 +2079,7 @@ InitializeP2C (
>    @retval EFI_SUCCESS     The device passes the authentication.
>    @return not EFI_SUCCESS The device failes the authentication or
>                            unexpected error happen during authentication.
> -*/
> +**/
>  EFI_STATUS
>  AuthenticatePciDevice (
>    IN PCI_IO_DEVICE            *PciIoDevice
> diff --git a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c
> b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c
> index b05c818462..da5559ae76 100644
> --- a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c
> +++ b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c
> @@ -2200,7 +2200,7 @@ SdMmcSoftwareReset (
>    SD specification section 3.10.
> 
>    @param[in] Private    Pointer to driver private data.
> -  @param[in] Trb        Pointer to currently executing TRB.
> +  @param[in] Slot       Index of the slot for device.
>    @param[in] IntStatus  Normal interrupt status mask.
> 
>    @retval EFI_CRC_ERROR  CRC error happened during CMD execution.
> diff --git a/MdeModulePkg/MdeModulePkg.uni
> b/MdeModulePkg/MdeModulePkg.uni
> index cc18e53322..2c856ed073 100644
> --- a/MdeModulePkg/MdeModulePkg.uni
> +++ b/MdeModulePkg/MdeModulePkg.uni
> @@ -1314,3 +1314,7 @@
>                                                                                      "when the PCD is TRUE but
> CPU doesn't support 5-Level Paging."
>                                                                                      " TRUE  - 5-Level Paging will
> be enabled."
>                                                                                      " FALSE - 5-Level Paging will
> not be enabled."
> +
> +#string
> STR_gEfiMdeModulePkgTokenSpaceGuid_PcdTcgPfpMeasurementRevision_PR
> OMPT #language en-US "TCG Platform Firmware Profile revision"
> +
> +#string
> STR_gEfiMdeModulePkgTokenSpaceGuid_PcdTcgPfpMeasurementRevision_HE
> LP #language en-US "Indicates which TCG Platform Firmware Profile revision
> the EDKII firmware follows."
> --
> 2.17.1
> 
> 
>