From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mx.groups.io with SMTP id smtpd.web11.3006.1581662179152363661 for ; Thu, 13 Feb 2020 22:36:19 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.65, mailfrom: hao.a.wu@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Feb 2020 22:36:18 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,439,1574150400"; d="scan'208";a="434689368" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga006.fm.intel.com with ESMTP; 13 Feb 2020 22:36:18 -0800 Received: from shsmsx153.ccr.corp.intel.com (10.239.6.53) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 13 Feb 2020 22:36:17 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.5]) by SHSMSX153.ccr.corp.intel.com ([169.254.12.97]) with mapi id 14.03.0439.000; Fri, 14 Feb 2020 14:36:16 +0800 From: "Wu, Hao A" To: "devel@edk2.groups.io" , "newexplorerj@gmail.com" Subject: Re: [edk2-devel] [PATCH 2/3] MdeModulePkg: Issues reported by ECC in EDK2. Thread-Topic: [edk2-devel] [PATCH 2/3] MdeModulePkg: Issues reported by ECC in EDK2. Thread-Index: AQHV4khlHAtibvCfNk6QnH5HsIBIqKgaPXHg Date: Fri, 14 Feb 2020 06:36:15 +0000 Message-ID: References: <16ebd7982dcfc25c46bf933384bfcdb5f711e9a2.1581494371.git.newexplorerj@gmail.com> <8e8ee3c965fbc9ee79fc00244d1e81ff53c491ad.1581494371.git.newexplorerj@gmail.com> In-Reply-To: <8e8ee3c965fbc9ee79fc00244d1e81ff53c491ad.1581494371.git.newexplorerj@gmail.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: hao.a.wu@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > GuoMinJ > Sent: Thursday, February 13, 2020 4:34 PM > To: devel@edk2.groups.io > Cc: GuoMinJ > Subject: [edk2-devel] [PATCH 2/3] MdeModulePkg: Issues reported by ECC i= n > EDK2. >=20 > https://bugzilla.tianocore.org/show_bug.cgi?id=3D2515 >=20 > Change the MdeModulePkg to match the ECC check rule Reviewed-by: Hao A Wu Best Regards, Hao Wu >=20 > Signed-off-by: GuoMinJ > --- > MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c | 4 ++-- > MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c | 2 +- > MdeModulePkg/MdeModulePkg.uni | 4 ++++ > 3 files changed, 7 insertions(+), 3 deletions(-) >=20 > diff --git a/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c > b/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c > index f8020f4e72..6c68a97d4e 100644 > --- a/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c > +++ b/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c > @@ -2071,7 +2071,7 @@ InitializeP2C ( > PciIo->Pci.Write (PciIo, EfiPciIoWidthUint8, 0x3C, 1, &gAllZero); > } >=20 > -/* > +/** > Authenticate the PCI device by using DeviceSecurityProtocol. >=20 > @param PciIoDevice PCI device. > @@ -2079,7 +2079,7 @@ InitializeP2C ( > @retval EFI_SUCCESS The device passes the authentication. > @return not EFI_SUCCESS The device failes the authentication or > unexpected error happen during authentication= . > -*/ > +**/ > EFI_STATUS > AuthenticatePciDevice ( > IN PCI_IO_DEVICE *PciIoDevice > diff --git a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c > b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c > index b05c818462..da5559ae76 100644 > --- a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c > +++ b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c > @@ -2200,7 +2200,7 @@ SdMmcSoftwareReset ( > SD specification section 3.10. >=20 > @param[in] Private Pointer to driver private data. > - @param[in] Trb Pointer to currently executing TRB. > + @param[in] Slot Index of the slot for device. > @param[in] IntStatus Normal interrupt status mask. >=20 > @retval EFI_CRC_ERROR CRC error happened during CMD execution. > diff --git a/MdeModulePkg/MdeModulePkg.uni > b/MdeModulePkg/MdeModulePkg.uni > index cc18e53322..2c856ed073 100644 > --- a/MdeModulePkg/MdeModulePkg.uni > +++ b/MdeModulePkg/MdeModulePkg.uni > @@ -1314,3 +1314,7 @@ > = "when the PCD is TRUE but > CPU doesn't support 5-Level Paging." > = " TRUE - 5-Level Paging will > be enabled." > = " FALSE - 5-Level Paging will > not be enabled." > + > +#string > STR_gEfiMdeModulePkgTokenSpaceGuid_PcdTcgPfpMeasurementRevision_PR > OMPT #language en-US "TCG Platform Firmware Profile revision" > + > +#string > STR_gEfiMdeModulePkgTokenSpaceGuid_PcdTcgPfpMeasurementRevision_HE > LP #language en-US "Indicates which TCG Platform Firmware Profile revisi= on > the EDKII firmware follows." > -- > 2.17.1 >=20 >=20 >=20