From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mx.groups.io with SMTP id smtpd.web10.6733.1583373527662805576 for ; Wed, 04 Mar 2020 17:58:47 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.88, mailfrom: hao.a.wu@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Mar 2020 17:58:47 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,516,1574150400"; d="scan'208";a="439335880" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga005.fm.intel.com with ESMTP; 04 Mar 2020 17:58:47 -0800 Received: from fmsmsx156.amr.corp.intel.com (10.18.116.74) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 4 Mar 2020 17:58:46 -0800 Received: from shsmsx108.ccr.corp.intel.com (10.239.4.97) by fmsmsx156.amr.corp.intel.com (10.18.116.74) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 4 Mar 2020 17:58:46 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.206]) by SHSMSX108.ccr.corp.intel.com ([169.254.8.235]) with mapi id 14.03.0439.000; Thu, 5 Mar 2020 09:58:43 +0800 From: "Wu, Hao A" To: "devel@edk2.groups.io" , "Wu, Hao A" , "Albecki, Mateusz" CC: Marcin Wojtas , "Gao, Zhichao" , "Gao, Liming" Subject: Re: [edk2-devel] [PATCHv3 0/5] MdeModulePkg/SdMmcPciHcDxe: Refactor command processing Thread-Topic: [edk2-devel] [PATCHv3 0/5] MdeModulePkg/SdMmcPciHcDxe: Refactor command processing Thread-Index: AQHV7ZLuFgCMrLYm2ket/MSdXCtXC6g08bXQgARV1rA= Date: Thu, 5 Mar 2020 01:58:43 +0000 Message-ID: References: <20200227172526.5876-1-mateusz.albecki@intel.com> In-Reply-To: Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: hao.a.wu@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Wu, Hao A > Sent: Monday, March 02, 2020 3:52 PM > To: Albecki, Mateusz; devel@edk2.groups.io > Cc: Marcin Wojtas; Gao, Zhichao; Gao, Liming > Subject: Re: [edk2-devel] [PATCHv3 0/5] MdeModulePkg/SdMmcPciHcDxe: > Refactor command processing >=20 > > -----Original Message----- > > From: Albecki, Mateusz > > Sent: Friday, February 28, 2020 1:25 AM > > To: devel@edk2.groups.io > > Cc: Albecki, Mateusz; Wu, Hao A; Marcin Wojtas; Gao, Zhichao; Gao, > Liming > > Subject: [PATCHv3 0/5] MdeModulePkg/SdMmcPciHcDxe: Refactor > > command processing > > > > This patch series aims to refactor command processing to achieve > following > > > > - Trace the failing TRB packets to see what commands are failing and f= or > > what reasons > > - Get the response data even if data transfer timed out to allow easie= r > > debugging > > - Fix the PIO mode which is currently completely broken. > > > > Changes in v2: > > - Moved verbose packet prints after the command is finished to capture= the > > successfull command response > > - Fixed the debug prints > > - PIO data will be moved with width matching the alignment of the bloc= k > size. > > For majority of transfers that means UINT32 width. > > > > Changes in v3 > > - Fixed the memory map in non DMA case(PATCHv3 4/5) > > > > Tests performed: > > - Each patch in the series has passed boot from eMMC with ADMAv3 data > > transfer mode > > - SDMA based boot has been tested with the full patch series > > - PIO based boot has been tested with the full patch series > > - PIO based data transfer has been additionally tested by creating and > > modyfing a file in EFI shell > > - Tested async PIO transfer - results below > > > > Tests performed v3: > > - Booted OS in ADMA mode(V3 64bit) > > - Booted OS in PIO mode > > > > Async test results: > > After fixing memory map issue PIO works reliably in both async and syn= c > > cases on all paltforms. > > > > All tests were performed with eMMC in HS400 @200MHz clock frequency. >=20 >=20 > Tests done on my side: > A. Contents on SD card and eMMC device can be successfully accessed (Bot= h > ADMA > and PIO mode). > B. Aync RW tests pass for SD card and eMMC device (Both ADMA and PIO > mode). >=20 > So for the series, > Tested-by: Hao A Wu > Reviewed-by: Hao A Wu >=20 > I will hold and push the series AFTER the upcoming stable tag. Series has been pushed via commits 643623147a..9bfaa3da1e. Best Regards, Hao Wu >=20 > Best Regards, > Hao Wu >=20 >=20 > > > > For easier review & integration patch has been pushed here: > > Whole series: > > https://github.com/malbecki/edk2/tree/emmc_transfer_refactor > > > > Cc: Hao A Wu > > Cc: Marcin Wojtas > > Cc: Zhichao Gao > > Cc: Liming Gao > > > > > > Mateusz Albecki (5): > > MdeModulePkg/SdMmcPciHcDxe: Enhance driver traces > > MdeModulePkg/SdMmcPciHcDxe: Read response on command > completion > > MdeModulePkg/SdMmcPciHcDxe: Refactor data transfer completion > > MdeModulePkg/SdMmcPciHcDxe: Do not map memory for non DMA > > transfer > > MdeModulePkg/SdMmcPciHcDxe: Fix PIO transfer mode > > > > MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.h | 4 + > > MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c | 609 > > ++++++++++++++++----- > > 2 files changed, 478 insertions(+), 135 deletions(-) > > > > -- > > 2.14.1.windows.1 >=20 >=20 >=20