Re: [PATCH v3] UefiCpuPkg/MpInitLib DXE: Add PCD to control AP status check interval

["Wu, Hao A" <hao.a.wu@intel.com>]

> -----Original Message-----
> From: Ni, Ray
> Sent: Wednesday, March 25, 2020 11:36 AM
> To: Wu, Hao A; devel@edk2.groups.io
> Cc: Dong, Eric; Laszlo Ersek; Kinney, Michael D; Zeng, Star; Brian J . Johnson
> Subject: RE: [PATCH v3] UefiCpuPkg/MpInitLib DXE: Add PCD to control AP
> status check interval
> 
> > +  TriggerTime = EFI_TIMER_PERIOD_MICROSECONDS (
> > +                  PcdGet32 (PcdCpuApStatusCheckIntervalInMicroSeconds)
> > +                  );
> >    Status = gBS->SetTimer (
> >                    mCheckAllApsEvent,
> >                    TimerPeriodic,
> > -                  AP_CHECK_INTERVAL
> > +                  TriggerTime
> >                    );


Hi Ray,

My intention was to split the logic for easy reading.
So you suggest to avoid adding a local variable, right?

Best Regards,
Hao Wu


> >    ASSERT_EFI_ERROR (Status);
> >
> I guess you introduced TriggerTime for debugging purpose.
> But in the final patch, how about removing this local variable TriggerTime?
> 
> Thanks,
> Ray