From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mx.groups.io with SMTP id smtpd.web11.5192.1585108544866480754 for ; Tue, 24 Mar 2020 20:55:44 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.126, mailfrom: hao.a.wu@intel.com) IronPort-SDR: Bd3/mzWWz+fma3QC82Z+77LhJUbWO49v0x0q50/dqipVLNOuQUnBJb43iuTTewTO98YcRovK28 Ifa7KySKIoIw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Mar 2020 20:55:43 -0700 IronPort-SDR: qaEHzLerVIAeSXf46GECm0Ncp2gIBWmlZkeW+Oc6zO8hmmujfMPtEg9Y1zMWGkTGoCWMbAA0nS jQMhU6a/fzGQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,302,1580803200"; d="scan'208";a="357697484" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga001.fm.intel.com with ESMTP; 24 Mar 2020 20:55:43 -0700 Received: from fmsmsx154.amr.corp.intel.com (10.18.116.70) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 24 Mar 2020 20:55:43 -0700 Received: from shsmsx108.ccr.corp.intel.com (10.239.4.97) by FMSMSX154.amr.corp.intel.com (10.18.116.70) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 24 Mar 2020 20:55:43 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.206]) by SHSMSX108.ccr.corp.intel.com ([169.254.8.235]) with mapi id 14.03.0439.000; Wed, 25 Mar 2020 11:55:41 +0800 From: "Wu, Hao A" To: "Ni, Ray" , "devel@edk2.groups.io" CC: "Dong, Eric" , Laszlo Ersek , "Kinney, Michael D" , "Zeng, Star" , "Brian J . Johnson" Subject: Re: [PATCH v3] UefiCpuPkg/MpInitLib DXE: Add PCD to control AP status check interval Thread-Topic: [PATCH v3] UefiCpuPkg/MpInitLib DXE: Add PCD to control AP status check interval Thread-Index: AQHWAlNHDZO/Zgv9B0Wep/UieA5ptqhYIjqAgACLELA= Date: Wed, 25 Mar 2020 03:55:40 +0000 Message-ID: References: <20200325031244.8092-1-hao.a.wu@intel.com> <734D49CCEBEEF84792F5B80ED585239D5C4AFB97@SHSMSX104.ccr.corp.intel.com> In-Reply-To: <734D49CCEBEEF84792F5B80ED585239D5C4AFB97@SHSMSX104.ccr.corp.intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: hao.a.wu@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: Ni, Ray > Sent: Wednesday, March 25, 2020 11:36 AM > To: Wu, Hao A; devel@edk2.groups.io > Cc: Dong, Eric; Laszlo Ersek; Kinney, Michael D; Zeng, Star; Brian J . Jo= hnson > Subject: RE: [PATCH v3] UefiCpuPkg/MpInitLib DXE: Add PCD to control AP > status check interval >=20 > > + TriggerTime =3D EFI_TIMER_PERIOD_MICROSECONDS ( > > + PcdGet32 (PcdCpuApStatusCheckIntervalInMicroSeconds) > > + ); > > Status =3D gBS->SetTimer ( > > mCheckAllApsEvent, > > TimerPeriodic, > > - AP_CHECK_INTERVAL > > + TriggerTime > > ); Hi Ray, My intention was to split the logic for easy reading. So you suggest to avoid adding a local variable, right? Best Regards, Hao Wu > > ASSERT_EFI_ERROR (Status); > > > I guess you introduced TriggerTime for debugging purpose. > But in the final patch, how about removing this local variable TriggerTim= e? >=20 > Thanks, > Ray