* [PATCH] MdeModulePkg: Remove gEfiFormBrowserExProtocolGuid Protocol Guid
@ 2020-02-21 10:10 GuoMinJ
2020-03-27 0:48 ` [edk2-devel] " Wu, Hao A
0 siblings, 1 reply; 4+ messages in thread
From: GuoMinJ @ 2020-02-21 10:10 UTC (permalink / raw)
To: devel; +Cc: GuoMinJ
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2145
Replace the gEfiFormBrowserExProtocolGuid with
gEdkiiFormBrowserExProtocolGuid, remove the unnecessary declaration.
Signed-off-by: GuoMinJ <newexplorerj@gmail.com>
---
MdeModulePkg/Include/Protocol/FormBrowserEx.h | 1 -
MdeModulePkg/MdeModulePkg.ci.yaml | 1 -
MdeModulePkg/MdeModulePkg.dec | 1 -
MdePkg/MdePkg.ci.yaml | 1 -
4 files changed, 4 deletions(-)
diff --git a/MdeModulePkg/Include/Protocol/FormBrowserEx.h b/MdeModulePkg/Include/Protocol/FormBrowserEx.h
index c36aa6bdf1..e7e7cd18ab 100644
--- a/MdeModulePkg/Include/Protocol/FormBrowserEx.h
+++ b/MdeModulePkg/Include/Protocol/FormBrowserEx.h
@@ -143,7 +143,6 @@ struct _EDKII_FORM_BROWSER_EXTENSION_PROTOCOL {
SAVE_REMINDER SaveReminder;
};
-extern EFI_GUID gEfiFormBrowserExProtocolGuid;
extern EFI_GUID gEdkiiFormBrowserExProtocolGuid;
#endif
diff --git a/MdeModulePkg/MdeModulePkg.ci.yaml b/MdeModulePkg/MdeModulePkg.ci.yaml
index 3b6e747075..d8cd13b384 100644
--- a/MdeModulePkg/MdeModulePkg.ci.yaml
+++ b/MdeModulePkg/MdeModulePkg.ci.yaml
@@ -53,7 +53,6 @@
"IgnoreGuidValue": ["00000000-0000-0000-0000-000000000000"],
"IgnoreFoldersAndFiles": [],
"IgnoreDuplicates": [
- "gEdkiiFormBrowserExProtocolGuid=gEfiFormBrowserExProtocolGuid",
"gEfiPeiMmAccessPpiGuid=gPeiSmmAccessPpiGuid",
"gPeiSmmControlPpiGuid=gEfiPeiMmControlPpiGuid",
]
diff --git a/MdeModulePkg/MdeModulePkg.dec b/MdeModulePkg/MdeModulePkg.dec
index 91a3c60823..73ff177434 100644
--- a/MdeModulePkg/MdeModulePkg.dec
+++ b/MdeModulePkg/MdeModulePkg.dec
@@ -526,7 +526,6 @@
gEfiLockBoxProtocolGuid = { 0xbd445d79, 0xb7ad, 0x4f04, { 0x9a, 0xd8, 0x29, 0xbd, 0x20, 0x40, 0xeb, 0x3c }}
## Include/Protocol/FormBrowserEx.h
- gEfiFormBrowserExProtocolGuid = { 0x1f73b18d, 0x4630, 0x43c1, { 0xa1, 0xde, 0x6f, 0x80, 0x85, 0x5d, 0x7d, 0xa4 } }
gEdkiiFormBrowserExProtocolGuid = { 0x1f73b18d, 0x4630, 0x43c1, { 0xa1, 0xde, 0x6f, 0x80, 0x85, 0x5d, 0x7d, 0xa4 } }
## Include/Protocol/EbcVmTest.h
diff --git a/MdePkg/MdePkg.ci.yaml b/MdePkg/MdePkg.ci.yaml
index 88e490fcb6..3268f15354 100644
--- a/MdePkg/MdePkg.ci.yaml
+++ b/MdePkg/MdePkg.ci.yaml
@@ -81,7 +81,6 @@
"gEfiDebugPortProtocolGuid=gEfiDebugPortVariableGuid=gEfiDebugPortDevicePathGuid", ## is this a bug
"gEfiProcessorSpecificErrorSectionGuid=gEfiIa32X64ProcessorErrorSectionGuid", ## is this a bug
"gEfiSmmPeriodicTimerDispatch2ProtocolGuid=gEfiMmPeriodicTimerDispatchProtocolGuid",
- "gEdkiiFormBrowserExProtocolGuid=gEfiFormBrowserExProtocolGuid",
"gEfiPeiMmAccessPpiGuid=gPeiSmmAccessPpiGuid",
"gPeiSmmControlPpiGuid=gEfiPeiMmControlPpiGuid"
]
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [edk2-devel] [PATCH] MdeModulePkg: Remove gEfiFormBrowserExProtocolGuid Protocol Guid
@ 2020-03-26 15:00 Guomin Jiang
0 siblings, 0 replies; 4+ messages in thread
From: Guomin Jiang @ 2020-03-26 15:00 UTC (permalink / raw)
To: devel@edk2.groups.io; +Cc: Wang, Jian J, Wu, Hao A
[-- Attachment #1: Type: text/plain, Size: 3413 bytes --]
Hi Jian, Hao,
Could you please help review the change.
Thanks
-------- Original message --------
From: "GuoMinJ via Groups.Io" <newexplorerj=gmail.com@groups.io<mailto:newexplorerj=gmail.com@groups.io>>
Date: Fri, Feb 21, 2020, 6:10 PM
To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>
Cc: GuoMinJ <newexplorerj@gmail.com<mailto:newexplorerj@gmail.com>>
Subject: [edk2-devel] [PATCH] MdeModulePkg: Remove gEfiFormBrowserExProtocolGuid Protocol Guid
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2145
Replace the gEfiFormBrowserExProtocolGuid with
gEdkiiFormBrowserExProtocolGuid, remove the unnecessary declaration.
Signed-off-by: GuoMinJ <newexplorerj@gmail.com<mailto:newexplorerj@gmail.com>>
---
MdeModulePkg/Include/Protocol/FormBrowserEx.h | 1 -
MdeModulePkg/MdeModulePkg.ci.yaml | 1 -
MdeModulePkg/MdeModulePkg.dec | 1 -
MdePkg/MdePkg.ci.yaml | 1 -
4 files changed, 4 deletions(-)
diff --git a/MdeModulePkg/Include/Protocol/FormBrowserEx.h b/MdeModulePkg/Include/Protocol/FormBrowserEx.h
index c36aa6bdf1..e7e7cd18ab 100644
--- a/MdeModulePkg/Include/Protocol/FormBrowserEx.h
+++ b/MdeModulePkg/Include/Protocol/FormBrowserEx.h
@@ -143,7 +143,6 @@ struct _EDKII_FORM_BROWSER_EXTENSION_PROTOCOL {
SAVE_REMINDER SaveReminder;
};
-extern EFI_GUID gEfiFormBrowserExProtocolGuid;
extern EFI_GUID gEdkiiFormBrowserExProtocolGuid;
#endif
diff --git a/MdeModulePkg/MdeModulePkg.ci.yaml b/MdeModulePkg/MdeModulePkg.ci.yaml
index 3b6e747075..d8cd13b384 100644
--- a/MdeModulePkg/MdeModulePkg.ci.yaml
+++ b/MdeModulePkg/MdeModulePkg.ci.yaml
@@ -53,7 +53,6 @@
"IgnoreGuidValue": ["00000000-0000-0000-0000-000000000000"],
"IgnoreFoldersAndFiles": [],
"IgnoreDuplicates": [
- "gEdkiiFormBrowserExProtocolGuid=gEfiFormBrowserExProtocolGuid",
"gEfiPeiMmAccessPpiGuid=gPeiSmmAccessPpiGuid",
"gPeiSmmControlPpiGuid=gEfiPeiMmControlPpiGuid",
]
diff --git a/MdeModulePkg/MdeModulePkg.dec b/MdeModulePkg/MdeModulePkg.dec
index 91a3c60823..73ff177434 100644
--- a/MdeModulePkg/MdeModulePkg.dec
+++ b/MdeModulePkg/MdeModulePkg.dec
@@ -526,7 +526,6 @@
gEfiLockBoxProtocolGuid = { 0xbd445d79, 0xb7ad, 0x4f04, { 0x9a, 0xd8, 0x29, 0xbd, 0x20, 0x40, 0xeb, 0x3c }}
## Include/Protocol/FormBrowserEx.h
- gEfiFormBrowserExProtocolGuid = { 0x1f73b18d, 0x4630, 0x43c1, { 0xa1, 0xde, 0x6f, 0x80, 0x85, 0x5d, 0x7d, 0xa4 } }
gEdkiiFormBrowserExProtocolGuid = { 0x1f73b18d, 0x4630, 0x43c1, { 0xa1, 0xde, 0x6f, 0x80, 0x85, 0x5d, 0x7d, 0xa4 } }
## Include/Protocol/EbcVmTest.h
diff --git a/MdePkg/MdePkg.ci.yaml b/MdePkg/MdePkg.ci.yaml
index 88e490fcb6..3268f15354 100644
--- a/MdePkg/MdePkg.ci.yaml
+++ b/MdePkg/MdePkg.ci.yaml
@@ -81,7 +81,6 @@
"gEfiDebugPortProtocolGuid=gEfiDebugPortVariableGuid=gEfiDebugPortDevicePathGuid", ## is this a bug
"gEfiProcessorSpecificErrorSectionGuid=gEfiIa32X64ProcessorErrorSectionGuid", ## is this a bug
"gEfiSmmPeriodicTimerDispatch2ProtocolGuid=gEfiMmPeriodicTimerDispatchProtocolGuid",
- "gEdkiiFormBrowserExProtocolGuid=gEfiFormBrowserExProtocolGuid",
"gEfiPeiMmAccessPpiGuid=gPeiSmmAccessPpiGuid",
"gPeiSmmControlPpiGuid=gEfiPeiMmControlPpiGuid"
]
--
2.17.1
[-- Attachment #2: Type: text/html, Size: 7548 bytes --]
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [edk2-devel] [PATCH] MdeModulePkg: Remove gEfiFormBrowserExProtocolGuid Protocol Guid
2020-02-21 10:10 [PATCH] MdeModulePkg: Remove gEfiFormBrowserExProtocolGuid Protocol Guid GuoMinJ
@ 2020-03-27 0:48 ` Wu, Hao A
2020-03-30 1:16 ` Wu, Hao A
0 siblings, 1 reply; 4+ messages in thread
From: Wu, Hao A @ 2020-03-27 0:48 UTC (permalink / raw)
To: devel@edk2.groups.io, newexplorerj@gmail.com
> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> GuoMinJ
> Sent: Friday, February 21, 2020 6:11 PM
> To: devel@edk2.groups.io
> Cc: GuoMinJ
> Subject: [edk2-devel] [PATCH] MdeModulePkg: Remove
> gEfiFormBrowserExProtocolGuid Protocol Guid
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2145
>
> Replace the gEfiFormBrowserExProtocolGuid with
> gEdkiiFormBrowserExProtocolGuid, remove the unnecessary declaration.
>
> Signed-off-by: GuoMinJ <newexplorerj@gmail.com>
> ---
> MdeModulePkg/Include/Protocol/FormBrowserEx.h | 1 -
> MdeModulePkg/MdeModulePkg.ci.yaml | 1 -
> MdeModulePkg/MdeModulePkg.dec | 1 -
> MdePkg/MdePkg.ci.yaml | 1 -
> 4 files changed, 4 deletions(-)
>
> diff --git a/MdeModulePkg/Include/Protocol/FormBrowserEx.h
> b/MdeModulePkg/Include/Protocol/FormBrowserEx.h
> index c36aa6bdf1..e7e7cd18ab 100644
> --- a/MdeModulePkg/Include/Protocol/FormBrowserEx.h
> +++ b/MdeModulePkg/Include/Protocol/FormBrowserEx.h
> @@ -143,7 +143,6 @@ struct
> _EDKII_FORM_BROWSER_EXTENSION_PROTOCOL {
> SAVE_REMINDER SaveReminder;
> };
>
> -extern EFI_GUID gEfiFormBrowserExProtocolGuid;
> extern EFI_GUID gEdkiiFormBrowserExProtocolGuid;
>
> #endif
> diff --git a/MdeModulePkg/MdeModulePkg.ci.yaml
> b/MdeModulePkg/MdeModulePkg.ci.yaml
> index 3b6e747075..d8cd13b384 100644
> --- a/MdeModulePkg/MdeModulePkg.ci.yaml
> +++ b/MdeModulePkg/MdeModulePkg.ci.yaml
> @@ -53,7 +53,6 @@
> "IgnoreGuidValue": ["00000000-0000-0000-0000-000000000000"],
> "IgnoreFoldersAndFiles": [],
> "IgnoreDuplicates": [
> - "gEdkiiFormBrowserExProtocolGuid=gEfiFormBrowserExProtocolGuid",
> "gEfiPeiMmAccessPpiGuid=gPeiSmmAccessPpiGuid",
> "gPeiSmmControlPpiGuid=gEfiPeiMmControlPpiGuid",
> ]
> diff --git a/MdeModulePkg/MdeModulePkg.dec
> b/MdeModulePkg/MdeModulePkg.dec
> index 91a3c60823..73ff177434 100644
> --- a/MdeModulePkg/MdeModulePkg.dec
> +++ b/MdeModulePkg/MdeModulePkg.dec
> @@ -526,7 +526,6 @@
> gEfiLockBoxProtocolGuid = { 0xbd445d79, 0xb7ad, 0x4f04, { 0x9a, 0xd8,
> 0x29, 0xbd, 0x20, 0x40, 0xeb, 0x3c }}
>
> ## Include/Protocol/FormBrowserEx.h
> - gEfiFormBrowserExProtocolGuid = { 0x1f73b18d, 0x4630, 0x43c1, { 0xa1,
> 0xde, 0x6f, 0x80, 0x85, 0x5d, 0x7d, 0xa4 } }
> gEdkiiFormBrowserExProtocolGuid = { 0x1f73b18d, 0x4630, 0x43c1, { 0xa1,
> 0xde, 0x6f, 0x80, 0x85, 0x5d, 0x7d, 0xa4 } }
>
> ## Include/Protocol/EbcVmTest.h
> diff --git a/MdePkg/MdePkg.ci.yaml b/MdePkg/MdePkg.ci.yaml
> index 88e490fcb6..3268f15354 100644
> --- a/MdePkg/MdePkg.ci.yaml
> +++ b/MdePkg/MdePkg.ci.yaml
> @@ -81,7 +81,6 @@
>
> "gEfiDebugPortProtocolGuid=gEfiDebugPortVariableGuid=gEfiDebugPortDevice
> PathGuid", ## is this a bug
>
> "gEfiProcessorSpecificErrorSectionGuid=gEfiIa32X64ProcessorErrorSectionGuid
> ", ## is this a bug
>
> "gEfiSmmPeriodicTimerDispatch2ProtocolGuid=gEfiMmPeriodicTimerDispatchP
> rotocolGuid",
> - "gEdkiiFormBrowserExProtocolGuid=gEfiFormBrowserExProtocolGuid",
Acked-by: Hao A Wu <hao.a.wu@intel.com>
Best Regards,
Hao Wu
> "gEfiPeiMmAccessPpiGuid=gPeiSmmAccessPpiGuid",
> "gPeiSmmControlPpiGuid=gEfiPeiMmControlPpiGuid"
> ]
> --
> 2.17.1
>
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [edk2-devel] [PATCH] MdeModulePkg: Remove gEfiFormBrowserExProtocolGuid Protocol Guid
2020-03-27 0:48 ` [edk2-devel] " Wu, Hao A
@ 2020-03-30 1:16 ` Wu, Hao A
0 siblings, 0 replies; 4+ messages in thread
From: Wu, Hao A @ 2020-03-30 1:16 UTC (permalink / raw)
To: 'devel@edk2.groups.io', 'newexplorerj@gmail.com'
> -----Original Message-----
> From: Wu, Hao A
> Sent: Friday, March 27, 2020 8:48 AM
> To: devel@edk2.groups.io; newexplorerj@gmail.com
> Subject: RE: [edk2-devel] [PATCH] MdeModulePkg: Remove
> gEfiFormBrowserExProtocolGuid Protocol Guid
>
> > -----Original Message-----
> > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> > GuoMinJ
> > Sent: Friday, February 21, 2020 6:11 PM
> > To: devel@edk2.groups.io
> > Cc: GuoMinJ
> > Subject: [edk2-devel] [PATCH] MdeModulePkg: Remove
> > gEfiFormBrowserExProtocolGuid Protocol Guid
> >
> > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2145
> >
> > Replace the gEfiFormBrowserExProtocolGuid with
> > gEdkiiFormBrowserExProtocolGuid, remove the unnecessary declaration.
> >
> > Signed-off-by: GuoMinJ <newexplorerj@gmail.com>
> > ---
> > MdeModulePkg/Include/Protocol/FormBrowserEx.h | 1 -
> > MdeModulePkg/MdeModulePkg.ci.yaml | 1 -
> > MdeModulePkg/MdeModulePkg.dec | 1 -
> > MdePkg/MdePkg.ci.yaml | 1 -
> > 4 files changed, 4 deletions(-)
> >
> > diff --git a/MdeModulePkg/Include/Protocol/FormBrowserEx.h
> > b/MdeModulePkg/Include/Protocol/FormBrowserEx.h
> > index c36aa6bdf1..e7e7cd18ab 100644
> > --- a/MdeModulePkg/Include/Protocol/FormBrowserEx.h
> > +++ b/MdeModulePkg/Include/Protocol/FormBrowserEx.h
> > @@ -143,7 +143,6 @@ struct
> > _EDKII_FORM_BROWSER_EXTENSION_PROTOCOL {
> > SAVE_REMINDER SaveReminder;
> > };
> >
> > -extern EFI_GUID gEfiFormBrowserExProtocolGuid;
> > extern EFI_GUID gEdkiiFormBrowserExProtocolGuid;
> >
> > #endif
> > diff --git a/MdeModulePkg/MdeModulePkg.ci.yaml
> > b/MdeModulePkg/MdeModulePkg.ci.yaml
> > index 3b6e747075..d8cd13b384 100644
> > --- a/MdeModulePkg/MdeModulePkg.ci.yaml
> > +++ b/MdeModulePkg/MdeModulePkg.ci.yaml
> > @@ -53,7 +53,6 @@
> > "IgnoreGuidValue": ["00000000-0000-0000-0000-000000000000"],
> > "IgnoreFoldersAndFiles": [],
> > "IgnoreDuplicates": [
> > -
> "gEdkiiFormBrowserExProtocolGuid=gEfiFormBrowserExProtocolGuid",
> > "gEfiPeiMmAccessPpiGuid=gPeiSmmAccessPpiGuid",
> > "gPeiSmmControlPpiGuid=gEfiPeiMmControlPpiGuid",
> > ]
> > diff --git a/MdeModulePkg/MdeModulePkg.dec
> > b/MdeModulePkg/MdeModulePkg.dec
> > index 91a3c60823..73ff177434 100644
> > --- a/MdeModulePkg/MdeModulePkg.dec
> > +++ b/MdeModulePkg/MdeModulePkg.dec
> > @@ -526,7 +526,6 @@
> > gEfiLockBoxProtocolGuid = { 0xbd445d79, 0xb7ad, 0x4f04, { 0x9a, 0xd8,
> > 0x29, 0xbd, 0x20, 0x40, 0xeb, 0x3c }}
> >
> > ## Include/Protocol/FormBrowserEx.h
> > - gEfiFormBrowserExProtocolGuid = { 0x1f73b18d, 0x4630, 0x43c1, { 0xa1,
> > 0xde, 0x6f, 0x80, 0x85, 0x5d, 0x7d, 0xa4 } }
> > gEdkiiFormBrowserExProtocolGuid = { 0x1f73b18d, 0x4630, 0x43c1, { 0xa1,
> > 0xde, 0x6f, 0x80, 0x85, 0x5d, 0x7d, 0xa4 } }
> >
> > ## Include/Protocol/EbcVmTest.h
> > diff --git a/MdePkg/MdePkg.ci.yaml b/MdePkg/MdePkg.ci.yaml
> > index 88e490fcb6..3268f15354 100644
> > --- a/MdePkg/MdePkg.ci.yaml
> > +++ b/MdePkg/MdePkg.ci.yaml
> > @@ -81,7 +81,6 @@
> >
> >
> "gEfiDebugPortProtocolGuid=gEfiDebugPortVariableGuid=gEfiDebugPortDevice
> > PathGuid", ## is this a bug
> >
> >
> "gEfiProcessorSpecificErrorSectionGuid=gEfiIa32X64ProcessorErrorSectionGuid
> > ", ## is this a bug
> >
> >
> "gEfiSmmPeriodicTimerDispatch2ProtocolGuid=gEfiMmPeriodicTimerDispatchP
> > rotocolGuid",
> > -
> "gEdkiiFormBrowserExProtocolGuid=gEfiFormBrowserExProtocolGuid",
>
>
> Acked-by: Hao A Wu <hao.a.wu@intel.com>
Patch pushed via commit d4e2909bfc.
Best Regards,
Hao Wu
>
> Best Regards,
> Hao Wu
>
>
> > "gEfiPeiMmAccessPpiGuid=gPeiSmmAccessPpiGuid",
> > "gPeiSmmControlPpiGuid=gEfiPeiMmControlPpiGuid"
> > ]
> > --
> > 2.17.1
> >
> >
> >
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-03-30 1:17 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-02-21 10:10 [PATCH] MdeModulePkg: Remove gEfiFormBrowserExProtocolGuid Protocol Guid GuoMinJ
2020-03-27 0:48 ` [edk2-devel] " Wu, Hao A
2020-03-30 1:16 ` Wu, Hao A
-- strict thread matches above, loose matches on Subject: below --
2020-03-26 15:00 Guomin Jiang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox