From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mx.groups.io with SMTP id smtpd.web10.3062.1585270099817969905 for ; Thu, 26 Mar 2020 17:48:20 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.126, mailfrom: hao.a.wu@intel.com) IronPort-SDR: tM3nQlG3MmZcO5SM7VDPEhVErbzUKIGzTqsQ9o8+0c5bUa3XDenCHwg+C+0jAgEdS1Qtotpbkl k0bZKRUDNKbg== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Mar 2020 17:48:19 -0700 IronPort-SDR: Heo6rt5Mmgm2tFb1s+iwaFkY0LnxunYSgMhMCGZeeZ4SRcUn2nzy5mau8Zx6flgb4ehXAEQBN/ 5iOxsyhi6bmw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,310,1580803200"; d="scan'208";a="326740503" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga001.jf.intel.com with ESMTP; 26 Mar 2020 17:48:19 -0700 Received: from fmsmsx111.amr.corp.intel.com (10.18.116.5) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 26 Mar 2020 17:48:18 -0700 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by fmsmsx111.amr.corp.intel.com (10.18.116.5) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 26 Mar 2020 17:48:18 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.206]) by shsmsx102.ccr.corp.intel.com ([169.254.2.50]) with mapi id 14.03.0439.000; Fri, 27 Mar 2020 08:48:16 +0800 From: "Wu, Hao A" To: "devel@edk2.groups.io" , "newexplorerj@gmail.com" Subject: Re: [edk2-devel] [PATCH] MdeModulePkg: Remove gEfiFormBrowserExProtocolGuid Protocol Guid Thread-Topic: [edk2-devel] [PATCH] MdeModulePkg: Remove gEfiFormBrowserExProtocolGuid Protocol Guid Thread-Index: AQHV6J84l8Jq0tSN60iyEzeyyOilXqhb0XAQ Date: Fri, 27 Mar 2020 00:48:15 +0000 Message-ID: References: <727a2c5e18bfb162b5a71a934f4f49f20ab3cee7.1582278213.git.newexplorerj@gmail.com> In-Reply-To: <727a2c5e18bfb162b5a71a934f4f49f20ab3cee7.1582278213.git.newexplorerj@gmail.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: hao.a.wu@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > GuoMinJ > Sent: Friday, February 21, 2020 6:11 PM > To: devel@edk2.groups.io > Cc: GuoMinJ > Subject: [edk2-devel] [PATCH] MdeModulePkg: Remove > gEfiFormBrowserExProtocolGuid Protocol Guid >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2145 >=20 > Replace the gEfiFormBrowserExProtocolGuid with > gEdkiiFormBrowserExProtocolGuid, remove the unnecessary declaration. >=20 > Signed-off-by: GuoMinJ > --- > MdeModulePkg/Include/Protocol/FormBrowserEx.h | 1 - > MdeModulePkg/MdeModulePkg.ci.yaml | 1 - > MdeModulePkg/MdeModulePkg.dec | 1 - > MdePkg/MdePkg.ci.yaml | 1 - > 4 files changed, 4 deletions(-) >=20 > diff --git a/MdeModulePkg/Include/Protocol/FormBrowserEx.h > b/MdeModulePkg/Include/Protocol/FormBrowserEx.h > index c36aa6bdf1..e7e7cd18ab 100644 > --- a/MdeModulePkg/Include/Protocol/FormBrowserEx.h > +++ b/MdeModulePkg/Include/Protocol/FormBrowserEx.h > @@ -143,7 +143,6 @@ struct > _EDKII_FORM_BROWSER_EXTENSION_PROTOCOL { > SAVE_REMINDER SaveReminder; > }; >=20 > -extern EFI_GUID gEfiFormBrowserExProtocolGuid; > extern EFI_GUID gEdkiiFormBrowserExProtocolGuid; >=20 > #endif > diff --git a/MdeModulePkg/MdeModulePkg.ci.yaml > b/MdeModulePkg/MdeModulePkg.ci.yaml > index 3b6e747075..d8cd13b384 100644 > --- a/MdeModulePkg/MdeModulePkg.ci.yaml > +++ b/MdeModulePkg/MdeModulePkg.ci.yaml > @@ -53,7 +53,6 @@ > "IgnoreGuidValue": ["00000000-0000-0000-0000-000000000000"], > "IgnoreFoldersAndFiles": [], > "IgnoreDuplicates": [ > - "gEdkiiFormBrowserExProtocolGuid=3DgEfiFormBrowserExProtoco= lGuid", > "gEfiPeiMmAccessPpiGuid=3DgPeiSmmAccessPpiGuid", > "gPeiSmmControlPpiGuid=3DgEfiPeiMmControlPpiGuid", > ] > diff --git a/MdeModulePkg/MdeModulePkg.dec > b/MdeModulePkg/MdeModulePkg.dec > index 91a3c60823..73ff177434 100644 > --- a/MdeModulePkg/MdeModulePkg.dec > +++ b/MdeModulePkg/MdeModulePkg.dec > @@ -526,7 +526,6 @@ > gEfiLockBoxProtocolGuid =3D { 0xbd445d79, 0xb7ad, 0x4f04, { 0x= 9a, 0xd8, > 0x29, 0xbd, 0x20, 0x40, 0xeb, 0x3c }} >=20 > ## Include/Protocol/FormBrowserEx.h > - gEfiFormBrowserExProtocolGuid =3D { 0x1f73b18d, 0x4630, 0x43c1, { 0xa= 1, > 0xde, 0x6f, 0x80, 0x85, 0x5d, 0x7d, 0xa4 } } > gEdkiiFormBrowserExProtocolGuid =3D { 0x1f73b18d, 0x4630, 0x43c1, { 0= xa1, > 0xde, 0x6f, 0x80, 0x85, 0x5d, 0x7d, 0xa4 } } >=20 > ## Include/Protocol/EbcVmTest.h > diff --git a/MdePkg/MdePkg.ci.yaml b/MdePkg/MdePkg.ci.yaml > index 88e490fcb6..3268f15354 100644 > --- a/MdePkg/MdePkg.ci.yaml > +++ b/MdePkg/MdePkg.ci.yaml > @@ -81,7 +81,6 @@ >=20 > "gEfiDebugPortProtocolGuid=3DgEfiDebugPortVariableGuid=3DgEfiDebugPortDe= vice > PathGuid", ## is this a bug >=20 > "gEfiProcessorSpecificErrorSectionGuid=3DgEfiIa32X64ProcessorErrorSectio= nGuid > ", ## is this a bug >=20 > "gEfiSmmPeriodicTimerDispatch2ProtocolGuid=3DgEfiMmPeriodicTimerDispatch= P > rotocolGuid", > - "gEdkiiFormBrowserExProtocolGuid=3DgEfiFormBrowserExProtoco= lGuid", Acked-by: Hao A Wu Best Regards, Hao Wu > "gEfiPeiMmAccessPpiGuid=3DgPeiSmmAccessPpiGuid", > "gPeiSmmControlPpiGuid=3DgEfiPeiMmControlPpiGuid" > ] > -- > 2.17.1 >=20 >=20 >=20