From: "Wu, Hao A" <hao.a.wu@intel.com>
To: "'devel@edk2.groups.io'" <devel@edk2.groups.io>,
"'newexplorerj@gmail.com'" <newexplorerj@gmail.com>
Subject: Re: [edk2-devel] [PATCH] MdeModulePkg: Remove gEfiFormBrowserExProtocolGuid Protocol Guid
Date: Mon, 30 Mar 2020 01:16:42 +0000 [thread overview]
Message-ID: <B80AF82E9BFB8E4FBD8C89DA810C6A093C9CAFD5@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <B80AF82E9BFB8E4FBD8C89DA810C6A093C9C21A1@SHSMSX104.ccr.corp.intel.com>
> -----Original Message-----
> From: Wu, Hao A
> Sent: Friday, March 27, 2020 8:48 AM
> To: devel@edk2.groups.io; newexplorerj@gmail.com
> Subject: RE: [edk2-devel] [PATCH] MdeModulePkg: Remove
> gEfiFormBrowserExProtocolGuid Protocol Guid
>
> > -----Original Message-----
> > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> > GuoMinJ
> > Sent: Friday, February 21, 2020 6:11 PM
> > To: devel@edk2.groups.io
> > Cc: GuoMinJ
> > Subject: [edk2-devel] [PATCH] MdeModulePkg: Remove
> > gEfiFormBrowserExProtocolGuid Protocol Guid
> >
> > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2145
> >
> > Replace the gEfiFormBrowserExProtocolGuid with
> > gEdkiiFormBrowserExProtocolGuid, remove the unnecessary declaration.
> >
> > Signed-off-by: GuoMinJ <newexplorerj@gmail.com>
> > ---
> > MdeModulePkg/Include/Protocol/FormBrowserEx.h | 1 -
> > MdeModulePkg/MdeModulePkg.ci.yaml | 1 -
> > MdeModulePkg/MdeModulePkg.dec | 1 -
> > MdePkg/MdePkg.ci.yaml | 1 -
> > 4 files changed, 4 deletions(-)
> >
> > diff --git a/MdeModulePkg/Include/Protocol/FormBrowserEx.h
> > b/MdeModulePkg/Include/Protocol/FormBrowserEx.h
> > index c36aa6bdf1..e7e7cd18ab 100644
> > --- a/MdeModulePkg/Include/Protocol/FormBrowserEx.h
> > +++ b/MdeModulePkg/Include/Protocol/FormBrowserEx.h
> > @@ -143,7 +143,6 @@ struct
> > _EDKII_FORM_BROWSER_EXTENSION_PROTOCOL {
> > SAVE_REMINDER SaveReminder;
> > };
> >
> > -extern EFI_GUID gEfiFormBrowserExProtocolGuid;
> > extern EFI_GUID gEdkiiFormBrowserExProtocolGuid;
> >
> > #endif
> > diff --git a/MdeModulePkg/MdeModulePkg.ci.yaml
> > b/MdeModulePkg/MdeModulePkg.ci.yaml
> > index 3b6e747075..d8cd13b384 100644
> > --- a/MdeModulePkg/MdeModulePkg.ci.yaml
> > +++ b/MdeModulePkg/MdeModulePkg.ci.yaml
> > @@ -53,7 +53,6 @@
> > "IgnoreGuidValue": ["00000000-0000-0000-0000-000000000000"],
> > "IgnoreFoldersAndFiles": [],
> > "IgnoreDuplicates": [
> > -
> "gEdkiiFormBrowserExProtocolGuid=gEfiFormBrowserExProtocolGuid",
> > "gEfiPeiMmAccessPpiGuid=gPeiSmmAccessPpiGuid",
> > "gPeiSmmControlPpiGuid=gEfiPeiMmControlPpiGuid",
> > ]
> > diff --git a/MdeModulePkg/MdeModulePkg.dec
> > b/MdeModulePkg/MdeModulePkg.dec
> > index 91a3c60823..73ff177434 100644
> > --- a/MdeModulePkg/MdeModulePkg.dec
> > +++ b/MdeModulePkg/MdeModulePkg.dec
> > @@ -526,7 +526,6 @@
> > gEfiLockBoxProtocolGuid = { 0xbd445d79, 0xb7ad, 0x4f04, { 0x9a, 0xd8,
> > 0x29, 0xbd, 0x20, 0x40, 0xeb, 0x3c }}
> >
> > ## Include/Protocol/FormBrowserEx.h
> > - gEfiFormBrowserExProtocolGuid = { 0x1f73b18d, 0x4630, 0x43c1, { 0xa1,
> > 0xde, 0x6f, 0x80, 0x85, 0x5d, 0x7d, 0xa4 } }
> > gEdkiiFormBrowserExProtocolGuid = { 0x1f73b18d, 0x4630, 0x43c1, { 0xa1,
> > 0xde, 0x6f, 0x80, 0x85, 0x5d, 0x7d, 0xa4 } }
> >
> > ## Include/Protocol/EbcVmTest.h
> > diff --git a/MdePkg/MdePkg.ci.yaml b/MdePkg/MdePkg.ci.yaml
> > index 88e490fcb6..3268f15354 100644
> > --- a/MdePkg/MdePkg.ci.yaml
> > +++ b/MdePkg/MdePkg.ci.yaml
> > @@ -81,7 +81,6 @@
> >
> >
> "gEfiDebugPortProtocolGuid=gEfiDebugPortVariableGuid=gEfiDebugPortDevice
> > PathGuid", ## is this a bug
> >
> >
> "gEfiProcessorSpecificErrorSectionGuid=gEfiIa32X64ProcessorErrorSectionGuid
> > ", ## is this a bug
> >
> >
> "gEfiSmmPeriodicTimerDispatch2ProtocolGuid=gEfiMmPeriodicTimerDispatchP
> > rotocolGuid",
> > -
> "gEdkiiFormBrowserExProtocolGuid=gEfiFormBrowserExProtocolGuid",
>
>
> Acked-by: Hao A Wu <hao.a.wu@intel.com>
Patch pushed via commit d4e2909bfc.
Best Regards,
Hao Wu
>
> Best Regards,
> Hao Wu
>
>
> > "gEfiPeiMmAccessPpiGuid=gPeiSmmAccessPpiGuid",
> > "gPeiSmmControlPpiGuid=gEfiPeiMmControlPpiGuid"
> > ]
> > --
> > 2.17.1
> >
> >
> >
next prev parent reply other threads:[~2020-03-30 1:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-21 10:10 [PATCH] MdeModulePkg: Remove gEfiFormBrowserExProtocolGuid Protocol Guid GuoMinJ
2020-03-27 0:48 ` [edk2-devel] " Wu, Hao A
2020-03-30 1:16 ` Wu, Hao A [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-03-26 15:00 Guomin Jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B80AF82E9BFB8E4FBD8C89DA810C6A093C9CAFD5@SHSMSX104.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox