From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mx.groups.io with SMTP id smtpd.web10.41347.1585531025917711301 for ; Sun, 29 Mar 2020 18:17:06 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.31, mailfrom: hao.a.wu@intel.com) IronPort-SDR: OW9k89YmVLjjGTblP542xHxCGLND6u/+74BJ4lAhY0WDUhbwjYZ7CcPQe0uXg8BSHDnN6tbLtm FF4Kh7n1Znfg== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Mar 2020 18:17:05 -0700 IronPort-SDR: tuFUwrwzldMu3+xd1tmLtu6EqoB1XETaCy9o2eFjZONyTYadvRIxInEAtXq0cN4Igb4VbGSQ4r 3dpwBfYGi8JQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,322,1580803200"; d="scan'208";a="448087063" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga005.fm.intel.com with ESMTP; 29 Mar 2020 18:17:05 -0700 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 29 Mar 2020 18:16:45 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.225]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.146]) with mapi id 14.03.0439.000; Mon, 30 Mar 2020 09:16:42 +0800 From: "Wu, Hao A" To: "'devel@edk2.groups.io'" , "'newexplorerj@gmail.com'" Subject: Re: [edk2-devel] [PATCH] MdeModulePkg: Remove gEfiFormBrowserExProtocolGuid Protocol Guid Thread-Topic: [edk2-devel] [PATCH] MdeModulePkg: Remove gEfiFormBrowserExProtocolGuid Protocol Guid Thread-Index: AQHV6J84l8Jq0tSN60iyEzeyyOilXqhb0XAQgAS+3+A= Date: Mon, 30 Mar 2020 01:16:42 +0000 Message-ID: References: <727a2c5e18bfb162b5a71a934f4f49f20ab3cee7.1582278213.git.newexplorerj@gmail.com> In-Reply-To: Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: hao.a.wu@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: Wu, Hao A > Sent: Friday, March 27, 2020 8:48 AM > To: devel@edk2.groups.io; newexplorerj@gmail.com > Subject: RE: [edk2-devel] [PATCH] MdeModulePkg: Remove > gEfiFormBrowserExProtocolGuid Protocol Guid >=20 > > -----Original Message----- > > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > > GuoMinJ > > Sent: Friday, February 21, 2020 6:11 PM > > To: devel@edk2.groups.io > > Cc: GuoMinJ > > Subject: [edk2-devel] [PATCH] MdeModulePkg: Remove > > gEfiFormBrowserExProtocolGuid Protocol Guid > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2145 > > > > Replace the gEfiFormBrowserExProtocolGuid with > > gEdkiiFormBrowserExProtocolGuid, remove the unnecessary declaration. > > > > Signed-off-by: GuoMinJ > > --- > > MdeModulePkg/Include/Protocol/FormBrowserEx.h | 1 - > > MdeModulePkg/MdeModulePkg.ci.yaml | 1 - > > MdeModulePkg/MdeModulePkg.dec | 1 - > > MdePkg/MdePkg.ci.yaml | 1 - > > 4 files changed, 4 deletions(-) > > > > diff --git a/MdeModulePkg/Include/Protocol/FormBrowserEx.h > > b/MdeModulePkg/Include/Protocol/FormBrowserEx.h > > index c36aa6bdf1..e7e7cd18ab 100644 > > --- a/MdeModulePkg/Include/Protocol/FormBrowserEx.h > > +++ b/MdeModulePkg/Include/Protocol/FormBrowserEx.h > > @@ -143,7 +143,6 @@ struct > > _EDKII_FORM_BROWSER_EXTENSION_PROTOCOL { > > SAVE_REMINDER SaveReminder; > > }; > > > > -extern EFI_GUID gEfiFormBrowserExProtocolGuid; > > extern EFI_GUID gEdkiiFormBrowserExProtocolGuid; > > > > #endif > > diff --git a/MdeModulePkg/MdeModulePkg.ci.yaml > > b/MdeModulePkg/MdeModulePkg.ci.yaml > > index 3b6e747075..d8cd13b384 100644 > > --- a/MdeModulePkg/MdeModulePkg.ci.yaml > > +++ b/MdeModulePkg/MdeModulePkg.ci.yaml > > @@ -53,7 +53,6 @@ > > "IgnoreGuidValue": ["00000000-0000-0000-0000-000000000000"], > > "IgnoreFoldersAndFiles": [], > > "IgnoreDuplicates": [ > > - > "gEdkiiFormBrowserExProtocolGuid=3DgEfiFormBrowserExProtocolGuid", > > "gEfiPeiMmAccessPpiGuid=3DgPeiSmmAccessPpiGuid", > > "gPeiSmmControlPpiGuid=3DgEfiPeiMmControlPpiGuid", > > ] > > diff --git a/MdeModulePkg/MdeModulePkg.dec > > b/MdeModulePkg/MdeModulePkg.dec > > index 91a3c60823..73ff177434 100644 > > --- a/MdeModulePkg/MdeModulePkg.dec > > +++ b/MdeModulePkg/MdeModulePkg.dec > > @@ -526,7 +526,6 @@ > > gEfiLockBoxProtocolGuid =3D { 0xbd445d79, 0xb7ad, 0x4f04, { = 0x9a, 0xd8, > > 0x29, 0xbd, 0x20, 0x40, 0xeb, 0x3c }} > > > > ## Include/Protocol/FormBrowserEx.h > > - gEfiFormBrowserExProtocolGuid =3D { 0x1f73b18d, 0x4630, 0x43c1, { 0= xa1, > > 0xde, 0x6f, 0x80, 0x85, 0x5d, 0x7d, 0xa4 } } > > gEdkiiFormBrowserExProtocolGuid =3D { 0x1f73b18d, 0x4630, 0x43c1, {= 0xa1, > > 0xde, 0x6f, 0x80, 0x85, 0x5d, 0x7d, 0xa4 } } > > > > ## Include/Protocol/EbcVmTest.h > > diff --git a/MdePkg/MdePkg.ci.yaml b/MdePkg/MdePkg.ci.yaml > > index 88e490fcb6..3268f15354 100644 > > --- a/MdePkg/MdePkg.ci.yaml > > +++ b/MdePkg/MdePkg.ci.yaml > > @@ -81,7 +81,6 @@ > > > > > "gEfiDebugPortProtocolGuid=3DgEfiDebugPortVariableGuid=3DgEfiDebugPortDe= vice > > PathGuid", ## is this a bug > > > > > "gEfiProcessorSpecificErrorSectionGuid=3DgEfiIa32X64ProcessorErrorSectio= nGuid > > ", ## is this a bug > > > > > "gEfiSmmPeriodicTimerDispatch2ProtocolGuid=3DgEfiMmPeriodicTimerDispatch= P > > rotocolGuid", > > - > "gEdkiiFormBrowserExProtocolGuid=3DgEfiFormBrowserExProtocolGuid", >=20 >=20 > Acked-by: Hao A Wu Patch pushed via commit d4e2909bfc. Best Regards, Hao Wu >=20 > Best Regards, > Hao Wu >=20 >=20 > > "gEfiPeiMmAccessPpiGuid=3DgPeiSmmAccessPpiGuid", > > "gPeiSmmControlPpiGuid=3DgEfiPeiMmControlPpiGuid" > > ] > > -- > > 2.17.1 > > > > > >=20