From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mx.groups.io with SMTP id smtpd.web10.633.1587361198862580710 for ; Sun, 19 Apr 2020 22:39:58 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.20, mailfrom: hao.a.wu@intel.com) IronPort-SDR: iXymx6C374KCgOlzvuExUdwYune4B7ADdMhcaXqt0Apjkw56E3uX+FiVxFGm+mWV1Arbnr8eIK 3HZXJPHnFCkQ== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Apr 2020 22:39:58 -0700 IronPort-SDR: kOvBx8rj8Srdoonpi1A68JZtdFzSHXrlVN0e/VMCxIZ6pRLu3zrJMJ7bAyjn1w3jnC44liY88y nxSjkzt507nw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,405,1580803200"; d="scan'208";a="273069856" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga002.jf.intel.com with ESMTP; 19 Apr 2020 22:39:57 -0700 Received: from fmsmsx113.amr.corp.intel.com (10.18.116.7) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 19 Apr 2020 22:39:57 -0700 Received: from shsmsx154.ccr.corp.intel.com (10.239.6.54) by FMSMSX113.amr.corp.intel.com (10.18.116.7) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 19 Apr 2020 22:39:57 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.225]) by SHSMSX154.ccr.corp.intel.com ([169.254.7.214]) with mapi id 14.03.0439.000; Mon, 20 Apr 2020 13:39:54 +0800 From: "Wu, Hao A" To: "devel@edk2.groups.io" , "abner.chang@hpe.com" CC: "Chen, Gilbert" , Leif Lindholm , "Gao, Liming" Subject: Re: [edk2-devel] [PATCH v1 2/3] MdeModulePkg/CapsuleRuntimeDxe: Add RISCV64 arch. Thread-Topic: [edk2-devel] [PATCH v1 2/3] MdeModulePkg/CapsuleRuntimeDxe: Add RISCV64 arch. Thread-Index: AQHWDw6zF79oI2yGA0uFSUZjLxNprqiBiCgQgAAFJOCAAACiYA== Date: Mon, 20 Apr 2020 05:39:53 +0000 Message-ID: References: <20200410072555.7444-1-abner.chang@hpe.com> <160466A642D4443D.7555@groups.io> In-Reply-To: Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: hao.a.wu@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Abner Chang > Sent: Monday, April 20, 2020 1:38 PM > To: devel@edk2.groups.io; Wu, Hao A > Cc: Chen, Gilbert; Leif Lindholm; Gao, Liming > Subject: Re: [edk2-devel] [PATCH v1 2/3] > MdeModulePkg/CapsuleRuntimeDxe: Add RISCV64 arch. >=20 >=20 >=20 > > -----Original Message----- > > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > > Wu, Hao A > > Sent: Monday, April 20, 2020 1:24 PM > > To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist) > > > > Cc: Chen, Gilbert ; Leif Lindholm > > ; Gao, Liming > > Subject: Re: [edk2-devel] [PATCH v1 2/3] > > MdeModulePkg/CapsuleRuntimeDxe: Add RISCV64 arch. > > > > > -----Original Message----- > > > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf > Of > > > Chang, Abner (HPS SW/FW Technologist) > > > Sent: Friday, April 10, 2020 3:26 PM > > > To: devel@edk2.groups.io > > > Cc: Chang, Abner (HPS SW/FW Technologist); Chen, Gilbert; Leif > > > Lindholm; Wu, Hao A; Gao, Liming > > > Subject: [edk2-devel] [PATCH v1 2/3] > MdeModulePkg/CapsuleRuntimeDxe: > > > Add RISCV64 arch. > > > > > > Add RISC-V in INF for building CapsuleRuntimeDxe RISCV64 image. > > > > > > Signed-off-by: Abner Chang > > > Co-authored-by: Gilbert Chen > > > Reviewed-by: Leif Lindholm > > > > > > Cc: Hao A Wu > > > Cc: Liming Gao > > > Cc: Leif Lindholm > > > Cc: Gilbert Chen > > > --- > > > .../Universal/CapsuleRuntimeDxe/CapsuleRuntimeDxe.inf | 9 +++++-= --- > > > 1 file changed, 5 insertions(+), 4 deletions(-) > > > > > > diff --git > > > a/MdeModulePkg/Universal/CapsuleRuntimeDxe/CapsuleRuntimeDxe.inf > > > b/MdeModulePkg/Universal/CapsuleRuntimeDxe/CapsuleRuntimeDxe.inf > > > index 942eda235c..8bf5035a69 100644 > > > --- > > a/MdeModulePkg/Universal/CapsuleRuntimeDxe/CapsuleRuntimeDxe.inf > > > +++ > > > b/MdeModulePkg/Universal/CapsuleRuntimeDxe/CapsuleRuntimeDxe.inf > > > @@ -5,6 +5,7 @@ > > > # the capsule runtime services are ready. > > > # > > > # Copyright (c) 2006 - 2020, Intel Corporation. All rights > > > reserved.
> > > +# Copyright (c) 2020, Hewlett Packard Enterprise Development LP. A= ll > > > +rights > > > reserved.
> > > # SPDX-License-Identifier: BSD-2-Clause-Patent # ## @@ -21,20 > > > +22,20 @@ # # The following information is for reference only and > > > not required by the build tools. > > > # > > > -# VALID_ARCHITECTURES =3D IA32 X64 EBC ARM AARCH64 > > > +# VALID_ARCHITECTURES =3D IA32 X64 EBC ARM AARCH64 RISCV= 64 > > > # > > > > > > [Sources] > > > CapsuleService.c > > > CapsuleService.h > > > > > > -[Sources.Ia32, Sources.EBC, Sources.ARM, Sources.AARCH64] > > > +[Sources.Ia32, Sources.EBC, Sources.ARM, Sources.AARCH64, > > > Sources.RISCV64] > > > SaveLongModeContext.c > > > > > > -[Sources.Ia32, Sources.X64, Sources.ARM, Sources.AARCH64] > > > +[Sources.Ia32, Sources.X64, Sources.ARM, Sources.AARCH64, > > > Sources.RISCV64] > > > CapsuleCache.c > > > > > > -[Sources.Ia32, Sources.X64, Sources.EBC] > > > +[Sources.Ia32, Sources.X64, Sources.EBC, Sources.RISCV64] > > > CapsuleReset.c > > > > > > Hello Abner, > > > > Sorry for the delayed response. > > I saw you added the new arch under sections: > > [Sources.Ia32, Sources.EBC, Sources.ARM, Sources.AARCH64] > [Sources.Ia32, > > Sources.X64, Sources.ARM, Sources.AARCH64] [Sources.Ia32, Sources.X64, > > Sources.EBC] > > > > How about the below section? It is not needed, right? > > [Sources.X64] > No, we don't need [Sources.X64] for architecture specific > saveLongModeContext implementation. > thanks Got it, thanks for the explanation. Acked-by: Hao A Wu Best Regards, Hao Wu >=20 > > > > Best Regards, > > Hao Wu > > > > > > > > > > [Sources.ARM, Sources.AARCH64] > > > -- > > > 2.25.0 > > > > > > > > > > > > > > > >=20 >=20 >=20