From: "Wu, Hao A" <hao.a.wu@intel.com>
To: Samer El-Haj-Mahmoud <samer@elhajmahmoud.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>,
Laszlo Ersek <lersek@redhat.com>,
"Bi, Dandan" <dandan.bi@intel.com>,
"Gao, Liming" <liming.gao@intel.com>
Cc: "Wang, Jian J" <jian.j.wang@intel.com>,
Leif Lindholm <leif@nuviainc.com>,
Ard Biesheuvel <ard.biesheuvel@arm.com>
Subject: Re: [edk2][PATCH v2 1/2] MdeModulePkg: PcdAcpiExposedTableVersions default for Arm64 platforms
Date: Tue, 21 Apr 2020 08:54:11 +0000 [thread overview]
Message-ID: <B80AF82E9BFB8E4FBD8C89DA810C6A093C9EC3AD@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <20200410152925.6119-2-samer@elhajmahmoud.com>
> -----Original Message-----
> From: Samer El-Haj-Mahmoud [mailto:samer@elhajmahmoud.com]
> Sent: Friday, April 10, 2020 11:29 PM
> To: devel@edk2.groups.io
> Cc: Bi, Dandan; Gao, Liming; Wang, Jian J; Wu, Hao A; Leif Lindholm; Ard
> Biesheuvel
> Subject: [edk2][PATCH v2 1/2] MdeModulePkg:
> PcdAcpiExposedTableVersions default for Arm64 platforms
>
> Set the default value of PcdAcpiExposedTableVersions for Aarch64
> platforms to 0x20. Previously, the default was set to 0x3E for all
> platforms. The new value removes ACPI 1.0b compatability, which forces
> the use of XSDT 64-bit pointer, as required by Arm SBBR specification.
> This also resolves an error reported by acpiview command, as seen on
> the RPi (see https://github.com/pftf/RPi4/issues/25).
>
> Cc: Dandan Bi <dandan.bi@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Hao A Wu <hao.a.wu@intel.com>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
>
> Signed-off-by: Samer El-Haj-Mahmoud <samer@elhajmahmoud.com>
> Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Reviewed-by: Dandan Bi <dandan.bi@intel.com>
> ---
> MdeModulePkg/MdeModulePkg.dec | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/MdeModulePkg/MdeModulePkg.dec
> b/MdeModulePkg/MdeModulePkg.dec
> index 497574cb0870..fac16f262cf8 100644
> --- a/MdeModulePkg/MdeModulePkg.dec
> +++ b/MdeModulePkg/MdeModulePkg.dec
> @@ -1548,6 +1548,9 @@
> # @Prompt Console Output Row of Text Setup
>
> gEfiMdeModulePkgTokenSpaceGuid.PcdSetupConOutRow|25|UINT32|0x40
> 00000e
>
> +[PcdsFixedAtBuild.AARCH64, PcdsPatchableInModule.AARCH64]
> +
> gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiExposedTableVersions|0x20|UI
> NT32|0x0001004c
> +
Sorry for the slow response.
Acked-by: Hao A Wu <hao.a.wu@intel.com>
Best Regards,
Hao Wu
> [PcdsFixedAtBuild, PcdsPatchableInModule, PcdsDynamic, PcdsDynamicEx]
> ## UART clock frequency is for the baud rate configuration.
> # @Prompt Serial Port Clock Rate.
> --
> 2.17.1
next prev parent reply other threads:[~2020-04-21 8:54 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-10 15:29 [edk2][PATCH v2 0/2] ACPI table defailt for Aarch64 Samer El-Haj-Mahmoud
2020-04-10 15:29 ` [edk2][PATCH v2 1/2] MdeModulePkg: PcdAcpiExposedTableVersions default for Arm64 platforms Samer El-Haj-Mahmoud
2020-04-14 9:45 ` [edk2-devel] " Sami Mujawar
2020-04-14 13:33 ` Samer El-Haj-Mahmoud
2020-04-18 15:14 ` Samer El-Haj-Mahmoud
2020-04-20 12:15 ` Laszlo Ersek
2020-04-21 4:56 ` Dandan Bi
2020-04-21 8:41 ` Laszlo Ersek
2020-04-21 8:46 ` Liming Gao
2020-04-21 8:54 ` Wu, Hao A [this message]
2020-04-21 17:06 ` Ard Biesheuvel
2020-04-10 15:29 ` [edk2][PATCH v2 2/2] Revert "ArmVirtPkg/ArmVirtQemu: limit ACPI support to v5.0 and higher" Samer El-Haj-Mahmoud
2020-04-14 12:19 ` [edk2-devel] " Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B80AF82E9BFB8E4FBD8C89DA810C6A093C9EC3AD@SHSMSX104.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox