From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mx.groups.io with SMTP id smtpd.web12.2679.1587631843816825860 for ; Thu, 23 Apr 2020 01:50:43 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.115, mailfrom: hao.a.wu@intel.com) IronPort-SDR: ++yhvYcnlB0H+YjTcfZ/JJR+vb+lU2z2h/jqys6h54CgLclr8HASjWp/hA/7rieAUvH3+My38A S/dFnkfBFaUg== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Apr 2020 01:50:43 -0700 IronPort-SDR: ufcJY3b4Ne1cfli4bF1TR4k3BQ4UVMf31yk11culeHh2UOC7Nt8njfMKsQ16ZCK6ReTAtzWI2N 8n27ApizEX3A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,306,1583222400"; d="scan'208";a="334901314" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga001.jf.intel.com with ESMTP; 23 Apr 2020 01:50:42 -0700 Received: from fmsmsx152.amr.corp.intel.com (10.18.125.5) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 23 Apr 2020 01:50:22 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by FMSMSX152.amr.corp.intel.com (10.18.125.5) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 23 Apr 2020 01:50:21 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.225]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.22]) with mapi id 14.03.0439.000; Thu, 23 Apr 2020 16:50:19 +0800 From: "Wu, Hao A" To: "devel@edk2.groups.io" , "Ni, Ray" , Laszlo Ersek CC: "Dong, Eric" Subject: Re: [edk2-devel] [PATCH v1] UefiCpuPkg/MpInitLib: Add missing explicit PcdLib dependency Thread-Topic: [edk2-devel] [PATCH v1] UefiCpuPkg/MpInitLib: Add missing explicit PcdLib dependency Thread-Index: AQHWGHMV4hvpwq7wTki+BcEyJG2k2qiGZ0Dw Date: Thu, 23 Apr 2020 08:50:18 +0000 Message-ID: References: <20200422065549.10880-1-hao.a.wu@intel.com> In-Reply-To: <20200422065549.10880-1-hao.a.wu@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: hao.a.wu@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Wu, Hao A > Sent: Wednesday, April 22, 2020 2:56 PM > To: devel@edk2.groups.io > Cc: Wu, Hao A; Dong, Eric; Ni, Ray; Laszlo Ersek > Subject: [edk2-devel] [PATCH v1] UefiCpuPkg/MpInitLib: Add missing expli= cit > PcdLib dependency >=20 > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D2632 >=20 > Both PEI and DXE instances of the MpInitLib are using PcdLib APIs, but > none of them list the dependency of the PcdLib in INF & header files. >=20 > This commit will explicitly add such dependency in .H and .INF files. >=20 > Test done: > Library level build pass for VS2015x86 tool chain >=20 > Cc: Eric Dong > Cc: Ray Ni > Cc: Laszlo Ersek > Signed-off-by: Hao A Wu Thanks Ray and Laszlo, Patch pushed via commit d5339c04d7. Best Regards, Hao Wu > --- > UefiCpuPkg/Library/MpInitLib/DxeMpInitLib.inf | 1 + > UefiCpuPkg/Library/MpInitLib/PeiMpInitLib.inf | 1 + > UefiCpuPkg/Library/MpInitLib/MpLib.h | 1 + > 3 files changed, 3 insertions(+) >=20 > diff --git a/UefiCpuPkg/Library/MpInitLib/DxeMpInitLib.inf > b/UefiCpuPkg/Library/MpInitLib/DxeMpInitLib.inf > index a51a9ec1d2..9907f4157b 100644 > --- a/UefiCpuPkg/Library/MpInitLib/DxeMpInitLib.inf > +++ b/UefiCpuPkg/Library/MpInitLib/DxeMpInitLib.inf > @@ -51,6 +51,7 @@ [LibraryClasses] > UefiBootServicesTableLib > DebugAgentLib > SynchronizationLib > + PcdLib >=20 > [Protocols] > gEfiTimerArchProtocolGuid ## SOMETIMES_CONSUMES > diff --git a/UefiCpuPkg/Library/MpInitLib/PeiMpInitLib.inf > b/UefiCpuPkg/Library/MpInitLib/PeiMpInitLib.inf > index d78d328b42..89ee9a79d8 100644 > --- a/UefiCpuPkg/Library/MpInitLib/PeiMpInitLib.inf > +++ b/UefiCpuPkg/Library/MpInitLib/PeiMpInitLib.inf > @@ -50,6 +50,7 @@ [LibraryClasses] > UefiCpuLib > SynchronizationLib > PeiServicesLib > + PcdLib >=20 > [Pcd] > gUefiCpuPkgTokenSpaceGuid.PcdCpuMaxLogicalProcessorNumber ## > CONSUMES > diff --git a/UefiCpuPkg/Library/MpInitLib/MpLib.h > b/UefiCpuPkg/Library/MpInitLib/MpLib.h > index 74e919dae0..a8ca03efb8 100755 > --- a/UefiCpuPkg/Library/MpInitLib/MpLib.h > +++ b/UefiCpuPkg/Library/MpInitLib/MpLib.h > @@ -31,6 +31,7 @@ > #include > #include > #include > +#include >=20 > #include >=20 > -- > 2.12.0.windows.1 >=20 >=20 >=20