From: "Wu, Hao A" <hao.a.wu@intel.com>
To: "Ni, Ruiyu" <ruiyu.ni@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [PATCH] ShellPkg/Ls: Handle the case when SearchString is NULL
Date: Tue, 16 Aug 2016 07:37:05 +0000 [thread overview]
Message-ID: <B80AF82E9BFB8E4FBD8C89DA810C6A09CC499E@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <20160816073253.357040-1-ruiyu.ni@intel.com>
Reviewed-by: Hao Wu <hao.a.wu@intel.com>
Best Regards,
Hao Wu
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Ruiyu
> Ni
> Sent: Tuesday, August 16, 2016 3:33 PM
> To: edk2-devel@lists.01.org
> Cc: Wu, Hao A
> Subject: [edk2] [PATCH] ShellPkg/Ls: Handle the case when SearchString is
> NULL
>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
> Cc: Hao Wu <hao.a.wu@intel.com>
> ---
> ShellPkg/Library/UefiShellLevel2CommandsLib/Ls.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/ShellPkg/Library/UefiShellLevel2CommandsLib/Ls.c
> b/ShellPkg/Library/UefiShellLevel2CommandsLib/Ls.c
> index 0b80195..9b4c452 100644
> --- a/ShellPkg/Library/UefiShellLevel2CommandsLib/Ls.c
> +++ b/ShellPkg/Library/UefiShellLevel2CommandsLib/Ls.c
> @@ -709,6 +709,11 @@ ShellCommandRunLs (
> // must split off the search part that applies to files from the end of
> the directory part
> //
> StrnCatGrow(&SearchString, NULL, FullPath, 0);
> + if (SearchString == NULL) {
> + FreePool (FullPath);
> + ShellCommandLineFreeVarList (Package);
> + return SHELL_OUT_OF_RESOURCES;
> + }
> PathRemoveLastItem (FullPath);
> CopyMem (SearchString, SearchString + StrLen (FullPath), StrSize
> (SearchString + StrLen (FullPath)));
> }
> --
> 2.9.0.windows.1
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
prev parent reply other threads:[~2016-08-16 7:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-16 7:32 [PATCH] ShellPkg/Ls: Handle the case when SearchString is NULL Ruiyu Ni
2016-08-16 7:37 ` Wu, Hao A [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B80AF82E9BFB8E4FBD8C89DA810C6A09CC499E@SHSMSX101.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox