Re: [PATCH 1/3] Platform/Qemu/SbsaQemu/SbsaQemu.dsc: define XHCI Pcd settings

Re: [PATCH 1/3] Platform/Qemu/SbsaQemu/SbsaQemu.dsc: define XHCI Pcd settings

[chenbaozi]

Hi, Yuquan

> On Jun 5, 2023, at 16:54, Yuquan Wang <wangyuquan1236@phytium.com.cn> wrote:
> 
> Define the pcd settings for identifying the base address of XHCI
> and XHCI's mmio size, and remove relevant EHCI settings.
> 
> Signed-off-by: Yuquan Wang <wangyuquan1236@phytium.com.cn>
> Change-Id: Ic144e7125332de5f2f2151f3b6856bd095c95a58

Please remove Change-Id, which is used for the Gerrit internally.

Cheers,

Baozi.

[PATCH 0/3] use XHCI to replace EHCI

[wangyuquan1236]

This patchset implements XHCI on sbsa-ref board to replace EHCI.
As sbsa-ref does not have DRAM below 4G, it cannot utilize EHCI 
that only has 32-bit DMA capablity. Now this board has XHCI as 
an available usb controller with 64-bit DMA capablity.
 
Yuquan Wang (3):
  Platform/Qemu/SbsaQemu/SbsaQemu.dsc: define XHCI Pcd settings
  SbsaQemu: Drivers: Add initial support for XHCI
  SbsaQemu: AcpiTables: Add XHCI info into DSDT

 Platform/Qemu/SbsaQemu/SbsaQemu.dsc           |   6 +-
 .../Qemu/SbsaQemu/AcpiTables/AcpiTables.inf   |   4 +-
 Silicon/Qemu/SbsaQemu/AcpiTables/Dsdt.asl     | 125 ++----------------
 .../SbsaQemuPlatformDxe/SbsaQemuPlatformDxe.c |  40 ++++--
 .../SbsaQemuPlatformDxe.inf                   |   2 +
 Silicon/Qemu/SbsaQemu/SbsaQemu.dec            |   4 +-
 6 files changed, 53 insertions(+), 128 deletions(-)

-- 
2.34.1

[PATCH 1/3] Platform/Qemu/SbsaQemu/SbsaQemu.dsc: define XHCI Pcd settings

[wangyuquan1236]

Define the pcd settings for identifying the base address of XHCI
and XHCI's mmio size, and remove relevant EHCI settings.

Signed-off-by: Yuquan Wang <wangyuquan1236@phytium.com.cn>
Change-Id: Ic144e7125332de5f2f2151f3b6856bd095c95a58
---
 Platform/Qemu/SbsaQemu/SbsaQemu.dsc | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/Platform/Qemu/SbsaQemu/SbsaQemu.dsc b/Platform/Qemu/SbsaQemu/SbsaQemu.dsc
index 79dd200c..7ffe8635 100644
--- a/Platform/Qemu/SbsaQemu/SbsaQemu.dsc
+++ b/Platform/Qemu/SbsaQemu/SbsaQemu.dsc
@@ -435,11 +435,11 @@ DEFINE NETWORK_HTTP_BOOT_ENABLE       = FALSE
   # Initial Device Tree Location
   gArmVirtSbsaQemuPlatformTokenSpaceGuid.PcdDeviceTreeBaseAddress|0x10000000000
 
-  # Non discoverable devices (AHCI,EHCI)
+  # Non discoverable devices (AHCI,XHCI)
   gArmVirtSbsaQemuPlatformTokenSpaceGuid.PcdPlatformAhciBase|0x60100000
   gArmVirtSbsaQemuPlatformTokenSpaceGuid.PcdPlatformAhciSize|0x00010000
-  gArmVirtSbsaQemuPlatformTokenSpaceGuid.PcdPlatformEhciBase|0x60110000
-  gArmVirtSbsaQemuPlatformTokenSpaceGuid.PcdPlatformEhciSize|0x00010000
+  gArmVirtSbsaQemuPlatformTokenSpaceGuid.PcdPlatformXhciBase|0x60110000
+  gArmVirtSbsaQemuPlatformTokenSpaceGuid.PcdPlatformXhciSize|0x00010000
 
   # PL011 - Serial Terminal
   gEfiMdeModulePkgTokenSpaceGuid.PcdSerialRegisterBase|0x60000000
-- 
2.34.1