public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Zhu, Yonghong" <yonghong.zhu@intel.com>
To: "Gao, Liming" <liming.gao@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [Patch 0/4] Add support for running python tools from source on Windows
Date: Wed, 21 Sep 2016 02:50:45 +0000	[thread overview]
Message-ID: <B9726D6DCCFB8B4CA276A9169B02216D4F3916EE@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <1473696210-6264-1-git-send-email-liming.gao@intel.com>

Reviewed the series of 4 patches.
Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com> 

Best Regards,
Zhu Yonghong


-----Original Message-----
From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Liming Gao
Sent: Tuesday, September 13, 2016 12:03 AM
To: edk2-devel@lists.01.org
Subject: [edk2] [Patch 0/4] Add support for running python tools from source on Windows

When Python tool exe files don't exist, toolsetup.bat will configure PYTHONPATH to python source code, and set BaseTools\BinWrappers\WindowsLike into system PATH directory. Then, windows batch files will be used to run python tools from source files. 

Liming Gao (4):
  BaseTools: Add Windows batch files to run python tool from Source
  BaseTools: Update python tool to call external tools with shell true
    mode
  BaseTools: Update Python Makefile not to depend on PYTHON_FREEZER_PATH
  BaseTools: Update toolsetup.bat to set PYTHONPATH env to run python
    source

 BaseTools/BinWrappers/WindowsLike/BPDG.bat         |   3 +
 BaseTools/BinWrappers/WindowsLike/Ecc.bat          |   3 +
 BaseTools/BinWrappers/WindowsLike/GenDepex.bat     |   3 +
 BaseTools/BinWrappers/WindowsLike/GenFds.bat       |   3 +
 .../BinWrappers/WindowsLike/GenPatchPcdTable.bat   |   3 +
 .../BinWrappers/WindowsLike/PatchPcdValue.bat      |   3 +
 BaseTools/BinWrappers/WindowsLike/Pkcs7Sign.bat    |   3 +
 .../WindowsLike/Rsa2048Sha256GenerateKeys.bat      |   1 +
 .../BinWrappers/WindowsLike/Rsa2048Sha256Sign.bat  |   3 +
 BaseTools/BinWrappers/WindowsLike/TargetTool.bat   |   3 +
 BaseTools/BinWrappers/WindowsLike/Trim.bat         |   3 +
 BaseTools/BinWrappers/WindowsLike/UPT.bat          |   3 +
 BaseTools/BinWrappers/WindowsLike/build.bat        |   3 +
 BaseTools/Source/Python/Common/VpdInfoFile.py      |   7 +-
 BaseTools/Source/Python/Makefile                   |  17 +++-
 BaseTools/Source/Python/build/build.py             |   5 +-
 BaseTools/toolsetup.bat                            | 101 +++++++++------------
 17 files changed, 100 insertions(+), 67 deletions(-)  create mode 100644 BaseTools/BinWrappers/WindowsLike/BPDG.bat
 create mode 100644 BaseTools/BinWrappers/WindowsLike/Ecc.bat
 create mode 100644 BaseTools/BinWrappers/WindowsLike/GenDepex.bat
 create mode 100644 BaseTools/BinWrappers/WindowsLike/GenFds.bat
 create mode 100644 BaseTools/BinWrappers/WindowsLike/GenPatchPcdTable.bat
 create mode 100644 BaseTools/BinWrappers/WindowsLike/PatchPcdValue.bat
 create mode 100644 BaseTools/BinWrappers/WindowsLike/Pkcs7Sign.bat
 create mode 100644 BaseTools/BinWrappers/WindowsLike/Rsa2048Sha256GenerateKeys.bat
 create mode 100644 BaseTools/BinWrappers/WindowsLike/Rsa2048Sha256Sign.bat
 create mode 100644 BaseTools/BinWrappers/WindowsLike/TargetTool.bat
 create mode 100644 BaseTools/BinWrappers/WindowsLike/Trim.bat
 create mode 100644 BaseTools/BinWrappers/WindowsLike/UPT.bat
 create mode 100644 BaseTools/BinWrappers/WindowsLike/build.bat

--
2.8.0.windows.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel


      parent reply	other threads:[~2016-09-21  2:50 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-12 16:03 [Patch 0/4] Add support for running python tools from source on Windows Liming Gao
2016-09-12 16:03 ` [Patch 1/4] BaseTools: Add Windows batch files to run python tool from Source Liming Gao
2016-09-12 23:59   ` Bjorge, Erik C
2016-09-12 16:03 ` [Patch 2/4] BaseTools: Update python tool to call external tools with shell true mode Liming Gao
2016-09-13  0:00   ` Bjorge, Erik C
2016-09-12 16:03 ` [Patch 3/4] BaseTools: Update Python Makefile not to depend on PYTHON_FREEZER_PATH Liming Gao
2016-09-13  0:00   ` Bjorge, Erik C
2016-09-12 16:03 ` [Patch 4/4] BaseTools: Update toolsetup.bat to set PYTHONPATH env to run python source Liming Gao
2016-09-13  0:13   ` Bjorge, Erik C
2016-09-21  2:50 ` Zhu, Yonghong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=B9726D6DCCFB8B4CA276A9169B02216D4F3916EE@SHSMSX103.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox