Re: [Patch] BaseTools Build: Fix build break for clean target in Linux

["Zhu, Yonghong" <yonghong.zhu@intel.com>]

Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com> 

Best Regards,
Zhu Yonghong

-----Original Message-----
From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Liming Gao
Sent: Thursday, September 29, 2016 10:48 PM
To: edk2-devel@lists.01.org
Cc: Wu, Hao A <hao.a.wu@intel.com>
Subject: [edk2] [Patch] BaseTools Build: Fix build break for clean target in Linux

From: Hao Wu <hao.a.wu@intel.com>

In Linux, Command needs to be String instead of list when Command run as shell with True.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Liming Gao <liming.gao@intel.com>
---
 BaseTools/Source/Python/build/build.py | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/BaseTools/Source/Python/build/build.py b/BaseTools/Source/Python/build/build.py
index b003c67..f17b55c 100644
--- a/BaseTools/Source/Python/build/build.py
+++ b/BaseTools/Source/Python/build/build.py
@@ -265,10 +265,10 @@ def LaunchCommand(Command, WorkingDir):
     # It could be a string or sequence. We find that if command is a string in following Popen(),
     # ubuntu may fail with an error message that the command is not found.
     # So here we may need convert command from string to list instance.
-    if not isinstance(Command, list):
-        if platform.system() != 'Windows':
+    if platform.system() != 'Windows':
+        if not isinstance(Command, list):
             Command = Command.split()
-            Command = ' '.join(Command)
+        Command = ' '.join(Command)
 
     Proc = None
     EndOfProcedure = None
--
2.8.0.windows.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel