From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 25D321A1E3E for ; Thu, 29 Sep 2016 21:40:54 -0700 (PDT) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga104.jf.intel.com with ESMTP; 29 Sep 2016 21:40:53 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,418,1473145200"; d="scan'208";a="174828112" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga004.fm.intel.com with ESMTP; 29 Sep 2016 21:40:53 -0700 Received: from fmsmsx156.amr.corp.intel.com (10.18.116.74) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 29 Sep 2016 21:40:53 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx156.amr.corp.intel.com (10.18.116.74) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 29 Sep 2016 21:40:53 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.234]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.95]) with mapi id 14.03.0248.002; Fri, 30 Sep 2016 12:40:51 +0800 From: "Zhu, Yonghong" To: "Gao, Liming" , "edk2-devel@lists.01.org" CC: "Wu, Hao A" , "Zhu, Yonghong" Thread-Topic: [edk2] [Patch] BaseTools Build: Fix build break for clean target in Linux Thread-Index: AQHSGmCL3fO614ubEU+6aYFLHQJgy6CRcvew Date: Fri, 30 Sep 2016 04:40:49 +0000 Message-ID: References: <1475160458-16540-1-git-send-email-liming.gao@intel.com> In-Reply-To: <1475160458-16540-1-git-send-email-liming.gao@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMDliZWI1YmQtZDQxYi00MWRiLTg2ODItYTBmN2U5MDFmNzhhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IkpoYXN1R0FIdkpCMlc4bzl4UjhsQmx3XC8xaVEzTE93ejZOUGVVSXV0NUtRPSJ9 x-ctpclassification: CTP_IC x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [Patch] BaseTools Build: Fix build break for clean target in Linux X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Sep 2016 04:40:54 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Yonghong Zhu =20 Best Regards, Zhu Yonghong -----Original Message----- From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Limi= ng Gao Sent: Thursday, September 29, 2016 10:48 PM To: edk2-devel@lists.01.org Cc: Wu, Hao A Subject: [edk2] [Patch] BaseTools Build: Fix build break for clean target i= n Linux From: Hao Wu In Linux, Command needs to be String instead of list when Command run as sh= ell with True. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Liming Gao --- BaseTools/Source/Python/build/build.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/BaseTools/Source/Python/build/build.py b/BaseTools/Source/Pyth= on/build/build.py index b003c67..f17b55c 100644 --- a/BaseTools/Source/Python/build/build.py +++ b/BaseTools/Source/Python/build/build.py @@ -265,10 +265,10 @@ def LaunchCommand(Command, WorkingDir): # It could be a string or sequence. We find that if command is a strin= g in following Popen(), # ubuntu may fail with an error message that the command is not found. # So here we may need convert command from string to list instance. - if not isinstance(Command, list): - if platform.system() !=3D 'Windows': + if platform.system() !=3D 'Windows': + if not isinstance(Command, list): Command =3D Command.split() - Command =3D ' '.join(Command) + Command =3D ' '.join(Command) =20 Proc =3D None EndOfProcedure =3D None -- 2.8.0.windows.1 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel