Re: [PATCH] Add NOOPT build targets to OvmfPkg for source level debugging

["Zhu, Yonghong" <yonghong.zhu@intel.com>]

Looks good to me.
When the BaseTools' support for NOOPT is reviewed and pushed, I will inform to you. Thanks.

Best Regards,
Zhu Yonghong


-----Original Message-----
From: Laszlo Ersek [mailto:lersek@redhat.com] 
Sent: Tuesday, October 11, 2016 12:30 AM
To: Bruce Cran <bruce@cran.org.uk>
Cc: edk2-devel@lists.01.org <edk2-devel@ml01.01.org>; Zhu, Yonghong <yonghong.zhu@intel.com>
Subject: Re: [PATCH] Add NOOPT build targets to OvmfPkg for source level debugging

On 10/10/16 18:27, Laszlo Ersek wrote:
> On 10/10/16 17:43, Bruce Cran wrote:
>>
>>
>> 0001-Add-NOOPT-build-targets-to-OvmfPkg-for-source-level-.patch
>>
>>
>> From ef7b3dfe26bb7748d838974af57cd73e40e24c94 Mon Sep 17 00:00:00 
>> 2001
>> From: Bruce Cran <Bruce.Cran@sandisk.com>
>> Date: Mon, 10 Oct 2016 09:35:50 -0600
>> Subject: [PATCH] Add NOOPT build targets to OvmfPkg for source level 
>> debugging
>>
>> Contributed-under: TianoCore Contribution Agreement 1.0
>> Cc: Yonghong Zhu <yonghong.zhu@intel.com>
>> Cc: Laszlo Ersek <lersek@redhat.com>
>> Signed-off-by: Bruce Cran <bruce.cran@sandisk.com>
>> ---
>>  OvmfPkg/OvmfPkgIa32.dsc    | 2 +-
>>  OvmfPkg/OvmfPkgIa32X64.dsc | 2 +-
>>  OvmfPkg/OvmfPkgX64.dsc     | 2 +-
>>  3 files changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/OvmfPkg/OvmfPkgIa32.dsc b/OvmfPkg/OvmfPkgIa32.dsc index 
>> 7213197..41500ca 100644
>> --- a/OvmfPkg/OvmfPkgIa32.dsc
>> +++ b/OvmfPkg/OvmfPkgIa32.dsc
>> @@ -26,7 +26,7 @@
>>    DSC_SPECIFICATION              = 0x00010005
>>    OUTPUT_DIRECTORY               = Build/OvmfIa32
>>    SUPPORTED_ARCHITECTURES        = IA32
>> -  BUILD_TARGETS                  = DEBUG|RELEASE
>> +  BUILD_TARGETS                  = NOOPT|DEBUG|RELEASE
>>    SKUID_IDENTIFIER               = DEFAULT
>>    FLASH_DEFINITION               = OvmfPkg/OvmfPkgIa32.fdf
>>  
>> diff --git a/OvmfPkg/OvmfPkgIa32X64.dsc b/OvmfPkg/OvmfPkgIa32X64.dsc 
>> index c27024a..1bd4b21 100644
>> --- a/OvmfPkg/OvmfPkgIa32X64.dsc
>> +++ b/OvmfPkg/OvmfPkgIa32X64.dsc
>> @@ -26,7 +26,7 @@
>>    DSC_SPECIFICATION              = 0x00010005
>>    OUTPUT_DIRECTORY               = Build/Ovmf3264
>>    SUPPORTED_ARCHITECTURES        = IA32|X64
>> -  BUILD_TARGETS                  = DEBUG|RELEASE
>> +  BUILD_TARGETS                  = NOOPT|DEBUG|RELEASE
>>    SKUID_IDENTIFIER               = DEFAULT
>>    FLASH_DEFINITION               = OvmfPkg/OvmfPkgIa32X64.fdf
>>  
>> diff --git a/OvmfPkg/OvmfPkgX64.dsc b/OvmfPkg/OvmfPkgX64.dsc index 
>> c34b266..460f7bb 100644
>> --- a/OvmfPkg/OvmfPkgX64.dsc
>> +++ b/OvmfPkg/OvmfPkgX64.dsc
>> @@ -26,7 +26,7 @@
>>    DSC_SPECIFICATION              = 0x00010005
>>    OUTPUT_DIRECTORY               = Build/OvmfX64
>>    SUPPORTED_ARCHITECTURES        = X64
>> -  BUILD_TARGETS                  = DEBUG|RELEASE
>> +  BUILD_TARGETS                  = NOOPT|DEBUG|RELEASE
>>    SKUID_IDENTIFIER               = DEFAULT
>>    FLASH_DEFINITION               = OvmfPkg/OvmfPkgX64.fdf
>>  
>> -- 2.10.0
>>
> 
> Looks good to me:
> 
> Reviewed-by: Laszlo Ersek <lersek@redhat.com>
> 
> but we should hold it until Yonghong's v4 is posted / reviewed / pushed.

(maybe the subject can be rewritten as

  OvmfPkg: add NOOPT build target for source level debugging

but I can do that later when I commit the patch.)