From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id BFE6E1A1E30 for ; Tue, 11 Oct 2016 21:13:25 -0700 (PDT) Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga105.fm.intel.com with ESMTP; 11 Oct 2016 21:13:25 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,332,1473145200"; d="scan'208";a="18696306" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga005.fm.intel.com with ESMTP; 11 Oct 2016 21:13:25 -0700 Received: from fmsmsx125.amr.corp.intel.com (10.18.125.40) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 11 Oct 2016 21:13:25 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by FMSMSX125.amr.corp.intel.com (10.18.125.40) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 11 Oct 2016 21:13:25 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.139]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.104]) with mapi id 14.03.0248.002; Wed, 12 Oct 2016 12:13:23 +0800 From: "Zhu, Yonghong" To: "Kinney, Michael D" , "edk2-devel@lists.01.org" CC: "Steele, Kelly" , "Gao, Liming" , "Zhu, Yonghong" Thread-Topic: [Patch 1/2] BaseTools/GenFds: Support FDF sections in any order Thread-Index: AQHSIOJwxOJEqxZVLEWM1LPj7QLAgKCkOrJw Date: Wed, 12 Oct 2016 04:13:22 +0000 Message-ID: References: <1475875986-9148-1-git-send-email-michael.d.kinney@intel.com> <1475875986-9148-2-git-send-email-michael.d.kinney@intel.com> In-Reply-To: <1475875986-9148-2-git-send-email-michael.d.kinney@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [Patch 1/2] BaseTools/GenFds: Support FDF sections in any order X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 Oct 2016 04:13:26 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable This patch is fine to me. Reviewed-by: Yonghong Zhu =20 Best Regards, Zhu Yonghong -----Original Message----- From: Kinney, Michael D=20 Sent: Saturday, October 08, 2016 5:33 AM To: edk2-devel@lists.01.org Cc: Steele, Kelly ; Zhu, Yonghong ; Gao, Liming Subject: [Patch 1/2] BaseTools/GenFds: Support FDF sections in any order https://bugzilla.tianocore.org/show_bug.cgi?id=3D141 This patch updates EDK II FDF parser in GenFds to allow sections to be plac= ed in any order in the FDF file. Cc: Kelly Steele Cc: Yonghong Zhu Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Michael Kinney --- BaseTools/Source/Python/GenFds/FdfParser.py | 23 ++++------------------- 1 file changed, 4 insertions(+), 19 deletions(-) diff --git a/BaseTools/Source/Python/GenFds/FdfParser.py b/BaseTools/Source= /Python/GenFds/FdfParser.py index 02ae7c9..693128c 100644 --- a/BaseTools/Source/Python/GenFds/FdfParser.py +++ b/BaseTools/Source/Python/GenFds/FdfParser.py @@ -1385,25 +1385,10 @@ class FdfParser: =20 try: self.Preprocess() - while self.__GetFd(): - pass - - while self.__GetFv(): - pass - - while self.__GetFmp(): - pass - - while self.__GetCapsule(): - pass - - while self.__GetVtf(): - pass - - while self.__GetRule(): - pass - =20 - while self.__GetOptionRom(): + # + # Keep processing sections of the FDF until no new sections or= a syntax error is found + # + while self.__GetFd() or self.__GetFv() or self.__GetFmp() or s= elf.__GetCapsule() or self.__GetVtf() or self.__GetRule() or self.__GetOpti= onRom(): pass =20 except Warning, X: -- 2.6.3.windows.1