public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Zhu, Yonghong" <yonghong.zhu@intel.com>
To: "Carsey, Jaben" <jaben.carsey@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: Daryl McDaniel <edk2-lists@mc2research.org>,
	"Zhu, Yonghong" <yonghong.zhu@intel.com>
Subject: Re: [Patch] AppPkg: Update email and URL.
Date: Tue, 25 Oct 2016 01:58:44 +0000	[thread overview]
Message-ID: <B9726D6DCCFB8B4CA276A9169B02216D4F3B1B92@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <f244620e7443107f44acd72dab59eef43543eff4.1477326658.git.jaben.carsey@intel.com>

Hi Jaben,

I have two comment: 1. The copyright year need update.  2. The PACKAGE_URL is not same in several pyconfig.h, is this our expected ?

Best Regards,
Zhu Yonghong


-----Original Message-----
From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Jaben Carsey
Sent: Tuesday, October 25, 2016 12:32 AM
To: edk2-devel@lists.01.org
Cc: Daryl McDaniel <edk2-lists@mc2research.org>
Subject: [edk2] [Patch] AppPkg: Update email and URL.

CC: Daryl McDaniel <edk2-lists@mc2research.org>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jaben Carsey <jaben.carsey@intel.com>
---
 AppPkg/Applications/Python/Ia32/pyconfig.h               | 4 ++--
 AppPkg/Applications/Python/Ipf/pyconfig.h                | 4 ++--
 AppPkg/Applications/Python/Python-2.7.10/Ia32/pyconfig.h | 2 +-  AppPkg/Applications/Python/Python-2.7.10/X64/pyconfig.h  | 2 +-
 AppPkg/Applications/Python/X64/pyconfig.h                | 2 +-
 5 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/AppPkg/Applications/Python/Ia32/pyconfig.h b/AppPkg/Applications/Python/Ia32/pyconfig.h
index 7970f14..6a53801 100644
--- a/AppPkg/Applications/Python/Ia32/pyconfig.h
+++ b/AppPkg/Applications/Python/Ia32/pyconfig.h
@@ -932,7 +932,7 @@
 #undef MVWDELCH_IS_EXPRESSION
 
 /* Define to the address where bug reports for this package should be sent. */
-#define PACKAGE_BUGREPORT   "edk2-devel@lists.sourceforge.net"
+#define PACKAGE_BUGREPORT   "edk2-devel@lists.01.org"
 
 /* Define to the full name of this package. */
 #define PACKAGE_NAME    "EDK II Python Package"
@@ -944,7 +944,7 @@
 #define PACKAGE_TARNAME   "EADK_Python"
 
 /* Define to the home page for this package. */
-#define PACKAGE_URL   "http://edk2.tianocore.org/toolkit/python"
+#define PACKAGE_URL   "https://github.com/tianocore/edk2/tree/master/AppPkg/Applications/Python"
 
 /* Define to the version of this package. */  #define PACKAGE_VERSION  "V0.8"
diff --git a/AppPkg/Applications/Python/Ipf/pyconfig.h b/AppPkg/Applications/Python/Ipf/pyconfig.h
index 5b06024..fe723a2 100644
--- a/AppPkg/Applications/Python/Ipf/pyconfig.h
+++ b/AppPkg/Applications/Python/Ipf/pyconfig.h
@@ -928,7 +928,7 @@
 #undef MVWDELCH_IS_EXPRESSION
 
 /* Define to the address where bug reports for this package should be sent. */
-#define PACKAGE_BUGREPORT   "edk2-devel@lists.sourceforge.net"
+#define PACKAGE_BUGREPORT   "edk2-devel@lists.01.org"
 
 /* Define to the full name of this package. */
 #define PACKAGE_NAME    "EDK II Python Package"
@@ -940,7 +940,7 @@
 #define PACKAGE_TARNAME   "EADK_Python"
 
 /* Define to the home page for this package. */
-#define PACKAGE_URL   "http://edk2.tianocore.org/toolkit/python"
+#define PACKAGE_URL   "https://github.com/tianocore/edk2/tree/master/AppPkg/Applications/Python"
 
 /* Define to the version of this package. */  #define PACKAGE_VERSION  "V0.8"
diff --git a/AppPkg/Applications/Python/Python-2.7.10/Ia32/pyconfig.h b/AppPkg/Applications/Python/Python-2.7.10/Ia32/pyconfig.h
index b86cfa5..2f00eac 100644
--- a/AppPkg/Applications/Python/Python-2.7.10/Ia32/pyconfig.h
+++ b/AppPkg/Applications/Python/Python-2.7.10/Ia32/pyconfig.h
@@ -983,7 +983,7 @@
 #define PACKAGE_TARNAME   "EADK_Python"
 
 /* Define to the home page for this package. */
-#define PACKAGE_URL   "http://edk2.tianocore.org/"
+#define PACKAGE_URL   "http://www.tianocore.org/"
 
 /* Define to the version of this package. */  #define PACKAGE_VERSION  "V0.1"
diff --git a/AppPkg/Applications/Python/Python-2.7.10/X64/pyconfig.h b/AppPkg/Applications/Python/Python-2.7.10/X64/pyconfig.h
index 4b08254..dfe798b 100644
--- a/AppPkg/Applications/Python/Python-2.7.10/X64/pyconfig.h
+++ b/AppPkg/Applications/Python/Python-2.7.10/X64/pyconfig.h
@@ -982,7 +982,7 @@
 #define PACKAGE_TARNAME   "EADK_Python"
 
 /* Define to the home page for this package. */
-#define PACKAGE_URL   "http://edk2.tianocore.org/"
+#define PACKAGE_URL   "http://www.tianocore.org/"
 
 /* Define to the version of this package. */  #define PACKAGE_VERSION  "V0.1"
diff --git a/AppPkg/Applications/Python/X64/pyconfig.h b/AppPkg/Applications/Python/X64/pyconfig.h
index 325c0cb..129c362 100644
--- a/AppPkg/Applications/Python/X64/pyconfig.h
+++ b/AppPkg/Applications/Python/X64/pyconfig.h
@@ -984,7 +984,7 @@
 #define PACKAGE_TARNAME   "EADK_Python"
 
 /* Define to the home page for this package. */
-#define PACKAGE_URL   "http://edk2.tianocore.org/"
+#define PACKAGE_URL   "http://www.tianocore.org/"
 
 /* Define to the version of this package. */  #define PACKAGE_VERSION  "V0.1"
--
2.7.2.windows.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel


  reply	other threads:[~2016-10-25  1:58 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-24 16:32 [Patch] AppPkg: Update email and URL Jaben Carsey
2016-10-25  1:58 ` Zhu, Yonghong [this message]
2016-10-25 16:53   ` Carsey, Jaben

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=B9726D6DCCFB8B4CA276A9169B02216D4F3B1B92@SHSMSX103.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox