public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Zhu, Yonghong" <yonghong.zhu@intel.com>
To: "Gao, Liming" <liming.gao@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [Patch] edksetup.bat: make sure BASE_TOOLS_PATH be set correctly
Date: Wed, 26 Oct 2016 04:32:39 +0000	[thread overview]
Message-ID: <B9726D6DCCFB8B4CA276A9169B02216D4F3B3ACE@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <1477452712-20132-1-git-send-email-liming.gao@intel.com>

Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com> 

Best Regards,
Zhu Yonghong


-----Original Message-----
From: Gao, Liming 
Sent: Wednesday, October 26, 2016 11:32 AM
To: edk2-devel@lists.01.org
Cc: Zhu, Yonghong <yonghong.zhu@intel.com>
Subject: [Patch] edksetup.bat: make sure BASE_TOOLS_PATH be set correctly

Move checkNt32Flag before set BASE_TOOLS_PATH env to make sure it be set

Cc: Yonghong Zhu <yonghong.zhu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Liming Gao <liming.gao@intel.com>
---
 edksetup.bat | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/edksetup.bat b/edksetup.bat index 6c8c0aa..7aa1675 100755
--- a/edksetup.bat
+++ b/edksetup.bat
@@ -77,9 +77,10 @@ if not defined EDK_TOOLS_PATH (
     )
   )
 )
-if exist %EDK_TOOLS_PATH%\Source set BASE_TOOLS_PATH=%EDK_TOOLS_PATH%
 
 :checkNt32Flag
+if exist %EDK_TOOLS_PATH%\Source set BASE_TOOLS_PATH=%EDK_TOOLS_PATH%
+
 @REM The Nt32 Emluation Platform requires Microsoft Libraries  @REM and headers to interface with Windows.
 if /I "%1"=="--nt32" (
--
2.8.0.windows.1



      reply	other threads:[~2016-10-26  4:32 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-26  3:31 [Patch] edksetup.bat: make sure BASE_TOOLS_PATH be set correctly Liming Gao
2016-10-26  4:32 ` Zhu, Yonghong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=B9726D6DCCFB8B4CA276A9169B02216D4F3B3ACE@SHSMSX103.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox