From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) (using TLSv1 with cipher CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 4EA1981D3E for ; Thu, 3 Nov 2016 23:15:48 -0700 (PDT) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga104.fm.intel.com with ESMTP; 03 Nov 2016 23:15:50 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,442,1473145200"; d="scan'208";a="27272745" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga006.fm.intel.com with ESMTP; 03 Nov 2016 23:15:50 -0700 Received: from fmsmsx122.amr.corp.intel.com (10.18.125.37) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 3 Nov 2016 23:15:49 -0700 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by fmsmsx122.amr.corp.intel.com (10.18.125.37) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 3 Nov 2016 23:15:49 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.139]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.209]) with mapi id 14.03.0248.002; Fri, 4 Nov 2016 14:15:47 +0800 From: "Zhu, Yonghong" To: Cinnamon Shia , "edk2-devel@lists.01.org" CC: "Gao, Liming" , "Zhu, Yonghong" Thread-Topic: [PATCH] BaseTools/Edk2Setup.bat: Fix build errors from VS tools PREFIX ENV missing Thread-Index: AQHSNkH16/EeTH3t306zi/lZe9pyeKDIWRyg Date: Fri, 4 Nov 2016 06:15:47 +0000 Message-ID: References: <20161104021946.14924-1-cinnamon.shia@hpe.com> In-Reply-To: <20161104021946.14924-1-cinnamon.shia@hpe.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZTA5ZjhmYWEtN2JiMC00MjZlLTk5MGQtMDc3ODA2ODEwODg2IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6Ik9XMHpkaUlTVEIyVGNmQU5KXC9CTkZBbzFQYU5iMUdQOGtlSFBvMGlBRWlrPSJ9 x-ctpclassification: CTP_IC x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH] BaseTools/Edk2Setup.bat: Fix build errors from VS tools PREFIX ENV missing X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Nov 2016 06:15:48 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Yonghong Zhu =20 Best Regards, Zhu Yonghong -----Original Message----- From: Cinnamon Shia [mailto:cinnamon.shia@hpe.com]=20 Sent: Friday, November 4, 2016 10:20 AM To: edk2-devel@lists.01.org Cc: Zhu, Yonghong ; Gao, Liming ; Cinnamon Shia Subject: [PATCH] BaseTools/Edk2Setup.bat: Fix build errors from VS tools PR= EFIX ENV missing BaseTools/set_vsprefix_envs.bat is introduced for setting the PREFIX ENV of= VS tools in tools_def.template. For example: DEFINE VS2015_BIN =3D ENV(VS2015_PREFIX)Vc\bin DEFINE VS2015_DLL =3D ENV(VS2015_PREFIX)Common7\IDE;DEF(VS2015_BIN) DEFINE VS2015_BINX64 =3D DEF(VS2015_BIN)\x86_amd64 The issue is EdkSetup.bat calls BaseTools\set_vsprefix_envs.bat but Edk2Set= up.bat does not. Edk2Setup.bat should call BaseTools/set_vsprefix_envs.bat to set up the PR= EFIX ENV of VS tools. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Cinnamon Shia --- Edk2Setup.bat | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/Edk2Setup.bat b/Edk2Setup.bat index 68f46dc..017e88d 100755 --- a/Edk2Setup.bat +++ b/Edk2Setup.bat @@ -355,6 +355,15 @@ @if defined REBUILD_TOOLS goto SetConf @if defined SVN_PULL goto SetConf =20 +@REM call set_vsprefix_envs.bat to set up the PREFIX env for VS tool path. +@IF NOT exist "%EDK_TOOLS_PATH%\set_vsprefix_envs.bat" ( + @echo. + @echo !!! ERROR !!! The set_vsprefix_envs.bat was not found !!! + @echo. + @goto ExitFailure +) +@call %EDK_TOOLS_PATH%\set_vsprefix_envs.bat + @echo. @echo Rebuilding of the tools is not required. Binaries of the latest, @e= cho tested versions of the tools have been tested and included in the -- 2.10.0.windows.1