public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [PATCH] BaseTools/Edk2Setup.bat: Fix build errors from VS tools PREFIX ENV missing
@ 2016-11-04  2:19 Cinnamon Shia
  2016-11-04  6:15 ` Zhu, Yonghong
  0 siblings, 1 reply; 2+ messages in thread
From: Cinnamon Shia @ 2016-11-04  2:19 UTC (permalink / raw)
  To: edk2-devel; +Cc: yonghong.zhu, liming.gao, Cinnamon Shia

BaseTools/set_vsprefix_envs.bat is introduced for setting the PREFIX ENV
of VS tools in tools_def.template.
For example:

DEFINE VS2015_BIN      = ENV(VS2015_PREFIX)Vc\bin
DEFINE VS2015_DLL      = ENV(VS2015_PREFIX)Common7\IDE;DEF(VS2015_BIN)
DEFINE VS2015_BINX64   = DEF(VS2015_BIN)\x86_amd64

The issue is EdkSetup.bat calls BaseTools\set_vsprefix_envs.bat but
Edk2Setup.bat does not.

Edk2Setup.bat should call BaseTools/set_vsprefix_envs.bat  to set up the
PREFIX ENV of VS tools.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Cinnamon Shia <cinnamon.shia@hpe.com>
---
 Edk2Setup.bat | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/Edk2Setup.bat b/Edk2Setup.bat
index 68f46dc..017e88d 100755
--- a/Edk2Setup.bat
+++ b/Edk2Setup.bat
@@ -355,6 +355,15 @@
 @if defined REBUILD_TOOLS goto SetConf
 @if defined SVN_PULL goto SetConf
 
+@REM call set_vsprefix_envs.bat to set up the PREFIX env for VS tool path.
+@IF NOT exist "%EDK_TOOLS_PATH%\set_vsprefix_envs.bat" (
+  @echo.
+  @echo !!! ERROR !!! The set_vsprefix_envs.bat was not found !!!
+  @echo.
+  @goto ExitFailure
+)
+@call %EDK_TOOLS_PATH%\set_vsprefix_envs.bat
+
 @echo.
 @echo Rebuilding of the tools is not required. Binaries of the latest,
 @echo tested versions of the tools have been tested and included in the
-- 
2.10.0.windows.1



^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-11-04  6:15 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-04  2:19 [PATCH] BaseTools/Edk2Setup.bat: Fix build errors from VS tools PREFIX ENV missing Cinnamon Shia
2016-11-04  6:15 ` Zhu, Yonghong

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox