public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [Patch 0/2] BaseTools tools_def.txt: Update GCC ASLPP_FLAGS
@ 2016-11-14  6:37 Liming Gao
  2016-11-14  6:37 ` [Patch 1/2] BaseTools tools_def.txt: Remove -P option in " Liming Gao
                   ` (2 more replies)
  0 siblings, 3 replies; 9+ messages in thread
From: Liming Gao @ 2016-11-14  6:37 UTC (permalink / raw)
  To: edk2-devel

Update GCC ASLPP_FLAGS to align to VS ASLPP_FLAGS so that the same ASL file
can support GCC and VS tool chains both. 

Liming Gao (2):
  BaseTools tools_def.txt: Remove -P option in GCC ASLPP_FLAGS
  BaseTools tools_def.txt: Include AutoGen.h in GCC ASLPP_FLAGS

 BaseTools/Conf/tools_def.template | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

-- 
2.8.0.windows.1



^ permalink raw reply	[flat|nested] 9+ messages in thread

* [Patch 1/2] BaseTools tools_def.txt: Remove -P option in GCC ASLPP_FLAGS
  2016-11-14  6:37 [Patch 0/2] BaseTools tools_def.txt: Update GCC ASLPP_FLAGS Liming Gao
@ 2016-11-14  6:37 ` Liming Gao
  2016-11-23 10:09   ` Ard Biesheuvel
  2016-11-14  6:37 ` [Patch 2/2] BaseTools tools_def.txt: Include AutoGen.h " Liming Gao
  2016-11-14  7:21 ` [Patch 0/2] BaseTools tools_def.txt: Update " Zhu, Yonghong
  2 siblings, 1 reply; 9+ messages in thread
From: Liming Gao @ 2016-11-14  6:37 UTC (permalink / raw)
  To: edk2-devel

https://bugzilla.tianocore.org/show_bug.cgi?id=227

After -P option is removed, the generated preprocessed ASL file will have
line markers. The extra information can be removed by Trim script. ASL code
can refer to the definition in C source file. This has been supported in
VS and XCODE tool chains.

Cc: Yonghong Zhu <yonghong.zhu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Liming Gao <liming.gao@intel.com>
---
 BaseTools/Conf/tools_def.template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/BaseTools/Conf/tools_def.template b/BaseTools/Conf/tools_def.template
index 39fda78..fd56ff3 100755
--- a/BaseTools/Conf/tools_def.template
+++ b/BaseTools/Conf/tools_def.template
@@ -4359,7 +4359,7 @@ DEFINE GCC_IPF_SYMRENAME_FLAGS     = --redefine-sym memcpy=CopyMem
 DEFINE GCC_ASM_FLAGS               = -c -x assembler -imacros $(DEST_DIR_DEBUG)/AutoGen.h
 DEFINE GCC_PP_FLAGS                = -E -x assembler-with-cpp -include $(DEST_DIR_DEBUG)/AutoGen.h
 DEFINE GCC_VFRPP_FLAGS             = -x c -E -P -DVFRCOMPILE --include $(DEST_DIR_DEBUG)/$(MODULE_NAME)StrDefs.h
-DEFINE GCC_ASLPP_FLAGS             = -x c -E -P
+DEFINE GCC_ASLPP_FLAGS             = -x c -E
 DEFINE GCC_ASLCC_FLAGS             = -x c
 DEFINE GCC_WINDRES_FLAGS           = -J rc -O coff
 DEFINE GCC_IA32_RC_FLAGS           = -I binary -O elf32-i386          -B i386    --rename-section .data=.hii
@@ -5804,7 +5804,7 @@ RELEASE_CLANG38_X64_CC_FLAGS       = DEF(CLANG38_ALL_CC_FLAGS) -m64 "-DEFIAPI=__
 *_ELFGCC_*_ASL_PATH                     = DEF(UNIX_IASL_BIN)
 *_ELFGCC_*_ASL_FLAGS                    = DEF(IASL_FLAGS)
 *_ELFGCC_*_ASL_OUTFLAGS                 = DEF(IASL_OUTFLAGS)
-*_ELFGCC_*_ASLPP_FLAGS                  = -x c -E -P
+*_ELFGCC_*_ASLPP_FLAGS                  = -x c -E
 *_ELFGCC_*_ASLCC_FLAGS                  = -x c
 *_ELFGCC_*_ASLDLINK_FLAGS               = DEF(GCC_DLINK_FLAGS_COMMON) --entry _ReferenceAcpiTable
 
-- 
2.8.0.windows.1



^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [Patch 2/2] BaseTools tools_def.txt: Include AutoGen.h in GCC ASLPP_FLAGS
  2016-11-14  6:37 [Patch 0/2] BaseTools tools_def.txt: Update GCC ASLPP_FLAGS Liming Gao
  2016-11-14  6:37 ` [Patch 1/2] BaseTools tools_def.txt: Remove -P option in " Liming Gao
@ 2016-11-14  6:37 ` Liming Gao
  2016-11-14  7:21 ` [Patch 0/2] BaseTools tools_def.txt: Update " Zhu, Yonghong
  2 siblings, 0 replies; 9+ messages in thread
From: Liming Gao @ 2016-11-14  6:37 UTC (permalink / raw)
  To: edk2-devel

https://bugzilla.tianocore.org/show_bug.cgi?id=227
Refer to VS ASLPP_FLAGS, force include AutoGen.h so that ASL code
can use FixedPcdGetXX to get FixedPcd value.

Cc: Yonghong Zhu <yonghong.zhu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Liming Gao <liming.gao@intel.com>
---
 BaseTools/Conf/tools_def.template | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/BaseTools/Conf/tools_def.template b/BaseTools/Conf/tools_def.template
index fd56ff3..aaae4fc 100755
--- a/BaseTools/Conf/tools_def.template
+++ b/BaseTools/Conf/tools_def.template
@@ -4359,7 +4359,7 @@ DEFINE GCC_IPF_SYMRENAME_FLAGS     = --redefine-sym memcpy=CopyMem
 DEFINE GCC_ASM_FLAGS               = -c -x assembler -imacros $(DEST_DIR_DEBUG)/AutoGen.h
 DEFINE GCC_PP_FLAGS                = -E -x assembler-with-cpp -include $(DEST_DIR_DEBUG)/AutoGen.h
 DEFINE GCC_VFRPP_FLAGS             = -x c -E -P -DVFRCOMPILE --include $(DEST_DIR_DEBUG)/$(MODULE_NAME)StrDefs.h
-DEFINE GCC_ASLPP_FLAGS             = -x c -E
+DEFINE GCC_ASLPP_FLAGS             = -x c -E -include AutoGen.h
 DEFINE GCC_ASLCC_FLAGS             = -x c
 DEFINE GCC_WINDRES_FLAGS           = -J rc -O coff
 DEFINE GCC_IA32_RC_FLAGS           = -I binary -O elf32-i386          -B i386    --rename-section .data=.hii
@@ -5804,7 +5804,7 @@ RELEASE_CLANG38_X64_CC_FLAGS       = DEF(CLANG38_ALL_CC_FLAGS) -m64 "-DEFIAPI=__
 *_ELFGCC_*_ASL_PATH                     = DEF(UNIX_IASL_BIN)
 *_ELFGCC_*_ASL_FLAGS                    = DEF(IASL_FLAGS)
 *_ELFGCC_*_ASL_OUTFLAGS                 = DEF(IASL_OUTFLAGS)
-*_ELFGCC_*_ASLPP_FLAGS                  = -x c -E
+*_ELFGCC_*_ASLPP_FLAGS                  = -x c -E -include AutoGen.h
 *_ELFGCC_*_ASLCC_FLAGS                  = -x c
 *_ELFGCC_*_ASLDLINK_FLAGS               = DEF(GCC_DLINK_FLAGS_COMMON) --entry _ReferenceAcpiTable
 
@@ -7285,7 +7285,7 @@ RELEASE_XCODE32_IA32_CC_FLAGS   = -arch i386 -Oz -combine -mms-bitfields  -fshor
 
 *_XCODE32_IA32_ASLCC_FLAGS      = -arch i386 -x c -save-temps -g -O0 -mms-bitfields -fshort-wchar -fno-strict-aliasing -Wall -Werror -Wno-missing-braces -c -include AutoGen.h -mdynamic-no-pic
 *_XCODE32_IA32_ASLDLINK_FLAGS   = -arch i386 -e _main -preload -segalign 0x20  -pie -seg1addr 0x220 -read_only_relocs suppress -map $(DEST_DIR_DEBUG)/$(BASE_NAME).map
-*_XCODE32_IA32_ASLPP_FLAGS      = -arch i386 -x c -E
+*_XCODE32_IA32_ASLPP_FLAGS      = -arch i386 -x c -E -include AutoGen.h
 *_XCODE32_IA32_ASL_FLAGS        =
 
 ##################
@@ -7408,7 +7408,7 @@ RELEASE_XCLANG_X64_ASM_FLAGS  = -arch x86_64
 RELEASE_XCLANG_X64_CC_FLAGS   = -ccc-host-triple x86_64-pc-win32-macho -c    -Os  -Wall -Werror -include AutoGen.h -fno-stack-protector -fno-builtin -fshort-wchar -mdynamic-no-pic -Wno-empty-body -Wno-pointer-sign -Wno-unused-function -Wno-unused-value -Wno-missing-braces -Wno-tautological-compare -Wreturn-type -Wno-unused-variable -ftrap-function=undefined_behavior_has_been_optimized_away_by_clang
 *_XCLANG_*_ASLCC_FLAGS      = -x c -save-temps -g -O0 -fshort-wchar -fno-strict-aliasing -Wall -Werror -Wno-missing-braces -c -include AutoGen.h -mdynamic-no-pic
 *_XCLANG_*_ASLDLINK_FLAGS   = -e _main -preload -segalign 0x20  -pie -seg1addr 0x240 -read_only_relocs suppress -map $(DEST_DIR_DEBUG)/$(BASE_NAME).map
-*_XCLANG_*_ASLPP_FLAGS      = -x c -E 
+*_XCLANG_*_ASLPP_FLAGS      = -x c -E -include AutoGen.h
 *_XCLANG_*_ASL_FLAGS        =
 
 #
@@ -7484,7 +7484,7 @@ RELEASE_XCODE5_X64_CC_FLAGS   = -target x86_64-pc-win32-macho -c    -Os       -W
 
 *_XCODE5_*_ASLCC_FLAGS      = -x c -save-temps -g -O0 -fshort-wchar -fno-strict-aliasing -Wall -Werror -Wno-missing-braces -c -include AutoGen.h 
 *_XCODE5_*_ASLDLINK_FLAGS   = -e _ReferenceAcpiTable -preload -segalign 0x20  -pie -seg1addr 0x240 -read_only_relocs suppress -map $(DEST_DIR_DEBUG)/$(BASE_NAME).map
-*_XCODE5_*_ASLPP_FLAGS      = -x c -E 
+*_XCODE5_*_ASLPP_FLAGS      = -x c -E -include AutoGen.h
 *_XCODE5_*_ASL_FLAGS        =
 *_XCODE5_*_ASL_OUTFLAGS     = DEF(IASL_OUTFLAGS)
 
-- 
2.8.0.windows.1



^ permalink raw reply related	[flat|nested] 9+ messages in thread

* Re: [Patch 0/2] BaseTools tools_def.txt: Update GCC ASLPP_FLAGS
  2016-11-14  6:37 [Patch 0/2] BaseTools tools_def.txt: Update GCC ASLPP_FLAGS Liming Gao
  2016-11-14  6:37 ` [Patch 1/2] BaseTools tools_def.txt: Remove -P option in " Liming Gao
  2016-11-14  6:37 ` [Patch 2/2] BaseTools tools_def.txt: Include AutoGen.h " Liming Gao
@ 2016-11-14  7:21 ` Zhu, Yonghong
  2 siblings, 0 replies; 9+ messages in thread
From: Zhu, Yonghong @ 2016-11-14  7:21 UTC (permalink / raw)
  To: Gao, Liming, edk2-devel@lists.01.org

Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com> 

Best Regards,
Zhu Yonghong


-----Original Message-----
From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Liming Gao
Sent: Monday, November 14, 2016 2:37 PM
To: edk2-devel@lists.01.org
Subject: [edk2] [Patch 0/2] BaseTools tools_def.txt: Update GCC ASLPP_FLAGS

Update GCC ASLPP_FLAGS to align to VS ASLPP_FLAGS so that the same ASL file can support GCC and VS tool chains both. 

Liming Gao (2):
  BaseTools tools_def.txt: Remove -P option in GCC ASLPP_FLAGS
  BaseTools tools_def.txt: Include AutoGen.h in GCC ASLPP_FLAGS

 BaseTools/Conf/tools_def.template | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

--
2.8.0.windows.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [Patch 1/2] BaseTools tools_def.txt: Remove -P option in GCC ASLPP_FLAGS
  2016-11-14  6:37 ` [Patch 1/2] BaseTools tools_def.txt: Remove -P option in " Liming Gao
@ 2016-11-23 10:09   ` Ard Biesheuvel
  2016-11-24  4:40     ` Gao, Liming
  0 siblings, 1 reply; 9+ messages in thread
From: Ard Biesheuvel @ 2016-11-23 10:09 UTC (permalink / raw)
  To: Liming Gao; +Cc: edk2-devel-01

On 14 November 2016 at 06:37, Liming Gao <liming.gao@intel.com> wrote:
> https://bugzilla.tianocore.org/show_bug.cgi?id=227
>
> After -P option is removed, the generated preprocessed ASL file will have
> line markers. The extra information can be removed by Trim script. ASL code
> can refer to the definition in C source file. This has been supported in
> VS and XCODE tool chains.
>
> Cc: Yonghong Zhu <yonghong.zhu@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Liming Gao <liming.gao@intel.com>
> ---
>  BaseTools/Conf/tools_def.template | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>

This patch is breaking the build on some AArch64 platforms:

Intel ACPI Component Architecture
Error    6126 - syntax error, unexpected PARSEOP_NAMESEG, expecting
PARSEOP_DEFINITION_BLOCK and premature End-Of-File
ASL+ Optimizing Compiler version 20160831-64

and the DSDT.iiii source file has these lines at the beginning

"""
extern UINT8 _VerifySizeofBOOLEAN[(sizeof(BOOLEAN) == (1)) /
(sizeof(BOOLEAN) == (1))];
extern UINT8 _VerifySizeofINT8[(sizeof(INT8) == (1)) / (sizeof(INT8) == (1))];
extern UINT8 _VerifySizeofUINT8[(sizeof(UINT8) == (1)) /
(sizeof(UINT8) == (1))];
extern UINT8 _VerifySizeofINT16[(sizeof(INT16) == (2)) /
(sizeof(INT16) == (2))];
extern UINT8 _VerifySizeofUINT16[(sizeof(UINT16) == (2)) /
(sizeof(UINT16) == (2))];
extern UINT8 _VerifySizeofINT32[(sizeof(INT32) == (4)) /
(sizeof(INT32) == (4))];
extern UINT8 _VerifySizeofUINT32[(sizeof(UINT32) == (4)) /
(sizeof(UINT32) == (4))];
extern UINT8 _VerifySizeofINT64[(sizeof(INT64) == (8)) /
(sizeof(INT64) == (8))];
extern UINT8 _VerifySizeofUINT64[(sizeof(UINT64) == (8)) /
(sizeof(UINT64) == (8))];
extern UINT8 _VerifySizeofCHAR8[(sizeof(CHAR8) == (1)) /
(sizeof(CHAR8) == (1))];
extern UINT8 _VerifySizeofCHAR16[(sizeof(CHAR16) == (2)) /
(sizeof(CHAR16) == (2))];
extern UINT8 _VerifySizeof__VERIFY_UINT8_ENUM_SIZE[(sizeof(__VERIFY_UINT8_ENUM_SIZE)
== (4)) / (sizeof(__VERIFY_UINT8_ENUM_SIZE) == (4))];
extern UINT8 _VerifySizeof__VERIFY_UINT16_ENUM_SIZE[(sizeof(__VERIFY_UINT16_ENUM_SIZE)
== (4)) / (sizeof(__VERIFY_UINT16_ENUM_SIZE) == (4))];
extern UINT8 _VerifySizeof__VERIFY_UINT32_ENUM_SIZE[(sizeof(__VERIFY_UINT32_ENUM_SIZE)
== (4)) / (sizeof(__VERIFY_UINT32_ENUM_SIZE) == (4))];
struct _LIST_ENTRY {
  LIST_ENTRY *ForwardLink;
  LIST_ENTRY *BackLink;
};
  void * __builtin_return_address (unsigned int level);
extern GUID gEfiCallerIdGuid;
extern CHAR8 *gEfiCallerBaseName;
"""


> diff --git a/BaseTools/Conf/tools_def.template b/BaseTools/Conf/tools_def.template
> index 39fda78..fd56ff3 100755
> --- a/BaseTools/Conf/tools_def.template
> +++ b/BaseTools/Conf/tools_def.template
> @@ -4359,7 +4359,7 @@ DEFINE GCC_IPF_SYMRENAME_FLAGS     = --redefine-sym memcpy=CopyMem
>  DEFINE GCC_ASM_FLAGS               = -c -x assembler -imacros $(DEST_DIR_DEBUG)/AutoGen.h
>  DEFINE GCC_PP_FLAGS                = -E -x assembler-with-cpp -include $(DEST_DIR_DEBUG)/AutoGen.h
>  DEFINE GCC_VFRPP_FLAGS             = -x c -E -P -DVFRCOMPILE --include $(DEST_DIR_DEBUG)/$(MODULE_NAME)StrDefs.h
> -DEFINE GCC_ASLPP_FLAGS             = -x c -E -P
> +DEFINE GCC_ASLPP_FLAGS             = -x c -E
>  DEFINE GCC_ASLCC_FLAGS             = -x c
>  DEFINE GCC_WINDRES_FLAGS           = -J rc -O coff
>  DEFINE GCC_IA32_RC_FLAGS           = -I binary -O elf32-i386          -B i386    --rename-section .data=.hii
> @@ -5804,7 +5804,7 @@ RELEASE_CLANG38_X64_CC_FLAGS       = DEF(CLANG38_ALL_CC_FLAGS) -m64 "-DEFIAPI=__
>  *_ELFGCC_*_ASL_PATH                     = DEF(UNIX_IASL_BIN)
>  *_ELFGCC_*_ASL_FLAGS                    = DEF(IASL_FLAGS)
>  *_ELFGCC_*_ASL_OUTFLAGS                 = DEF(IASL_OUTFLAGS)
> -*_ELFGCC_*_ASLPP_FLAGS                  = -x c -E -P
> +*_ELFGCC_*_ASLPP_FLAGS                  = -x c -E
>  *_ELFGCC_*_ASLCC_FLAGS                  = -x c
>  *_ELFGCC_*_ASLDLINK_FLAGS               = DEF(GCC_DLINK_FLAGS_COMMON) --entry _ReferenceAcpiTable
>
> --
> 2.8.0.windows.1
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [Patch 1/2] BaseTools tools_def.txt: Remove -P option in GCC ASLPP_FLAGS
  2016-11-23 10:09   ` Ard Biesheuvel
@ 2016-11-24  4:40     ` Gao, Liming
  2016-11-24  8:03       ` Ard Biesheuvel
  0 siblings, 1 reply; 9+ messages in thread
From: Gao, Liming @ 2016-11-24  4:40 UTC (permalink / raw)
  To: Ard Biesheuvel; +Cc: edk2-devel-01

Ard:
  Which AArch64 platforms? I will investigate it further. 

Thanks
Liming
> -----Original Message-----
> From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org]
> Sent: Wednesday, November 23, 2016 6:09 PM
> To: Gao, Liming <liming.gao@intel.com>
> Cc: edk2-devel-01 <edk2-devel@lists.01.org>
> Subject: Re: [edk2] [Patch 1/2] BaseTools tools_def.txt: Remove -P option in
> GCC ASLPP_FLAGS
> 
> On 14 November 2016 at 06:37, Liming Gao <liming.gao@intel.com> wrote:
> > https://bugzilla.tianocore.org/show_bug.cgi?id=227
> >
> > After -P option is removed, the generated preprocessed ASL file will have
> > line markers. The extra information can be removed by Trim script. ASL
> code
> > can refer to the definition in C source file. This has been supported in
> > VS and XCODE tool chains.
> >
> > Cc: Yonghong Zhu <yonghong.zhu@intel.com>
> > Contributed-under: TianoCore Contribution Agreement 1.0
> > Signed-off-by: Liming Gao <liming.gao@intel.com>
> > ---
> >  BaseTools/Conf/tools_def.template | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> 
> This patch is breaking the build on some AArch64 platforms:
> 
> Intel ACPI Component Architecture
> Error    6126 - syntax error, unexpected PARSEOP_NAMESEG, expecting
> PARSEOP_DEFINITION_BLOCK and premature End-Of-File
> ASL+ Optimizing Compiler version 20160831-64
> 
> and the DSDT.iiii source file has these lines at the beginning
> 
> """
> extern UINT8 _VerifySizeofBOOLEAN[(sizeof(BOOLEAN) == (1)) /
> (sizeof(BOOLEAN) == (1))];
> extern UINT8 _VerifySizeofINT8[(sizeof(INT8) == (1)) / (sizeof(INT8) == (1))];
> extern UINT8 _VerifySizeofUINT8[(sizeof(UINT8) == (1)) /
> (sizeof(UINT8) == (1))];
> extern UINT8 _VerifySizeofINT16[(sizeof(INT16) == (2)) /
> (sizeof(INT16) == (2))];
> extern UINT8 _VerifySizeofUINT16[(sizeof(UINT16) == (2)) /
> (sizeof(UINT16) == (2))];
> extern UINT8 _VerifySizeofINT32[(sizeof(INT32) == (4)) /
> (sizeof(INT32) == (4))];
> extern UINT8 _VerifySizeofUINT32[(sizeof(UINT32) == (4)) /
> (sizeof(UINT32) == (4))];
> extern UINT8 _VerifySizeofINT64[(sizeof(INT64) == (8)) /
> (sizeof(INT64) == (8))];
> extern UINT8 _VerifySizeofUINT64[(sizeof(UINT64) == (8)) /
> (sizeof(UINT64) == (8))];
> extern UINT8 _VerifySizeofCHAR8[(sizeof(CHAR8) == (1)) /
> (sizeof(CHAR8) == (1))];
> extern UINT8 _VerifySizeofCHAR16[(sizeof(CHAR16) == (2)) /
> (sizeof(CHAR16) == (2))];
> extern UINT8
> _VerifySizeof__VERIFY_UINT8_ENUM_SIZE[(sizeof(__VERIFY_UINT8_ENUM
> _SIZE)
> == (4)) / (sizeof(__VERIFY_UINT8_ENUM_SIZE) == (4))];
> extern UINT8
> _VerifySizeof__VERIFY_UINT16_ENUM_SIZE[(sizeof(__VERIFY_UINT16_EN
> UM_SIZE)
> == (4)) / (sizeof(__VERIFY_UINT16_ENUM_SIZE) == (4))];
> extern UINT8
> _VerifySizeof__VERIFY_UINT32_ENUM_SIZE[(sizeof(__VERIFY_UINT32_EN
> UM_SIZE)
> == (4)) / (sizeof(__VERIFY_UINT32_ENUM_SIZE) == (4))];
> struct _LIST_ENTRY {
>   LIST_ENTRY *ForwardLink;
>   LIST_ENTRY *BackLink;
> };
>   void * __builtin_return_address (unsigned int level);
> extern GUID gEfiCallerIdGuid;
> extern CHAR8 *gEfiCallerBaseName;
> """
> 
> 
> > diff --git a/BaseTools/Conf/tools_def.template
> b/BaseTools/Conf/tools_def.template
> > index 39fda78..fd56ff3 100755
> > --- a/BaseTools/Conf/tools_def.template
> > +++ b/BaseTools/Conf/tools_def.template
> > @@ -4359,7 +4359,7 @@ DEFINE GCC_IPF_SYMRENAME_FLAGS     = --
> redefine-sym memcpy=CopyMem
> >  DEFINE GCC_ASM_FLAGS               = -c -x assembler -imacros
> $(DEST_DIR_DEBUG)/AutoGen.h
> >  DEFINE GCC_PP_FLAGS                = -E -x assembler-with-cpp -include
> $(DEST_DIR_DEBUG)/AutoGen.h
> >  DEFINE GCC_VFRPP_FLAGS             = -x c -E -P -DVFRCOMPILE --include
> $(DEST_DIR_DEBUG)/$(MODULE_NAME)StrDefs.h
> > -DEFINE GCC_ASLPP_FLAGS             = -x c -E -P
> > +DEFINE GCC_ASLPP_FLAGS             = -x c -E
> >  DEFINE GCC_ASLCC_FLAGS             = -x c
> >  DEFINE GCC_WINDRES_FLAGS           = -J rc -O coff
> >  DEFINE GCC_IA32_RC_FLAGS           = -I binary -O elf32-i386          -B i386    --
> rename-section .data=.hii
> > @@ -5804,7 +5804,7 @@ RELEASE_CLANG38_X64_CC_FLAGS       =
> DEF(CLANG38_ALL_CC_FLAGS) -m64 "-DEFIAPI=__
> >  *_ELFGCC_*_ASL_PATH                     = DEF(UNIX_IASL_BIN)
> >  *_ELFGCC_*_ASL_FLAGS                    = DEF(IASL_FLAGS)
> >  *_ELFGCC_*_ASL_OUTFLAGS                 = DEF(IASL_OUTFLAGS)
> > -*_ELFGCC_*_ASLPP_FLAGS                  = -x c -E -P
> > +*_ELFGCC_*_ASLPP_FLAGS                  = -x c -E
> >  *_ELFGCC_*_ASLCC_FLAGS                  = -x c
> >  *_ELFGCC_*_ASLDLINK_FLAGS               =
> DEF(GCC_DLINK_FLAGS_COMMON) --entry _ReferenceAcpiTable
> >
> > --
> > 2.8.0.windows.1
> >
> > _______________________________________________
> > edk2-devel mailing list
> > edk2-devel@lists.01.org
> > https://lists.01.org/mailman/listinfo/edk2-devel

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [Patch 1/2] BaseTools tools_def.txt: Remove -P option in GCC ASLPP_FLAGS
  2016-11-24  4:40     ` Gao, Liming
@ 2016-11-24  8:03       ` Ard Biesheuvel
  2016-11-28  2:31         ` Gao, Liming
  0 siblings, 1 reply; 9+ messages in thread
From: Ard Biesheuvel @ 2016-11-24  8:03 UTC (permalink / raw)
  To: Gao, Liming; +Cc: edk2-devel-01

On 24 November 2016 at 04:40, Gao, Liming <liming.gao@intel.com> wrote:
> Ard:
>   Which AArch64 platforms? I will investigate it further.
>

https://git.linaro.org/uefi/OpenPlatformPkg.git master

platform
OpenPlatformPkg/Platforms/AMD/Styx/OverdriveBoard/OverdriveBoard.dsc

module
OpenPlatformPkg/Platforms/AMD/Styx/AcpiTables/AcpiAml.inf



> Thanks
> Liming
>> -----Original Message-----
>> From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org]
>> Sent: Wednesday, November 23, 2016 6:09 PM
>> To: Gao, Liming <liming.gao@intel.com>
>> Cc: edk2-devel-01 <edk2-devel@lists.01.org>
>> Subject: Re: [edk2] [Patch 1/2] BaseTools tools_def.txt: Remove -P option in
>> GCC ASLPP_FLAGS
>>
>> On 14 November 2016 at 06:37, Liming Gao <liming.gao@intel.com> wrote:
>> > https://bugzilla.tianocore.org/show_bug.cgi?id=227
>> >
>> > After -P option is removed, the generated preprocessed ASL file will have
>> > line markers. The extra information can be removed by Trim script. ASL
>> code
>> > can refer to the definition in C source file. This has been supported in
>> > VS and XCODE tool chains.
>> >
>> > Cc: Yonghong Zhu <yonghong.zhu@intel.com>
>> > Contributed-under: TianoCore Contribution Agreement 1.0
>> > Signed-off-by: Liming Gao <liming.gao@intel.com>
>> > ---
>> >  BaseTools/Conf/tools_def.template | 4 ++--
>> >  1 file changed, 2 insertions(+), 2 deletions(-)
>> >
>>
>> This patch is breaking the build on some AArch64 platforms:
>>
>> Intel ACPI Component Architecture
>> Error    6126 - syntax error, unexpected PARSEOP_NAMESEG, expecting
>> PARSEOP_DEFINITION_BLOCK and premature End-Of-File
>> ASL+ Optimizing Compiler version 20160831-64
>>
>> and the DSDT.iiii source file has these lines at the beginning
>>
>> """
>> extern UINT8 _VerifySizeofBOOLEAN[(sizeof(BOOLEAN) == (1)) /
>> (sizeof(BOOLEAN) == (1))];
>> extern UINT8 _VerifySizeofINT8[(sizeof(INT8) == (1)) / (sizeof(INT8) == (1))];
>> extern UINT8 _VerifySizeofUINT8[(sizeof(UINT8) == (1)) /
>> (sizeof(UINT8) == (1))];
>> extern UINT8 _VerifySizeofINT16[(sizeof(INT16) == (2)) /
>> (sizeof(INT16) == (2))];
>> extern UINT8 _VerifySizeofUINT16[(sizeof(UINT16) == (2)) /
>> (sizeof(UINT16) == (2))];
>> extern UINT8 _VerifySizeofINT32[(sizeof(INT32) == (4)) /
>> (sizeof(INT32) == (4))];
>> extern UINT8 _VerifySizeofUINT32[(sizeof(UINT32) == (4)) /
>> (sizeof(UINT32) == (4))];
>> extern UINT8 _VerifySizeofINT64[(sizeof(INT64) == (8)) /
>> (sizeof(INT64) == (8))];
>> extern UINT8 _VerifySizeofUINT64[(sizeof(UINT64) == (8)) /
>> (sizeof(UINT64) == (8))];
>> extern UINT8 _VerifySizeofCHAR8[(sizeof(CHAR8) == (1)) /
>> (sizeof(CHAR8) == (1))];
>> extern UINT8 _VerifySizeofCHAR16[(sizeof(CHAR16) == (2)) /
>> (sizeof(CHAR16) == (2))];
>> extern UINT8
>> _VerifySizeof__VERIFY_UINT8_ENUM_SIZE[(sizeof(__VERIFY_UINT8_ENUM
>> _SIZE)
>> == (4)) / (sizeof(__VERIFY_UINT8_ENUM_SIZE) == (4))];
>> extern UINT8
>> _VerifySizeof__VERIFY_UINT16_ENUM_SIZE[(sizeof(__VERIFY_UINT16_EN
>> UM_SIZE)
>> == (4)) / (sizeof(__VERIFY_UINT16_ENUM_SIZE) == (4))];
>> extern UINT8
>> _VerifySizeof__VERIFY_UINT32_ENUM_SIZE[(sizeof(__VERIFY_UINT32_EN
>> UM_SIZE)
>> == (4)) / (sizeof(__VERIFY_UINT32_ENUM_SIZE) == (4))];
>> struct _LIST_ENTRY {
>>   LIST_ENTRY *ForwardLink;
>>   LIST_ENTRY *BackLink;
>> };
>>   void * __builtin_return_address (unsigned int level);
>> extern GUID gEfiCallerIdGuid;
>> extern CHAR8 *gEfiCallerBaseName;
>> """
>>
>>
>> > diff --git a/BaseTools/Conf/tools_def.template
>> b/BaseTools/Conf/tools_def.template
>> > index 39fda78..fd56ff3 100755
>> > --- a/BaseTools/Conf/tools_def.template
>> > +++ b/BaseTools/Conf/tools_def.template
>> > @@ -4359,7 +4359,7 @@ DEFINE GCC_IPF_SYMRENAME_FLAGS     = --
>> redefine-sym memcpy=CopyMem
>> >  DEFINE GCC_ASM_FLAGS               = -c -x assembler -imacros
>> $(DEST_DIR_DEBUG)/AutoGen.h
>> >  DEFINE GCC_PP_FLAGS                = -E -x assembler-with-cpp -include
>> $(DEST_DIR_DEBUG)/AutoGen.h
>> >  DEFINE GCC_VFRPP_FLAGS             = -x c -E -P -DVFRCOMPILE --include
>> $(DEST_DIR_DEBUG)/$(MODULE_NAME)StrDefs.h
>> > -DEFINE GCC_ASLPP_FLAGS             = -x c -E -P
>> > +DEFINE GCC_ASLPP_FLAGS             = -x c -E
>> >  DEFINE GCC_ASLCC_FLAGS             = -x c
>> >  DEFINE GCC_WINDRES_FLAGS           = -J rc -O coff
>> >  DEFINE GCC_IA32_RC_FLAGS           = -I binary -O elf32-i386          -B i386    --
>> rename-section .data=.hii
>> > @@ -5804,7 +5804,7 @@ RELEASE_CLANG38_X64_CC_FLAGS       =
>> DEF(CLANG38_ALL_CC_FLAGS) -m64 "-DEFIAPI=__
>> >  *_ELFGCC_*_ASL_PATH                     = DEF(UNIX_IASL_BIN)
>> >  *_ELFGCC_*_ASL_FLAGS                    = DEF(IASL_FLAGS)
>> >  *_ELFGCC_*_ASL_OUTFLAGS                 = DEF(IASL_OUTFLAGS)
>> > -*_ELFGCC_*_ASLPP_FLAGS                  = -x c -E -P
>> > +*_ELFGCC_*_ASLPP_FLAGS                  = -x c -E
>> >  *_ELFGCC_*_ASLCC_FLAGS                  = -x c
>> >  *_ELFGCC_*_ASLDLINK_FLAGS               =
>> DEF(GCC_DLINK_FLAGS_COMMON) --entry _ReferenceAcpiTable
>> >
>> > --
>> > 2.8.0.windows.1
>> >
>> > _______________________________________________
>> > edk2-devel mailing list
>> > edk2-devel@lists.01.org
>> > https://lists.01.org/mailman/listinfo/edk2-devel


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [Patch 1/2] BaseTools tools_def.txt: Remove -P option in GCC ASLPP_FLAGS
  2016-11-24  8:03       ` Ard Biesheuvel
@ 2016-11-28  2:31         ` Gao, Liming
  2016-11-28  7:57           ` Ard Biesheuvel
  0 siblings, 1 reply; 9+ messages in thread
From: Gao, Liming @ 2016-11-28  2:31 UTC (permalink / raw)
  To: Ard Biesheuvel; +Cc: edk2-devel-01

Ard:
  I root cause the issue, and provide the fix. Could you help integrate it?

Thanks
Liming
> -----Original Message-----
> From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org]
> Sent: Thursday, November 24, 2016 4:04 PM
> To: Gao, Liming <liming.gao@intel.com>
> Cc: edk2-devel-01 <edk2-devel@lists.01.org>
> Subject: Re: [edk2] [Patch 1/2] BaseTools tools_def.txt: Remove -P option in
> GCC ASLPP_FLAGS
> 
> On 24 November 2016 at 04:40, Gao, Liming <liming.gao@intel.com> wrote:
> > Ard:
> >   Which AArch64 platforms? I will investigate it further.
> >
> 
> https://git.linaro.org/uefi/OpenPlatformPkg.git master
> 
> platform
> OpenPlatformPkg/Platforms/AMD/Styx/OverdriveBoard/OverdriveBoard.ds
> c
> 
> module
> OpenPlatformPkg/Platforms/AMD/Styx/AcpiTables/AcpiAml.inf
> 
> 
> 
> > Thanks
> > Liming
> >> -----Original Message-----
> >> From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org]
> >> Sent: Wednesday, November 23, 2016 6:09 PM
> >> To: Gao, Liming <liming.gao@intel.com>
> >> Cc: edk2-devel-01 <edk2-devel@lists.01.org>
> >> Subject: Re: [edk2] [Patch 1/2] BaseTools tools_def.txt: Remove -P option
> in
> >> GCC ASLPP_FLAGS
> >>
> >> On 14 November 2016 at 06:37, Liming Gao <liming.gao@intel.com> wrote:
> >> > https://bugzilla.tianocore.org/show_bug.cgi?id=227
> >> >
> >> > After -P option is removed, the generated preprocessed ASL file will
> have
> >> > line markers. The extra information can be removed by Trim script. ASL
> >> code
> >> > can refer to the definition in C source file. This has been supported in
> >> > VS and XCODE tool chains.
> >> >
> >> > Cc: Yonghong Zhu <yonghong.zhu@intel.com>
> >> > Contributed-under: TianoCore Contribution Agreement 1.0
> >> > Signed-off-by: Liming Gao <liming.gao@intel.com>
> >> > ---
> >> >  BaseTools/Conf/tools_def.template | 4 ++--
> >> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >> >
> >>
> >> This patch is breaking the build on some AArch64 platforms:
> >>
> >> Intel ACPI Component Architecture
> >> Error    6126 - syntax error, unexpected PARSEOP_NAMESEG, expecting
> >> PARSEOP_DEFINITION_BLOCK and premature End-Of-File
> >> ASL+ Optimizing Compiler version 20160831-64
> >>
> >> and the DSDT.iiii source file has these lines at the beginning
> >>
> >> """
> >> extern UINT8 _VerifySizeofBOOLEAN[(sizeof(BOOLEAN) == (1)) /
> >> (sizeof(BOOLEAN) == (1))];
> >> extern UINT8 _VerifySizeofINT8[(sizeof(INT8) == (1)) / (sizeof(INT8) ==
> (1))];
> >> extern UINT8 _VerifySizeofUINT8[(sizeof(UINT8) == (1)) /
> >> (sizeof(UINT8) == (1))];
> >> extern UINT8 _VerifySizeofINT16[(sizeof(INT16) == (2)) /
> >> (sizeof(INT16) == (2))];
> >> extern UINT8 _VerifySizeofUINT16[(sizeof(UINT16) == (2)) /
> >> (sizeof(UINT16) == (2))];
> >> extern UINT8 _VerifySizeofINT32[(sizeof(INT32) == (4)) /
> >> (sizeof(INT32) == (4))];
> >> extern UINT8 _VerifySizeofUINT32[(sizeof(UINT32) == (4)) /
> >> (sizeof(UINT32) == (4))];
> >> extern UINT8 _VerifySizeofINT64[(sizeof(INT64) == (8)) /
> >> (sizeof(INT64) == (8))];
> >> extern UINT8 _VerifySizeofUINT64[(sizeof(UINT64) == (8)) /
> >> (sizeof(UINT64) == (8))];
> >> extern UINT8 _VerifySizeofCHAR8[(sizeof(CHAR8) == (1)) /
> >> (sizeof(CHAR8) == (1))];
> >> extern UINT8 _VerifySizeofCHAR16[(sizeof(CHAR16) == (2)) /
> >> (sizeof(CHAR16) == (2))];
> >> extern UINT8
> >>
> _VerifySizeof__VERIFY_UINT8_ENUM_SIZE[(sizeof(__VERIFY_UINT8_ENUM
> >> _SIZE)
> >> == (4)) / (sizeof(__VERIFY_UINT8_ENUM_SIZE) == (4))];
> >> extern UINT8
> >>
> _VerifySizeof__VERIFY_UINT16_ENUM_SIZE[(sizeof(__VERIFY_UINT16_EN
> >> UM_SIZE)
> >> == (4)) / (sizeof(__VERIFY_UINT16_ENUM_SIZE) == (4))];
> >> extern UINT8
> >>
> _VerifySizeof__VERIFY_UINT32_ENUM_SIZE[(sizeof(__VERIFY_UINT32_EN
> >> UM_SIZE)
> >> == (4)) / (sizeof(__VERIFY_UINT32_ENUM_SIZE) == (4))];
> >> struct _LIST_ENTRY {
> >>   LIST_ENTRY *ForwardLink;
> >>   LIST_ENTRY *BackLink;
> >> };
> >>   void * __builtin_return_address (unsigned int level);
> >> extern GUID gEfiCallerIdGuid;
> >> extern CHAR8 *gEfiCallerBaseName;
> >> """
> >>
> >>
> >> > diff --git a/BaseTools/Conf/tools_def.template
> >> b/BaseTools/Conf/tools_def.template
> >> > index 39fda78..fd56ff3 100755
> >> > --- a/BaseTools/Conf/tools_def.template
> >> > +++ b/BaseTools/Conf/tools_def.template
> >> > @@ -4359,7 +4359,7 @@ DEFINE GCC_IPF_SYMRENAME_FLAGS     = --
> >> redefine-sym memcpy=CopyMem
> >> >  DEFINE GCC_ASM_FLAGS               = -c -x assembler -imacros
> >> $(DEST_DIR_DEBUG)/AutoGen.h
> >> >  DEFINE GCC_PP_FLAGS                = -E -x assembler-with-cpp -include
> >> $(DEST_DIR_DEBUG)/AutoGen.h
> >> >  DEFINE GCC_VFRPP_FLAGS             = -x c -E -P -DVFRCOMPILE --include
> >> $(DEST_DIR_DEBUG)/$(MODULE_NAME)StrDefs.h
> >> > -DEFINE GCC_ASLPP_FLAGS             = -x c -E -P
> >> > +DEFINE GCC_ASLPP_FLAGS             = -x c -E
> >> >  DEFINE GCC_ASLCC_FLAGS             = -x c
> >> >  DEFINE GCC_WINDRES_FLAGS           = -J rc -O coff
> >> >  DEFINE GCC_IA32_RC_FLAGS           = -I binary -O elf32-i386          -B i386
> --
> >> rename-section .data=.hii
> >> > @@ -5804,7 +5804,7 @@ RELEASE_CLANG38_X64_CC_FLAGS       =
> >> DEF(CLANG38_ALL_CC_FLAGS) -m64 "-DEFIAPI=__
> >> >  *_ELFGCC_*_ASL_PATH                     = DEF(UNIX_IASL_BIN)
> >> >  *_ELFGCC_*_ASL_FLAGS                    = DEF(IASL_FLAGS)
> >> >  *_ELFGCC_*_ASL_OUTFLAGS                 = DEF(IASL_OUTFLAGS)
> >> > -*_ELFGCC_*_ASLPP_FLAGS                  = -x c -E -P
> >> > +*_ELFGCC_*_ASLPP_FLAGS                  = -x c -E
> >> >  *_ELFGCC_*_ASLCC_FLAGS                  = -x c
> >> >  *_ELFGCC_*_ASLDLINK_FLAGS               =
> >> DEF(GCC_DLINK_FLAGS_COMMON) --entry _ReferenceAcpiTable
> >> >
> >> > --
> >> > 2.8.0.windows.1
> >> >
> >> > _______________________________________________
> >> > edk2-devel mailing list
> >> > edk2-devel@lists.01.org
> >> > https://lists.01.org/mailman/listinfo/edk2-devel

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [Patch 1/2] BaseTools tools_def.txt: Remove -P option in GCC ASLPP_FLAGS
  2016-11-28  2:31         ` Gao, Liming
@ 2016-11-28  7:57           ` Ard Biesheuvel
  0 siblings, 0 replies; 9+ messages in thread
From: Ard Biesheuvel @ 2016-11-28  7:57 UTC (permalink / raw)
  To: Gao, Liming, Leif Lindholm; +Cc: edk2-devel-01

On 28 November 2016 at 02:31, Gao, Liming <liming.gao@intel.com> wrote:
> Ard:
>   I root cause the issue, and provide the fix. Could you help integrate it?
>

Thanks for tracking this down. I had no idea the culprit was the
platform .DSC rather than the core code

We will merge the fix.

Thanks,
Ard.

> Thanks
> Liming
>> -----Original Message-----
>> From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org]
>> Sent: Thursday, November 24, 2016 4:04 PM
>> To: Gao, Liming <liming.gao@intel.com>
>> Cc: edk2-devel-01 <edk2-devel@lists.01.org>
>> Subject: Re: [edk2] [Patch 1/2] BaseTools tools_def.txt: Remove -P option in
>> GCC ASLPP_FLAGS
>>
>> On 24 November 2016 at 04:40, Gao, Liming <liming.gao@intel.com> wrote:
>> > Ard:
>> >   Which AArch64 platforms? I will investigate it further.
>> >
>>
>> https://git.linaro.org/uefi/OpenPlatformPkg.git master
>>
>> platform
>> OpenPlatformPkg/Platforms/AMD/Styx/OverdriveBoard/OverdriveBoard.ds
>> c
>>
>> module
>> OpenPlatformPkg/Platforms/AMD/Styx/AcpiTables/AcpiAml.inf
>>
>>
>>
>> > Thanks
>> > Liming
>> >> -----Original Message-----
>> >> From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org]
>> >> Sent: Wednesday, November 23, 2016 6:09 PM
>> >> To: Gao, Liming <liming.gao@intel.com>
>> >> Cc: edk2-devel-01 <edk2-devel@lists.01.org>
>> >> Subject: Re: [edk2] [Patch 1/2] BaseTools tools_def.txt: Remove -P option
>> in
>> >> GCC ASLPP_FLAGS
>> >>
>> >> On 14 November 2016 at 06:37, Liming Gao <liming.gao@intel.com> wrote:
>> >> > https://bugzilla.tianocore.org/show_bug.cgi?id=227
>> >> >
>> >> > After -P option is removed, the generated preprocessed ASL file will
>> have
>> >> > line markers. The extra information can be removed by Trim script. ASL
>> >> code
>> >> > can refer to the definition in C source file. This has been supported in
>> >> > VS and XCODE tool chains.
>> >> >
>> >> > Cc: Yonghong Zhu <yonghong.zhu@intel.com>
>> >> > Contributed-under: TianoCore Contribution Agreement 1.0
>> >> > Signed-off-by: Liming Gao <liming.gao@intel.com>
>> >> > ---
>> >> >  BaseTools/Conf/tools_def.template | 4 ++--
>> >> >  1 file changed, 2 insertions(+), 2 deletions(-)
>> >> >
>> >>
>> >> This patch is breaking the build on some AArch64 platforms:
>> >>
>> >> Intel ACPI Component Architecture
>> >> Error    6126 - syntax error, unexpected PARSEOP_NAMESEG, expecting
>> >> PARSEOP_DEFINITION_BLOCK and premature End-Of-File
>> >> ASL+ Optimizing Compiler version 20160831-64
>> >>
>> >> and the DSDT.iiii source file has these lines at the beginning
>> >>
>> >> """
>> >> extern UINT8 _VerifySizeofBOOLEAN[(sizeof(BOOLEAN) == (1)) /
>> >> (sizeof(BOOLEAN) == (1))];
>> >> extern UINT8 _VerifySizeofINT8[(sizeof(INT8) == (1)) / (sizeof(INT8) ==
>> (1))];
>> >> extern UINT8 _VerifySizeofUINT8[(sizeof(UINT8) == (1)) /
>> >> (sizeof(UINT8) == (1))];
>> >> extern UINT8 _VerifySizeofINT16[(sizeof(INT16) == (2)) /
>> >> (sizeof(INT16) == (2))];
>> >> extern UINT8 _VerifySizeofUINT16[(sizeof(UINT16) == (2)) /
>> >> (sizeof(UINT16) == (2))];
>> >> extern UINT8 _VerifySizeofINT32[(sizeof(INT32) == (4)) /
>> >> (sizeof(INT32) == (4))];
>> >> extern UINT8 _VerifySizeofUINT32[(sizeof(UINT32) == (4)) /
>> >> (sizeof(UINT32) == (4))];
>> >> extern UINT8 _VerifySizeofINT64[(sizeof(INT64) == (8)) /
>> >> (sizeof(INT64) == (8))];
>> >> extern UINT8 _VerifySizeofUINT64[(sizeof(UINT64) == (8)) /
>> >> (sizeof(UINT64) == (8))];
>> >> extern UINT8 _VerifySizeofCHAR8[(sizeof(CHAR8) == (1)) /
>> >> (sizeof(CHAR8) == (1))];
>> >> extern UINT8 _VerifySizeofCHAR16[(sizeof(CHAR16) == (2)) /
>> >> (sizeof(CHAR16) == (2))];
>> >> extern UINT8
>> >>
>> _VerifySizeof__VERIFY_UINT8_ENUM_SIZE[(sizeof(__VERIFY_UINT8_ENUM
>> >> _SIZE)
>> >> == (4)) / (sizeof(__VERIFY_UINT8_ENUM_SIZE) == (4))];
>> >> extern UINT8
>> >>
>> _VerifySizeof__VERIFY_UINT16_ENUM_SIZE[(sizeof(__VERIFY_UINT16_EN
>> >> UM_SIZE)
>> >> == (4)) / (sizeof(__VERIFY_UINT16_ENUM_SIZE) == (4))];
>> >> extern UINT8
>> >>
>> _VerifySizeof__VERIFY_UINT32_ENUM_SIZE[(sizeof(__VERIFY_UINT32_EN
>> >> UM_SIZE)
>> >> == (4)) / (sizeof(__VERIFY_UINT32_ENUM_SIZE) == (4))];
>> >> struct _LIST_ENTRY {
>> >>   LIST_ENTRY *ForwardLink;
>> >>   LIST_ENTRY *BackLink;
>> >> };
>> >>   void * __builtin_return_address (unsigned int level);
>> >> extern GUID gEfiCallerIdGuid;
>> >> extern CHAR8 *gEfiCallerBaseName;
>> >> """
>> >>
>> >>
>> >> > diff --git a/BaseTools/Conf/tools_def.template
>> >> b/BaseTools/Conf/tools_def.template
>> >> > index 39fda78..fd56ff3 100755
>> >> > --- a/BaseTools/Conf/tools_def.template
>> >> > +++ b/BaseTools/Conf/tools_def.template
>> >> > @@ -4359,7 +4359,7 @@ DEFINE GCC_IPF_SYMRENAME_FLAGS     = --
>> >> redefine-sym memcpy=CopyMem
>> >> >  DEFINE GCC_ASM_FLAGS               = -c -x assembler -imacros
>> >> $(DEST_DIR_DEBUG)/AutoGen.h
>> >> >  DEFINE GCC_PP_FLAGS                = -E -x assembler-with-cpp -include
>> >> $(DEST_DIR_DEBUG)/AutoGen.h
>> >> >  DEFINE GCC_VFRPP_FLAGS             = -x c -E -P -DVFRCOMPILE --include
>> >> $(DEST_DIR_DEBUG)/$(MODULE_NAME)StrDefs.h
>> >> > -DEFINE GCC_ASLPP_FLAGS             = -x c -E -P
>> >> > +DEFINE GCC_ASLPP_FLAGS             = -x c -E
>> >> >  DEFINE GCC_ASLCC_FLAGS             = -x c
>> >> >  DEFINE GCC_WINDRES_FLAGS           = -J rc -O coff
>> >> >  DEFINE GCC_IA32_RC_FLAGS           = -I binary -O elf32-i386          -B i386
>> --
>> >> rename-section .data=.hii
>> >> > @@ -5804,7 +5804,7 @@ RELEASE_CLANG38_X64_CC_FLAGS       =
>> >> DEF(CLANG38_ALL_CC_FLAGS) -m64 "-DEFIAPI=__
>> >> >  *_ELFGCC_*_ASL_PATH                     = DEF(UNIX_IASL_BIN)
>> >> >  *_ELFGCC_*_ASL_FLAGS                    = DEF(IASL_FLAGS)
>> >> >  *_ELFGCC_*_ASL_OUTFLAGS                 = DEF(IASL_OUTFLAGS)
>> >> > -*_ELFGCC_*_ASLPP_FLAGS                  = -x c -E -P
>> >> > +*_ELFGCC_*_ASLPP_FLAGS                  = -x c -E
>> >> >  *_ELFGCC_*_ASLCC_FLAGS                  = -x c
>> >> >  *_ELFGCC_*_ASLDLINK_FLAGS               =
>> >> DEF(GCC_DLINK_FLAGS_COMMON) --entry _ReferenceAcpiTable
>> >> >
>> >> > --
>> >> > 2.8.0.windows.1
>> >> >
>> >> > _______________________________________________
>> >> > edk2-devel mailing list
>> >> > edk2-devel@lists.01.org
>> >> > https://lists.01.org/mailman/listinfo/edk2-devel


^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2016-11-28  7:57 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-14  6:37 [Patch 0/2] BaseTools tools_def.txt: Update GCC ASLPP_FLAGS Liming Gao
2016-11-14  6:37 ` [Patch 1/2] BaseTools tools_def.txt: Remove -P option in " Liming Gao
2016-11-23 10:09   ` Ard Biesheuvel
2016-11-24  4:40     ` Gao, Liming
2016-11-24  8:03       ` Ard Biesheuvel
2016-11-28  2:31         ` Gao, Liming
2016-11-28  7:57           ` Ard Biesheuvel
2016-11-14  6:37 ` [Patch 2/2] BaseTools tools_def.txt: Include AutoGen.h " Liming Gao
2016-11-14  7:21 ` [Patch 0/2] BaseTools tools_def.txt: Update " Zhu, Yonghong

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox